phpbbgallery\core\controller\moderate::queue_approve()

Complexity

Conditions	22
Paths	96

Size

Total Lines	94
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	506

Importance

Changes	2
Bugs	0	Features	0

<?php
	public function queue_approve($page, $album_id)
	{
		$approve_ary = $this->request->variable('approval', array('' => array(0)));
		$action_ary = $this->request->variable('action', array('' => 0));
		$back_link = $this->request->variable('back_link', $album_id > 0 ? $this->helper->route('phpbbgallery_core_moderate_queue_approve_album', array('album_id' => $album_id)) : $this->helper->route('phpbbgallery_core_moderate_queue_approve'));
		foreach ($action_ary as $act => $garb)
		{
			$action = $act;
		}

		$this->language->add_lang(array('gallery_mcp', 'gallery'), 'phpbbgallery/core');
		$this->language->add_lang('mcp');

		$this->gallery_auth->load_user_permissions($this->user->data['user_id']);
		$album_backlink = $album_id === 0 ? $this->helper->route('phpbbgallery_core_moderate') : $this->helper->route('phpbbgallery_core_moderate_album', array('album_id'	=> $album_id));
		$album_loginlink = append_sid($this->root_path . 'ucp.' . $this->php_ext . '?mode=login');

The function append_sid was not found. Maybe you did not declare it correctly or list all dependencies?

		if ($album_id === 0)
		{
			if (!$this->gallery_auth->acl_check_global('m_status'))
			{
				$this->misc->not_authorised($album_backlink, $album_loginlink, 'LOGIN_EXPLAIN_UPLOAD');
			}
		}
		else
		{
			$album = $this->album->get_info($album_id);
			if (!$this->gallery_auth->acl_check('m_status', $album['album_id'], $album['album_user_id']))
			{
				$this->misc->not_authorised($album_backlink, $album_loginlink, 'LOGIN_EXPLAIN_UPLOAD');
			}
		}
		if (!empty($approve_ary))
		{
			if (confirm_box(true))

The function confirm_box was not found. Maybe you did not declare it correctly or list all dependencies?

			{
				if ($action == 'approve')

The variable $action seems to be defined by a foreach iteration on line 197. Are you sure the iterator is never empty, otherwise this variable is not defined?

				{
					$count = 0;
					foreach ($approve_ary as $album_id => $approve_array)

$album_id is overwriting one of the parameters of this function.

					{
						$this->image->approve_images($approve_array, $album_id);
						$this->album->update_info($album_id);
						$count = $count + count($approve_array);
					}

					$message = $this->language->lang('WAITING_APPROVED_IMAGE', $count);
					$this->url->meta_refresh(3, $back_link);
					trigger_error($message);
				}
				if ($action == 'disapprove')
				{
					$count = 0;
					foreach ($approve_ary as $album_id => $delete_array)

$album_id is overwriting one of the parameters of this function.

					{
						// Let's load info for images, so we can
						$filenames = $this->image->get_filenames($delete_array);
						// Let's log the action
						foreach ($filenames as $name)
						{
							$this->gallery_log->add_log('moderator', 'disapprove', $album_id, 0, array('LOG_GALLERY_DISAPPROVED', $name));
						}
						$this->moderate->delete_images($delete_array);
						$count = $count + count($delete_array);
					}
					$message = $this->language->lang('WAITING_DISPPROVED_IMAGE', $count);
					$this->url->meta_refresh(3, $back_link);
					trigger_error($message);
				}
			}
			else
			{
				$s_hidden_fields = '<input type="hidden" name="action['.$action.']" value="' . $action . '" />';
				$s_hidden_fields .= '<input type="hidden" name="back_link" value="' . $back_link . '" />';
				foreach ($approve_ary as $id => $var)
				{
					foreach ($var as $var1)
					{
						$s_hidden_fields .= '<input type="hidden" name="approval[' . $id . '][]" value="' . $var1 . '" />';
					}
				}
				confirm_box(false, $this->language->lang('QUEUES_A_' . strtoupper($action) . '2_CONFIRM'), $s_hidden_fields);
			}
		}

		$this->template->assign_vars(array(
			'U_GALLERY_MODERATE_OVERVIEW'	=> $album_id > 0 ? $this->helper->route('phpbbgallery_core_moderate_album', array('album_id' => $album_id)) : $this->helper->route('phpbbgallery_core_moderate'),
			'U_GALLERY_MODERATE_APPROVE'	=> $album_id > 0 ? $this->helper->route('phpbbgallery_core_moderate_queue_approve_album', array('album_id' => $album_id)) : $this->helper->route('phpbbgallery_core_moderate_queue_approve'),
			'U_GALLERY_MODERATE_REPORT'		=> $album_id > 0 ? $this->helper->route('phpbbgallery_core_moderate_reports_album', array('album_id' => $album_id)) : $this->helper->route('phpbbgallery_core_moderate_reports'),
			'U_ALBUM_OVERVIEW'				=> $album_id > 0 ? $this->helper->route('phpbbgallery_core_moderate_view', array('album_id' => $album_id)) : false,
			'U_GALLERY_MCP_LOGS'			=> $album_id > 0 ? $this->helper->route('phpbbgallery_core_moderate_action_log_album', array('album_id' => $album_id)) : $this->helper->route('phpbbgallery_core_moderate_action_log'),
			'U_ALBUM_NAME'					=> $album_id > 0 ? $album['album_name'] : false,
		));
		$this->moderate->build_list($album_id, $page);
		return $this->helper->render('gallery/moderate_approve.html', $this->language->lang('GALLERY'));
	}