phpbbgallery\core\search::random()

Complexity

Conditions	16
Paths	481

Size

Total Lines	122
Code Lines	73

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	53
CRAP Score	18.7482

Importance

Changes	3
Bugs	0	Features	0

<?php
	public function random($limit, $user = 0, $fields = 'rrc_gindex_display', $block_name = false, $u_block = false)
	{
		// We will do small escape for not devising by 0
		if ($limit == 0)
		{
			return;
		}
		if ($limit < -1)
		{
			$limit = -1;
		}
		// Define some vars
		$images_per_page = $limit;

		$this->gallery_auth->load_user_permissions($this->user->data['user_id']);

		switch ($this->db->get_sql_layer())
		{
			case 'postgres':
			case 'sqlite3':
				$sql_order = 'RANDOM()';
			break;

			case 'mssql':
			case 'mssql_odbc':
				$sql_order = 'NEWID()';
			break;

			default:
				$sql_order = 'RAND()';
			break;
		}
		$sql_limit = $images_per_page;
		$sql = 'SELECT image_id
			FROM ' . $this->images_table . '
			WHERE image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN;
		if ($user > 0)
		{
			$sql .= ' and image_user_id = ' . (int) $user;
		}
		$exclude_albums = array();
		if (!$this->gallery_config->get('rrc_gindex_pegas'))
		{
			$sql_no_user = 'SELECT album_id FROM ' . $this->albums_table . ' WHERE album_user_id > 0';
			$result = $this->db->sql_query($sql_no_user);
			while ($row = $this->db->sql_fetchrow($result))
			{
				$exclude_albums[] = (int) $row['album_id'];
			}
			$this->db->sql_freeresult($result);
		}
		$exclude_albums = array_merge($exclude_albums, $this->gallery_auth->get_exclude_zebra());
		$sql .= ' AND ((' . $this->db->sql_in_set('image_album_id', array_diff($this->gallery_auth->acl_album_ids('i_view'), $exclude_albums), false, true) . ' AND image_status <> ' . (int) \phpbbgallery\core\block::STATUS_UNAPPROVED . ')

It seems like $this->gallery_auth->acl_album_ids('i_view') can also be of type true; however, parameter $array of array_diff() does only seem to accept array, maybe add an additional type check?

					OR (' . $this->db->sql_in_set('image_album_id', array_diff($this->gallery_auth->acl_album_ids('a_list'), $exclude_albums), false, true) . ' AND image_status <> ' . (int) \phpbbgallery\core\block::STATUS_UNAPPROVED . ')
					OR ' . $this->db->sql_in_set('image_album_id', array_diff($this->gallery_auth->acl_album_ids('m_status'), $exclude_albums), false, true) . ')
			ORDER BY ' . $sql_order;

		if (!$sql_limit)
		{
			$result = $this->db->sql_query($sql);
		}
		else
		{
			$result = $this->db->sql_query_limit($sql, $sql_limit);
		}
		$id_ary = array();
		while ($row = $this->db->sql_fetchrow($result))
		{
			$id_ary[] = $row['image_id'];
		}
		$this->db->sql_freeresult($result);

		$total_match_count = sizeof($id_ary);

		$l_search_matches = $this->language->lang('FOUND_SEARCH_MATCHES', $total_match_count);

The assignment to $l_search_matches is dead and can be removed.

		$this->template->assign_block_vars('imageblock', array(
			'BLOCK_NAME'	=> $block_name ? $block_name : $this->language->lang('RANDOM_IMAGES'),
			'U_BLOCK'	=> $u_block ? $u_block : $this->helper->route('phpbbgallery_core_search_random'),
		));

		// For some searches we need to print out the "no results" page directly to allow re-sorting/refining the search options.
		if (!sizeof($id_ary))
		{
			$this->template->assign_block_vars('imageblock', array(
				'ERROR'	=> $this->language->lang('NO_SEARCH_RESULTS_RANDOM'),
			));
			return;
		}

		$id_ary = array_map('intval', $id_ary);

		$sql_where = $this->db->sql_in_set('i.image_id', $id_ary);

		$sql_array = array(
			'SELECT'		=> 'i.*, a.album_name, a.album_status, a.album_user_id, album_id',
			'FROM'			=> array($this->images_table => 'i'),

			'LEFT_JOIN'		=> array(
				array(
					'FROM'		=> array($this->albums_table => 'a'),
					'ON'		=> 'a.album_id = i.image_album_id',
				),
			),

			'WHERE'			=> 'i.image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN . ' AND ' . $sql_where,
			'GROUP_BY'	=> 'i.image_id, a.album_name, a.album_status, a.album_user_id, a.album_id',
			'ORDER_BY'		=> $sql_order,
		);
		$sql = $this->db->sql_build_query('SELECT', $sql_array);
		$result = $this->db->sql_query($sql);

		$show_options = $this->gallery_config->get($fields);
		$thumbnail_link = $this->gallery_config->get('link_thumbnail');
		$imagename_link = $this->gallery_config->get('link_image_name');

		while ($row = $this->db->sql_fetchrow($result))
		{
			$this->image->assign_block('imageblock.image', $row, $show_options, $thumbnail_link, $imagename_link);
		}

		$this->db->sql_freeresult($result);
	}