@@ -221,8 +221,7 @@ discard block |
||
221 | 221 | { |
222 | 222 | $padding .= ' '; |
223 | 223 | $padding_store[$row['parent_id']] = $padding; |
224 | - } |
|
225 | - else if ($row['left_id'] > $right + 1) |
|
224 | + } else if ($row['left_id'] > $right + 1) |
|
226 | 225 | { |
227 | 226 | $padding = (isset($padding_store[$row['parent_id']])) ? $padding_store[$row['parent_id']] : ''; |
228 | 227 | } |
@@ -248,15 +247,13 @@ discard block |
||
248 | 247 | if (($select_id == $this->gallery_auth->get_setting_permissions()) && !$row['album_user_id']) |
249 | 248 | { |
250 | 249 | $list = true; |
251 | - } |
|
252 | - else if (!$row['album_user_id']) |
|
250 | + } else if (!$row['album_user_id']) |
|
253 | 251 | { |
254 | 252 | if ($this->gallery_auth->acl_check('a_list', $row['album_id'], $row['album_user_id']) || defined('IN_ADMIN')) |
255 | 253 | { |
256 | 254 | $list = true; |
257 | 255 | } |
258 | - } |
|
259 | - else if (!$ignore_personals) |
|
256 | + } else if (!$ignore_personals) |
|
260 | 257 | { |
261 | 258 | if ($row['album_user_id'] == $this->user->data['user_id']) |
262 | 259 | { |
@@ -267,16 +264,14 @@ discard block |
||
267 | 264 | if ($requested_permission) |
268 | 265 | { |
269 | 266 | $requested_own = !$this->gallery_auth->acl_check($requested_permission, $this->gallery_auth->get_own_album()); |
270 | - } |
|
271 | - else |
|
267 | + } else |
|
272 | 268 | { |
273 | 269 | $requested_own = false; // We need the negated version of true here |
274 | 270 | } |
275 | 271 | } |
276 | 272 | $list = (!$list) ? $access_own : $list; |
277 | 273 | $disabled = (!$disabled) ? $requested_own : $disabled; |
278 | - } |
|
279 | - else if ($row['album_user_id']) |
|
274 | + } else if ($row['album_user_id']) |
|
280 | 275 | { |
281 | 276 | if (!$c_access_personal) |
282 | 277 | { |
@@ -285,8 +280,7 @@ discard block |
||
285 | 280 | if ($requested_permission) |
286 | 281 | { |
287 | 282 | $requested_personal = !$this->gallery_auth->acl_check($requested_permission, $this->gallery_auth->get_personal_album()); |
288 | - } |
|
289 | - else |
|
283 | + } else |
|
290 | 284 | { |
291 | 285 | $requested_personal = false; // We need the negated version of true here |
292 | 286 | } |
@@ -298,8 +292,7 @@ discard block |
||
298 | 292 | if (($album_user_id != (int) \phpbbgallery\core\block::PUBLIC_ALBUM) && ($album_user_id != $row['album_user_id'])) |
299 | 293 | { |
300 | 294 | $list = false; |
301 | - } |
|
302 | - else if (($album_user_id != (int) \phpbbgallery\core\block::PUBLIC_ALBUM) && ($row['parent_id'] == 0)) |
|
295 | + } else if (($album_user_id != (int) \phpbbgallery\core\block::PUBLIC_ALBUM) && ($row['parent_id'] == 0)) |
|
303 | 296 | { |
304 | 297 | $disabled = true; |
305 | 298 | } |
@@ -317,8 +310,7 @@ discard block |
||
317 | 310 | $gallery_albumbox = "<select name='$select_name' id='$select_name'>"; |
318 | 311 | $gallery_albumbox .= $album_list; |
319 | 312 | $gallery_albumbox .= '</select>'; |
320 | - } |
|
321 | - else |
|
313 | + } else |
|
322 | 314 | { |
323 | 315 | $gallery_albumbox = $album_list; |
324 | 316 | } |
@@ -387,8 +379,7 @@ discard block |
||
387 | 379 | 'album_last_user_colour' => $row['image_user_colour'], |
388 | 380 | 'album_last_user_id' => $row['image_user_id'], |
389 | 381 | ); |
390 | - } |
|
391 | - else |
|
382 | + } else |
|
392 | 383 | { |
393 | 384 | // No approved image, so we clear the columns |
394 | 385 | $sql_ary = array( |
@@ -250,8 +250,7 @@ discard block |
||
250 | 250 | } |
251 | 251 | |
252 | 252 | $this->loader->load($this->data['image_album_id']); |
253 | - } |
|
254 | - catch (\Exception $e) |
|
253 | + } catch (\Exception $e) |
|
255 | 254 | { |
256 | 255 | throw new \phpbb\exception\http_exception(404, 'INVALID_IMAGE'); |
257 | 256 | } |
@@ -264,8 +263,7 @@ discard block |
||
264 | 263 | if ($this->gallery_auth->acl_check('m_status', $album_id, $album_data['album_user_id'])) |
265 | 264 | { |
266 | 265 | $image_status_check = ''; |
267 | - } |
|
268 | - else |
|
266 | + } else |
|
269 | 267 | { |
270 | 268 | $user_id = (int) $this->user->data['user_id']; |
271 | 269 | $image_status_check = ' AND (image_status = ' . (int) \phpbbgallery\core\block::STATUS_APPROVED . ' OR image_user_id = ' . $user_id . ')'; |
@@ -322,8 +320,7 @@ discard block |
||
322 | 320 | if (in_array($sort_key, array('r', 'ra'))) |
323 | 321 | { |
324 | 322 | $sql_help_sort = ', image_id ' . (($sort_dir == 'd') ? 'ASC' : 'DESC'); |
325 | - } |
|
326 | - else |
|
323 | + } else |
|
327 | 324 | { |
328 | 325 | $sql_help_sort = ', image_id ' . (($sort_dir == 'd') ? 'DESC' : 'ASC'); |
329 | 326 | } |
@@ -551,8 +548,7 @@ discard block |
||
551 | 548 | if (isset($album_data['contest_start'])) |
552 | 549 | { |
553 | 550 | $s_hide_comment_input = (time() < ($album_data['contest_start'] + $album_data['contest_end'])) ? true : false; |
554 | - } |
|
555 | - else |
|
551 | + } else |
|
556 | 552 | { |
557 | 553 | $s_hide_comment_input = false; |
558 | 554 | } |
@@ -598,8 +594,7 @@ discard block |
||
598 | 594 | //$this->template->assign_var('S_COMMENT_ACTION', append_sid($this->url->path('full') . 'comment/' . $image_id . '/add/0')); |
599 | 595 | $this->template->assign_var('S_COMMENT_ACTION', $this->helper->route('phpbbgallery_core_comment_add', array('image_id' => $image_id, 'comment_id' => 0))); |
600 | 596 | } |
601 | - } |
|
602 | - else if ($this->gallery_config->get('comment_user_control') && !$image_data['image_allow_comments']) |
|
597 | + } else if ($this->gallery_config->get('comment_user_control') && !$image_data['image_allow_comments']) |
|
603 | 598 | { |
604 | 599 | $this->template->assign_var('S_COMMENTS_DISABLED', true); |
605 | 600 | } |
@@ -790,8 +785,7 @@ discard block |
||
790 | 785 | 'NAME' => $field_data['PROFILE_FIELD_NAME'], |
791 | 786 | 'U_CONTACT' => $field_data['PROFILE_FIELD_CONTACT'], |
792 | 787 | )); |
793 | - } |
|
794 | - else |
|
788 | + } else |
|
795 | 789 | { |
796 | 790 | $this->template->assign_block_vars('commentrow.custom_fields', $field_data); |
797 | 791 | } |
@@ -917,8 +911,7 @@ discard block |
||
917 | 911 | { |
918 | 912 | $change_image_count = true; |
919 | 913 | } |
920 | - } |
|
921 | - else if ($this->request->variable('change_author', '', true)) |
|
914 | + } else if ($this->request->variable('change_author', '', true)) |
|
922 | 915 | { |
923 | 916 | $errors[] = $this->language->lang('INVALID_USERNAME'); |
924 | 917 | } |
@@ -939,8 +932,7 @@ discard block |
||
939 | 932 | { |
940 | 933 | $personal_album_id = $this->album->generate_personal_album($image_data['image_username'], $image_data['image_user_id'], $image_data['image_user_colour'], $image_user); |
941 | 934 | } |
942 | - } |
|
943 | - else |
|
935 | + } else |
|
944 | 936 | { |
945 | 937 | $personal_album_id = $this->gallery_user->get_data('personal_album_id'); |
946 | 938 | if (!$personal_album_id && $this->gallery_auth->acl_check('i_upload', $this->gallery_auth->get_own_album())) |
@@ -1108,8 +1100,7 @@ discard block |
||
1108 | 1100 | $this->notification_helper->read('approval', $album_id); |
1109 | 1101 | $this->url->meta_refresh(3, $album_backlink); |
1110 | 1102 | trigger_error($message); |
1111 | - } |
|
1112 | - else |
|
1103 | + } else |
|
1113 | 1104 | { |
1114 | 1105 | if (isset($_POST['cancel'])) |
1115 | 1106 | { |
@@ -1117,8 +1108,7 @@ discard block |
||
1117 | 1108 | $message .= '<br />' . sprintf($this->language->lang('CLICK_RETURN_IMAGE'), '<a href="' . $image_backlink . '">', '</a>'); |
1118 | 1109 | $this->url->meta_refresh(3, $image_backlink); |
1119 | 1110 | trigger_error($message); |
1120 | - } |
|
1121 | - else |
|
1111 | + } else |
|
1122 | 1112 | { |
1123 | 1113 | confirm_box(false, 'DELETE_IMAGE2', $s_hidden_fields); |
1124 | 1114 | } |
@@ -1223,8 +1213,7 @@ discard block |
||
1223 | 1213 | { |
1224 | 1214 | // @todo Add "redirect after login" url |
1225 | 1215 | login_box(); |
1226 | - } |
|
1227 | - else |
|
1216 | + } else |
|
1228 | 1217 | { |
1229 | 1218 | //return $this->error('NOT_AUTHORISED', 403); |
1230 | 1219 | redirect('gallery/album/' . $album_id); |
@@ -28,13 +28,13 @@ |
||
28 | 28 | $this->tpl_name = 'gallery_logs'; |
29 | 29 | add_form_key('acp_logs'); |
30 | 30 | |
31 | - $page = $request->variable('page', 0); |
|
32 | - $filter_log = $request->variable('lf', 'all'); |
|
33 | - $sort_days = $request->variable('st', 0); |
|
31 | + $page = $request->variable('page', 0); |
|
32 | + $filter_log = $request->variable('lf', 'all'); |
|
33 | + $sort_days = $request->variable('st', 0); |
|
34 | 34 | $sort_key = $request->variable('sk', 't'); |
35 | 35 | $sort_dir = $request->variable('sd', 'd'); |
36 | - $deletemark = $request->is_set_post('delmarked'); |
|
37 | - $marked = $request->variable('mark', []); |
|
36 | + $deletemark = $request->is_set_post('delmarked'); |
|
37 | + $marked = $request->variable('mark', []); |
|
38 | 38 | |
39 | 39 | $log = $phpbb_container->get('phpbbgallery.core.log'); |
40 | 40 |
@@ -67,8 +67,7 @@ |
||
67 | 67 | if (confirm_box(true)) |
68 | 68 | { |
69 | 69 | $log->delete_logs($marked); |
70 | - } |
|
71 | - else |
|
70 | + } else |
|
72 | 71 | { |
73 | 72 | confirm_box(false, $this->language->lang('CONFIRM_OPERATION'), build_hidden_fields([ |
74 | 73 | 'page' => $page, |