Passed
Pull Request — master (#316)
by
unknown
07:46 queued 05:05
created
core/log.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
 				),
274 274
 				'params' => array(
275 275
 				),
276
-			), 'pagination', 'page', $count, $limit, ($page-1) * $limit);
276
+			), 'pagination', 'page', $count, $limit, ($page - 1) * $limit);
277 277
 		}
278 278
 		else if ($album == -1)
279 279
 		{
@@ -293,9 +293,9 @@  discard block
 block discarded – undo
293 293
 			{
294 294
 				$url_array['sd'] = $additional['sort_dir'];
295 295
 			}
296
-			$url = http_build_query($url_array,'','&');
296
+			$url = http_build_query($url_array, '', '&');
297 297
 
298
-			$this->pagination->generate_template_pagination(append_sid('index.php?' . $url), 'pagination', 'page', $count, $limit, ($page-1) * $limit);
298
+			$this->pagination->generate_template_pagination(append_sid('index.php?' . $url), 'pagination', 'page', $count, $limit, ($page - 1) * $limit);
299 299
 		}
300 300
 		else
301 301
 		{
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
307 307
 				'params' => array(
308 308
 					'album_id'	=> $album,
309 309
 				),
310
-			), 'pagination', 'page', $count, $limit, ($page-1) * $limit);
310
+			), 'pagination', 'page', $count, $limit, ($page - 1) * $limit);
311 311
 		}
312 312
 	}
313 313
 }
Please login to merge, or discard this patch.
core/cache.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
 		if (($albums = $this->phpbb_cache->get('_albums')) === false)
56 56
 		{
57 57
 			$sql = 'SELECT a.album_id, a.parent_id, a.album_name, a.album_type, a.left_id, a.right_id, a.album_user_id, a.display_in_rrc, a.album_auth_access
58
-				FROM ' . $this->table_albums. ' a
58
+				FROM ' . $this->table_albums . ' a
59 59
 				LEFT JOIN ' . USERS_TABLE . ' u
60 60
 					ON (u.user_id = a.album_user_id)
61 61
 				ORDER BY u.username_clean, a.album_user_id, a.left_id ASC';
Please login to merge, or discard this patch.
core/ucp/main_module.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 		$phpbb_gallery_url = $phpbb_container->get('phpbbgallery.core.url');
28 28
 		$phpbb_gallery_url->_include('functions_display', 'phpbb');
29 29
 
30
-		$phpbb_ext_gallery_core_album =$phpbb_container->get('phpbbgallery.core.album');
30
+		$phpbb_ext_gallery_core_album = $phpbb_container->get('phpbbgallery.core.album');
31 31
 
32 32
 		$phpbb_ext_gallery_core_auth = $phpbb_container->get('phpbbgallery.core.auth');
33 33
 
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 
152 152
 	function initialise_album()
153 153
 	{
154
-		global $cache, $db,  $user, $phpbb_ext_gallery_core_auth, $phpbb_ext_gallery_core_album, $phpbb_ext_gallery_config, $albums_table, $phpbb_ext_gallery_user;
154
+		global $cache, $db, $user, $phpbb_ext_gallery_core_auth, $phpbb_ext_gallery_core_album, $phpbb_ext_gallery_config, $albums_table, $phpbb_ext_gallery_user;
155 155
 		global $request, $users_table, $phpbb_container;
156 156
 
157 157
 		// we will have to initialse $phpbb_ext_gallery_user
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
 
446 446
 		$this->language = $phpbb_container->get('language');
447 447
 
448
-		$phpbb_gallery_url->_include(array('bbcode','message_parser'), 'phpbb');
448
+		$phpbb_gallery_url->_include(array('bbcode', 'message_parser'), 'phpbb');
449 449
 
450 450
 		$album_id = $request->variable('album_id', 0);
451 451
 		$phpbb_ext_gallery_core_album->check_user($album_id);
@@ -828,7 +828,7 @@  discard block
 block discarded – undo
828 828
 				$sql = 'UPDATE ' . $albums_table . "
829 829
 					SET right_id = right_id - $delete_id
830 830
 					WHERE right_id > $right_id
831
-						AND album_user_id = ". (int) $user->data['user_id'];
831
+						AND album_user_id = " . (int) $user->data['user_id'];
832 832
 				$db->sql_query($sql);
833 833
 			}
834 834
 
@@ -1012,9 +1012,9 @@  discard block
 block discarded – undo
1012 1012
 		$db->sql_freeresult($result);
1013 1013
 
1014 1014
 		// Subscribed images
1015
-		$start				= $request->variable('start', 0);
1016
-		$images_per_page	= $phpbb_ext_gallery_config->get('items_per_page');
1017
-		$total_images		= 0;
1015
+		$start = $request->variable('start', 0);
1016
+		$images_per_page = $phpbb_ext_gallery_config->get('items_per_page');
1017
+		$total_images = 0;
1018 1018
 
1019 1019
 		$sql = 'SELECT COUNT(image_id) as images
1020 1020
 			FROM ' . $watch_table . '
Please login to merge, or discard this patch.
core/url.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -129,12 +129,12 @@
 block discarded – undo
129 129
 
130 130
 		if (isset($args[1]))
131 131
 		{
132
-			$args[1] .= '';//@todo: phpbb_gallery::$display_popup;
132
+			$args[1] .= ''; //@todo: phpbb_gallery::$display_popup;
133 133
 		}
134 134
 
135 135
 		$params = $args + array(
136 136
 			0	=> '',
137
-			1	=> '',//@todo: phpbb_gallery::$display_popup,
137
+			1	=> '', //@todo: phpbb_gallery::$display_popup,
138 138
 			2	=> true,
139 139
 			3	=> false,
140 140
 		);
Please login to merge, or discard this patch.
acpimport/acp/main_module.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
 	function import()
34 34
 	{
35
-		global $db, $template, $user, $phpbb_dispatcher, $phpbb_container, $gallery_url, $request, $table_prefix ,$gallery_config, $gallery_album, $request;
35
+		global $db, $template, $user, $phpbb_dispatcher, $phpbb_container, $gallery_url, $request, $table_prefix, $gallery_config, $gallery_album, $request;
36 36
 
37 37
 		$import_schema = $request->variable('import_schema', '');
38 38
 		$images = $request->variable('images', array(''), true);
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 			$album_id = $request->variable('album_id', 0);
303 303
 			if (isset($_POST['users_pega']))
304 304
 			{
305
-				$image_user =  $phpbb_container->get('phpbbgallery.core.user');
305
+				$image_user = $phpbb_container->get('phpbbgallery.core.user');
306 306
 				$image_user->set_user_id($user_row['user_id']);
307 307
 				if ($user->data['user_id'] != $user_row['user_id'])
308 308
 				{
Please login to merge, or discard this patch.
exif/language/bg/exif.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 	'EXIF_CAM_MODEL'			=> 'Camera-model',
31 31
 	'EXIF_DATE'					=> 'Image taken on',
32 32
 	'EXIF_EXPOSURE'				=> 'Shutter speed',
33
-	'EXIF_EXPOSURE_EXP'			=> '%s Sec',// 'EXIF_EXPOSURE' unit
33
+	'EXIF_EXPOSURE_EXP'			=> '%s Sec', // 'EXIF_EXPOSURE' unit
34 34
 	'EXIF_EXPOSURE_BIAS'		=> 'Exposure bias',
35
-	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV',// 'EXIF_EXPOSURE_BIAS' unit
35
+	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV', // 'EXIF_EXPOSURE_BIAS' unit
36 36
 	'EXIF_EXPOSURE_PROG'		=> 'Exposure program',
37 37
 	'EXIF_EXPOSURE_PROG_0'		=> 'Not defined',
38 38
 	'EXIF_EXPOSURE_PROG_1'		=> 'Manual',
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	'EXIF_FLASH_CASE_93'		=> 'Flash fired, auto mode, return light not detected, red-eye reduction mode',
73 73
 	'EXIF_FLASH_CASE_95'		=> 'Flash fired, auto mode, return light detected, red-eye reduction mode',
74 74
 	'EXIF_FOCAL'				=> 'Focus length',
75
-	'EXIF_FOCAL_EXP'			=> '%s mm',// 'EXIF_FOCAL' unit
75
+	'EXIF_FOCAL_EXP'			=> '%s mm', // 'EXIF_FOCAL' unit
76 76
 	'EXIF_ISO'					=> 'ISO speed rating',
77 77
 	'EXIF_METERING_MODE'		=> 'Metering mode',
78 78
 	'EXIF_METERING_MODE_0'		=> 'Unknown',
Please login to merge, or discard this patch.
core/image/image.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
 				* @since 1.2.0
384 384
 				*/
385 385
 				$vars = array('mode', 'tpl');
386
-				extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.image.generate_link', compact($vars)));//@todo: Correctly identify the event
386
+				extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.image.generate_link', compact($vars))); //@todo: Correctly identify the event
387 387
 			break;
388 388
 		}
389 389
 
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 
407 407
 		$num_images = $num_comments = 0;
408 408
 		$sql = 'SELECT SUM(image_comments) as comments
409
-			FROM ' . $this->table_images .'
409
+			FROM ' . $this->table_images . '
410 410
 			WHERE image_status ' . (($readd) ? '=' : '<>') . ' ' . \phpbbgallery\core\block::STATUS_UNAPPROVED . '
411 411
 				AND ' . $this->db->sql_in_set('image_id', $image_id_ary) . '
412 412
 			GROUP BY image_user_id';
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 		$this->db->sql_freeresult($result);
416 416
 
417 417
 		$sql = 'SELECT COUNT(image_id) images, image_user_id
418
-			FROM ' . $this->table_images .' 
418
+			FROM ' . $this->table_images . ' 
419 419
 			WHERE image_status ' . (($readd) ? '=' : '<>') . ' ' . \phpbbgallery\core\block::STATUS_UNAPPROVED . '
420 420
 				AND ' . $this->db->sql_in_set('image_id', $image_id_ary) . '
421 421
 			GROUP BY image_user_id';
@@ -455,7 +455,7 @@  discard block
 block discarded – undo
455 455
 			return;
456 456
 		}
457 457
 
458
-		$sql = 'SELECT * FROM ' . $this->table_images .' WHERE image_id = ' . (int) $image_id;
458
+		$sql = 'SELECT * FROM ' . $this->table_images . ' WHERE image_id = ' . (int) $image_id;
459 459
 		$result = $this->db->sql_query($sql);
460 460
 		$row = $this->db->sql_fetchrow($result);
461 461
 		$this->db->sql_freeresult($result);
@@ -515,14 +515,14 @@  discard block
 block discarded – undo
515 515
 	{
516 516
 		self::handle_counter($image_id_ary, false);
517 517
 
518
-		$sql = 'UPDATE ' . $this->table_images .' 
518
+		$sql = 'UPDATE ' . $this->table_images . ' 
519 519
 			SET image_status = ' . \phpbbgallery\core\block::STATUS_UNAPPROVED . '
520 520
 			WHERE image_status <> ' . \phpbbgallery\core\block::STATUS_ORPHAN . '
521 521
 				AND ' . $this->db->sql_in_set('image_id', $image_id_ary);
522 522
 		$this->db->sql_query($sql);
523 523
 
524 524
 		$sql = 'SELECT image_id, image_name
525
-			FROM ' . $this->table_images .' 
525
+			FROM ' . $this->table_images . ' 
526 526
 			WHERE image_status <> ' . \phpbbgallery\core\block::STATUS_ORPHAN . '
527 527
 				AND ' . $this->db->sql_in_set('image_id', $image_id_ary);
528 528
 		$result = $this->db->sql_query($sql);
@@ -704,14 +704,14 @@  discard block
 block discarded – undo
704 704
 			'U_USER_IP'		=> $show_ip && $this->gallery_auth->acl_check('m_status', $image_data['image_album_id'], $image_data['album_user_id']) ? $image_data['image_user_ip'] : false,
705 705
 
706 706
 			'S_IMAGE_REPORTED'		=> $image_data['image_reported'],
707
-			'U_IMAGE_REPORTED'		=> '',//($image_data['image_reported']) ? $phpbb_ext_gallery->url->append_sid('mcp', "mode=report_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_reported']) : '',
707
+			'U_IMAGE_REPORTED'		=> '', //($image_data['image_reported']) ? $phpbb_ext_gallery->url->append_sid('mcp', "mode=report_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_reported']) : '',
708 708
 			'S_STATUS_APPROVED'		=> ($image_data['image_status'] == \phpbbgallery\core\block::STATUS_APPROVED),
709 709
 			'S_STATUS_UNAPPROVED'	=> ($this->gallery_auth->acl_check('m_status', $image_data['image_album_id'], $image_data['album_user_id']) && $image_data['image_status'] == \phpbbgallery\core\block::STATUS_UNAPPROVED) ? true : false,
710 710
 			'S_STATUS_UNAPPROVED_ACTION'	=> ($this->gallery_auth->acl_check('m_status', $image_data['image_album_id'], $image_data['album_user_id']) && $image_data['image_status'] == \phpbbgallery\core\block::STATUS_UNAPPROVED) ? $this->helper->route('phpbbgallery_core_moderate_image_approve', array('image_id' => (int) $image_data['image_id'])) : '',
711 711
 			'S_STATUS_LOCKED'		=> ($image_data['image_status'] == \phpbbgallery\core\block::STATUS_LOCKED),
712 712
 
713 713
 			'U_REPORT'	=> ($this->gallery_auth->acl_check('m_report', $image_data['image_album_id'], $image_data['album_user_id']) && $image_data['image_reported']) ? '123'/*$this->url->append_sid('mcp', "mode=report_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_reported'])*/ : '',
714
-			'U_STATUS'	=> '',//($this->auth->acl_check('m_status', $image_data['image_album_id'], $album_user_id)) ? $phpbb_ext_gallery->url->append_sid('mcp', "mode=queue_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_id']) : '',
714
+			'U_STATUS'	=> '', //($this->auth->acl_check('m_status', $image_data['image_album_id'], $album_user_id)) ? $phpbb_ext_gallery->url->append_sid('mcp', "mode=queue_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_id']) : '',
715 715
 			'L_STATUS'	=> ($image_data['image_status'] == \phpbbgallery\core\block::STATUS_UNAPPROVED) ? $this->language->lang('APPROVE_IMAGE') : (($image_data['image_status'] == \phpbbgallery\core\block::STATUS_APPROVED) ? $this->language->lang('CHANGE_IMAGE_STATUS') : $this->language->lang('UNLOCK_IMAGE')),
716 716
 		));
717 717
 	}
Please login to merge, or discard this patch.
core/language/de/gallery_acp.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -159,7 +159,7 @@
 block discarded – undo
159 159
 	'GALLERY_RESYNC_ALBUMS_TO_CPF_EXPAIN'  => 'Diese Aktion wird alle persönlichen Alben auf dem Toplevel als kontaktbasierte selbsterstellt Profilfelder resynchronisieren . <br> WARNUNG! Dies kann beim Vorhandensein sehr vieler solcher Alben sehr lange dauern!',
160 160
 	'GALLERY_RESYNC_ALBUMS_TO_CPF_CONFIRM' => 'Bist Du sicher, dass Du den Resync aller persönlichen Alben auf dem Toplevel als kontaktbasierte selbsterstellte Profilfelder durchführen willst?',
161 161
 	'GALLERY_STATS'                        => 'Galerie Statistik',
162
-	'GALLERY_VERSION'                      => 'Version der phpBB Gallery',//ja mit ll und y, da es sich um den MOD-Namen handelt
162
+	'GALLERY_VERSION'                      => 'Version der phpBB Gallery', //ja mit ll und y, da es sich um den MOD-Namen handelt
163 163
 	'GD_VERSION'                           => 'GD Version optimieren',
164 164
 	'GENERAL_ALBUM_SETTINGS'               => 'Allgemeine Albumseinstellungen',
165 165
 	'GIF_ALLOWED'                          => 'Es ist erlaubt GIF-Dateien hochzuladen',
Please login to merge, or discard this patch.
core/controller/moderate.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
 			}
261 261
 			else
262 262
 			{
263
-				$s_hidden_fields = '<input type="hidden" name="action['.$action.']" value="' . $action . '" />';
263
+				$s_hidden_fields = '<input type="hidden" name="action[' . $action . ']" value="' . $action . '" />';
264 264
 				$s_hidden_fields .= '<input type="hidden" name="back_link" value="' . $back_link . '" />';
265 265
 				foreach ($approve_ary as $id => $var)
266 266
 				{
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 			}
362 362
 			else
363 363
 			{
364
-				$s_hidden_fields = '<input type="hidden" name="action['.$action.']" value="' . $action . '" />';
364
+				$s_hidden_fields = '<input type="hidden" name="action[' . $action . ']" value="' . $action . '" />';
365 365
 				$s_hidden_fields .= '<input type="hidden" name="back_link" value="' . $back_link . '" />';
366 366
 				foreach ($report_ary as $var)
367 367
 				{
@@ -583,7 +583,7 @@  discard block
 block discarded – undo
583 583
 			case 'reports_close':
584 584
 				if (confirm_box(true))
585 585
 				{
586
-					$back_link =  $this->helper->route('phpbbgallery_core_moderate_image', array('image_id' => $image_id));
586
+					$back_link = $this->helper->route('phpbbgallery_core_moderate_image', array('image_id' => $image_id));
587 587
 					$this->report->close_reports_by_image($image_id);
588 588
 					$message = $this->language->lang('WAITING_REPORTED_DONE', 1);
589 589
 					$this->url->meta_refresh(3, $back_link);
@@ -679,7 +679,7 @@  discard block
 block discarded – undo
679 679
 				'REPORT_TIME'	=> $this->user->format_date($var['report_time']),
680 680
 				'REPORT_NOTE'	=> $var['report_note'],
681 681
 				'STATUS'		=> $var['report_status'],
682
-				'MANAGER'		=> $var['report_manager'] != 0 ?  $this->user_loader->get_username($var['report_manager'], 'full') : false,
682
+				'MANAGER'		=> $var['report_manager'] != 0 ? $this->user_loader->get_username($var['report_manager'], 'full') : false,
683 683
 			));
684 684
 		}
685 685
 		return $this->helper->render('gallery/moderate_image_overview.html', $this->language->lang('GALLERY'));
@@ -804,7 +804,7 @@  discard block
 block discarded – undo
804 804
 		$image_data = $this->image->get_image_data($image_id);
805 805
 		$album_id = $image_data['image_album_id'];
806 806
 		//$user_id = $image_data['image_user_id'];
807
-		$album_data =  $this->album->get_info($album_id);
807
+		$album_data = $this->album->get_info($album_id);
808 808
 		$album_backlink = $this->helper->route('phpbbgallery_core_album', array('album_id' => $album_id));
809 809
 		$image_backlink = $this->helper->route('phpbbgallery_core_image', array('image_id' => $image_id));
810 810
 		$album_loginlink = append_sid($this->root_path . 'ucp.' . $this->php_ext . '?mode=login');
@@ -852,7 +852,7 @@  discard block
 block discarded – undo
852 852
 		$image_data = $this->image->get_image_data($image_id);
853 853
 		$album_id = $image_data['image_album_id'];
854 854
 		//$user_id = $image_data['image_user_id'];
855
-		$album_data =  $this->album->get_info($album_id);
855
+		$album_data = $this->album->get_info($album_id);
856 856
 		$album_backlink = $this->helper->route('phpbbgallery_core_album', array('album_id' => $album_id));
857 857
 		$image_backlink = $this->helper->route('phpbbgallery_core_image', array('image_id' => $image_id));
858 858
 		$album_loginlink = append_sid($this->root_path . 'ucp.' . $this->php_ext . '?mode=login');
@@ -868,7 +868,7 @@  discard block
 block discarded – undo
868 868
 			$image_id_ary = array($image_id);
869 869
 			$this->image->lock_images($image_id_ary, $album_data['album_id']);
870 870
 			// To DO - add notification
871
-			$message = sprintf($this->language->lang('WAITING_LOCKED_IMAGE',1));
871
+			$message = sprintf($this->language->lang('WAITING_LOCKED_IMAGE', 1));
872 872
 			meta_refresh($meta_refresh_time, $image_backlink);
873 873
 			trigger_error($message);
874 874
 		}
Please login to merge, or discard this patch.