Passed
Push — master ( 9a5988...6db2c7 )
by Stanislav
03:11 queued 16s
created
core/ext.php 2 patches
Indentation   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -14,11 +14,11 @@  discard block
 block discarded – undo
14 14
 		'phpbbgallery/acpcleanup',
15 15
 	);
16 16
 	/**
17
-	* Single enable step that installs any included migrations
18
-	*
19
-	* @param mixed $old_state State returned by previous call of this method
20
-	* @return mixed Returns false after last step, otherwise temporary state
21
-	*/
17
+	 * Single enable step that installs any included migrations
18
+	 *
19
+	 * @param mixed $old_state State returned by previous call of this method
20
+	 * @return mixed Returns false after last step, otherwise temporary state
21
+	 */
22 22
 	function enable_step($old_state)
23 23
 	{
24 24
 		switch ($old_state)
@@ -52,11 +52,11 @@  discard block
 block discarded – undo
52 52
 	}
53 53
 
54 54
 	/**
55
-	* Single disable step that does nothing
56
-	*
57
-	* @param mixed $old_state State returned by previous call of this method
58
-	* @return mixed Returns false after last step, otherwise temporary state
59
-	*/
55
+	 * Single disable step that does nothing
56
+	 *
57
+	 * @param mixed $old_state State returned by previous call of this method
58
+	 * @return mixed Returns false after last step, otherwise temporary state
59
+	 */
60 60
 	function disable_step($old_state)
61 61
 	{
62 62
 		switch ($old_state)
@@ -87,21 +87,21 @@  discard block
 block discarded – undo
87 87
 	}
88 88
 
89 89
 	/**
90
-	* Single purge step that reverts any included and installed migrations
91
-	*
92
-	* @param mixed $old_state State returned by previous call of this method
93
-	* @return mixed Returns false after last step, otherwise temporary state
94
-	*/
90
+	 * Single purge step that reverts any included and installed migrations
91
+	 *
92
+	 * @param mixed $old_state State returned by previous call of this method
93
+	 * @return mixed Returns false after last step, otherwise temporary state
94
+	 */
95 95
 	function purge_step($old_state)
96 96
 	{
97 97
 		switch ($old_state)
98 98
 		{
99 99
 			case '': // Empty means nothing has run yet
100 100
 				/**
101
-				* @todo Remove this try/catch condition once purge_notifications is fixed
102
-				* in the core to work with disabled extensions without fatal errors.
103
-				* https://tracker.phpbb.com/browse/PHPBB3-12435
104
-				*/
101
+				 * @todo Remove this try/catch condition once purge_notifications is fixed
102
+				 * in the core to work with disabled extensions without fatal errors.
103
+				 * https://tracker.phpbb.com/browse/PHPBB3-12435
104
+				 */
105 105
 				try
106 106
 				{
107 107
 					// Purge board rules notifications
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,8 +111,7 @@
 block discarded – undo
111 111
 					$phpbb_notifications->purge_notifications('phpbbgallery.core.notification.new_image');
112 112
 					$phpbb_notifications->purge_notifications('phpbbgallery.core.notification.new_comment');
113 113
 					$phpbb_notifications->purge_notifications('phpbbgallery.core.notification.new_report');
114
-				}
115
-				catch (\phpbb\notification\exception $e)
114
+				} catch (\phpbb\notification\exception $e)
116 115
 				{
117 116
 					// continue
118 117
 				}
Please login to merge, or discard this patch.
core/config.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -147,8 +147,7 @@  discard block
 block discarded – undo
147 147
 			if (isset($this->config['phpbb_gallery_' . $option]))
148 148
 			{
149 149
 				$config_ary[$option] = $this->config['phpbb_gallery_' . $option];
150
-			}
151
-			else
150
+			} else
152 151
 			{
153 152
 				$config_ary[$option] = $default;
154 153
 			}
@@ -161,8 +160,7 @@  discard block
 block discarded – undo
161 160
 		if (isset($this->config['phpbb_gallery_' . $key]))
162 161
 		{
163 162
 			return $this->config['phpbb_gallery_' . $key];
164
-		}
165
-		else
163
+		} else
166 164
 		{
167 165
 			return $this->configs_array[$key];
168 166
 		}
Please login to merge, or discard this patch.
core/album/loader.php 1 patch
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -40,12 +40,12 @@  discard block
 block discarded – undo
40 40
 	}
41 41
 
42 42
 	/**
43
-	* Load the data of an album
44
-	*
45
-	* @param	int		$album_id
46
-	* @return	bool	True if the album was loaded
47
-	* @throws	\OutOfBoundsException	if the album does not exist
48
-	*/
43
+	 * Load the data of an album
44
+	 *
45
+	 * @param	int		$album_id
46
+	 * @return	bool	True if the album was loaded
47
+	 * @throws	\OutOfBoundsException	if the album does not exist
48
+	 */
49 49
 	public function load($album_id)
50 50
 	{
51 51
 		$sql_array = array(
@@ -107,13 +107,13 @@  discard block
 block discarded – undo
107 107
 	}
108 108
 
109 109
 	/**
110
-	* Check whether the album_user is the user who wants to do something
111
-	*
112
-	* @param	int		$album_id
113
-	* @param	mixed	$user_id	If false the current user will be compared
114
-	* @return	bool	True if the user is the owner of the album
115
-	* @throws	\DomainException	if the user is not the owner of the album
116
-	*/
110
+	 * Check whether the album_user is the user who wants to do something
111
+	 *
112
+	 * @param	int		$album_id
113
+	 * @param	mixed	$user_id	If false the current user will be compared
114
+	 * @return	bool	True if the user is the owner of the album
115
+	 * @throws	\DomainException	if the user is not the owner of the album
116
+	 */
117 117
 	public function validate_owner($album_id, $user_id = false)
118 118
 	{
119 119
 		$album_id = (int) $album_id;
Please login to merge, or discard this patch.
core/album/manage.php 3 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 			}
167 167
 			else
168 168
 			{
169
-				$contest_data['contest_start'] = gmmktime((int) $m[4], (int) $m[5], 0, (int) $m[2], (int) $m[3], (int) $m[1]) - $time->getOffset();// - $offset;
169
+				$contest_data['contest_start'] = gmmktime((int) $m[4], (int) $m[5], 0, (int) $m[2], (int) $m[3], (int) $m[1]) - $time->getOffset(); // - $offset;
170 170
 			}
171 171
 			if (!preg_match('#(\\d{4})-(\\d{1,2})-(\\d{1,2}) (\\d{1,2}):(\\d{2})#', $contest_data['contest_rating'], $m))
172 172
 			{
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 			}
176 176
 			else if (!$start_date_error)
177 177
 			{
178
-				$contest_data['contest_rating'] = gmmktime($m[4], $m[5], 0, $m[2], $m[3], $m[1]) - $contest_data['contest_start'] - $time->getOffset();//- $offset;
178
+				$contest_data['contest_rating'] = gmmktime($m[4], $m[5], 0, $m[2], $m[3], $m[1]) - $contest_data['contest_start'] - $time->getOffset(); //- $offset;
179 179
 			}
180 180
 			if (!preg_match('#(\\d{4})-(\\d{1,2})-(\\d{1,2}) (\\d{1,2}):(\\d{2})#', $contest_data['contest_end'], $m))
181 181
 			{
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 			}
185 185
 			else if (!$start_date_error)
186 186
 			{
187
-				$contest_data['contest_end'] = gmmktime($m[4], $m[5], 0, $m[2], $m[3], $m[1]) - $contest_data['contest_start'] - $time->getOffset();//- $offset;
187
+				$contest_data['contest_end'] = gmmktime($m[4], $m[5], 0, $m[2], $m[3], $m[1]) - $contest_data['contest_start'] - $time->getOffset(); //- $offset;
188 188
 			}
189 189
 			if (!$start_date_error && !$date_error)
190 190
 			{
@@ -710,7 +710,7 @@  discard block
 block discarded – undo
710 710
 					$album_data = $this->gallery_album->get_info($album_id);
711 711
 
712 712
 					$sql = 'UPDATE ' . $this->albums_table . ' 
713
-						SET parent_id = ' . (int) $subalbums_to_id .'
713
+						SET parent_id = ' . (int) $subalbums_to_id . '
714 714
 						WHERE parent_id = ' . (int) $album_id . '
715 715
 							AND album_user_id = ' . (int) $this->user_id;
716 716
 					$this->db->sql_query($sql);
@@ -738,13 +738,13 @@  discard block
 block discarded – undo
738 738
 		// Resync tree
739 739
 		$sql = 'UPDATE ' . $this->albums_table . '  
740 740
 			SET right_id = right_id - ' . (int) $diff . '
741
-			WHERE left_id < ' . (int) $album_data['right_id'] . ' AND right_id > ' . (int) $album_data['right_id']. '
741
+			WHERE left_id < ' . (int) $album_data['right_id'] . ' AND right_id > ' . (int) $album_data['right_id'] . '
742 742
 				AND album_user_id = ' . (int) $this->user_id;
743 743
 		$this->db->sql_query($sql);
744 744
 
745 745
 		$sql = 'UPDATE ' . $this->albums_table . ' 
746 746
 			SET left_id = left_id - ' . (int) $diff . ', right_id = right_id - ' . (int) $diff . '
747
-			WHERE left_id > ' . (int) $album_data['right_id']. '
747
+			WHERE left_id > ' . (int) $album_data['right_id'] . '
748 748
 				AND album_user_id = ' . (int) $this->user_id;
749 749
 		$this->db->sql_query($sql);
750 750
 
@@ -1037,7 +1037,7 @@  discard block
 block discarded – undo
1037 1037
 		// Now do the dirty job
1038 1038
 		$sql = 'UPDATE ' . $this->albums_table . ' 
1039 1039
 			SET left_id = left_id + CASE
1040
-				WHEN left_id BETWEEN ' . (int) $move_up_left . ' AND ' . (int) $move_up_right . ' THEN -' .(int) $diff_up . '
1040
+				WHEN left_id BETWEEN ' . (int) $move_up_left . ' AND ' . (int) $move_up_right . ' THEN -' . (int) $diff_up . '
1041 1041
 				ELSE ' .(int) $diff_down . '
1042 1042
 			END,
1043 1043
 			right_id = right_id + CASE
Please login to merge, or discard this patch.
Braces   +26 added lines, -52 removed lines patch added patch discarded remove patch
@@ -150,8 +150,7 @@  discard block
 block discarded – undo
150 150
 			if ($this->user->data['user_timezone'] == '')
151 151
 			{
152 152
 				$timezone = 'UTC';
153
-			}
154
-			else
153
+			} else
155 154
 			{
156 155
 				$timezone = $this->user->data['user_timezone'];
157 156
 			}
@@ -163,8 +162,7 @@  discard block
 block discarded – undo
163 162
 			{
164 163
 				$errors[] = sprintf($this->language->lang('CONTEST_START_INVALID'), $contest_data['contest_start']);
165 164
 				$start_date_error = true;
166
-			}
167
-			else
165
+			} else
168 166
 			{
169 167
 				$contest_data['contest_start'] = gmmktime((int) $m[4], (int) $m[5], 0, (int) $m[2], (int) $m[3], (int) $m[1]) - $time->getOffset();// - $offset;
170 168
 			}
@@ -172,8 +170,7 @@  discard block
 block discarded – undo
172 170
 			{
173 171
 				$errors[] = sprintf($this->language->lang('CONTEST_RATING_INVALID'), $contest_data['contest_rating']);
174 172
 				$date_error = true;
175
-			}
176
-			else if (!$start_date_error)
173
+			} else if (!$start_date_error)
177 174
 			{
178 175
 				$contest_data['contest_rating'] = gmmktime($m[4], $m[5], 0, $m[2], $m[3], $m[1]) - $contest_data['contest_start'] - $time->getOffset();//- $offset;
179 176
 			}
@@ -181,8 +178,7 @@  discard block
 block discarded – undo
181 178
 			{
182 179
 				$errors[] = sprintf($this->language->lang('CONTEST_END_INVALID'), $contest_data['contest_end']);
183 180
 				$date_error = true;
184
-			}
185
-			else if (!$start_date_error)
181
+			} else if (!$start_date_error)
186 182
 			{
187 183
 				$contest_data['contest_end'] = gmmktime($m[4], $m[5], 0, $m[2], $m[3], $m[1]) - $contest_data['contest_start'] - $time->getOffset();//- $offset;
188 184
 			}
@@ -270,8 +266,7 @@  discard block
 block discarded – undo
270 266
 
271 267
 					$album_data_sql['left_id'] = $row['right_id'];
272 268
 					$album_data_sql['right_id'] = $row['right_id'] + 1;
273
-				}
274
-				else
269
+				} else
275 270
 				{
276 271
 					$sql = 'UPDATE ' . $this->albums_table . ' 
277 272
 						SET left_id = left_id + 2, right_id = right_id + 2
@@ -288,8 +283,7 @@  discard block
 block discarded – undo
288 283
 					$album_data_sql['left_id'] = $row['left_id'] + 1;
289 284
 					$album_data_sql['right_id'] = $row['left_id'] + 2;
290 285
 				}
291
-			}
292
-			else
286
+			} else
293 287
 			{
294 288
 				if (!$add_on_top)
295 289
 				{
@@ -302,8 +296,7 @@  discard block
 block discarded – undo
302 296
 
303 297
 					$album_data_sql['left_id'] = $row['right_id'] + 1;
304 298
 					$album_data_sql['right_id'] = $row['right_id'] + 2;
305
-				}
306
-				else
299
+				} else
307 300
 				{
308 301
 					$sql = 'UPDATE ' . $this->albums_table . ' 
309 302
 						SET left_id = left_id + 2, right_id = right_id + 2
@@ -336,8 +329,7 @@  discard block
 block discarded – undo
336 329
 				$this->db->sql_query($sql);
337 330
 			}
338 331
 			$this->gallery_log->add_log('admin', 'add', $album_data['album_id'], 0, array('LOG_ALBUM_ADD', $album_data['album_name']));
339
-		}
340
-		else
332
+		} else
341 333
 		{
342 334
 			$row = $this->gallery_album->get_info($album_data_sql['album_id']);
343 335
 			$reset_marked_images = false;
@@ -348,22 +340,19 @@  discard block
 block discarded – undo
348 340
 				// Changing a contest to category? No!
349 341
 				$errors[] = $this->language->lang('ALBUM_WITH_CONTEST_NO_TYPE_CHANGE');
350 342
 				return $errors;
351
-			}
352
-			else if ($row['album_type'] != \phpbbgallery\core\block::TYPE_CONTEST && $album_data_sql['album_type'] == \phpbbgallery\core\block::TYPE_CONTEST)
343
+			} else if ($row['album_type'] != \phpbbgallery\core\block::TYPE_CONTEST && $album_data_sql['album_type'] == \phpbbgallery\core\block::TYPE_CONTEST)
353 344
 			{
354 345
 				// Changing a album to contest? No!
355 346
 				// Changing a category to contest? No!
356 347
 				$errors[] = $this->language->lang('ALBUM_NO_TYPE_CHANGE_TO_CONTEST');
357 348
 				return $errors;
358
-			}
359
-			else if ($row['album_type'] == \phpbbgallery\core\block::TYPE_CAT && $album_data_sql['album_type'] == \phpbbgallery\core\block::TYPE_UPLOAD)
349
+			} else if ($row['album_type'] == \phpbbgallery\core\block::TYPE_CAT && $album_data_sql['album_type'] == \phpbbgallery\core\block::TYPE_UPLOAD)
360 350
 			{
361 351
 				// Changing a category to a album? Yes!
362 352
 				// Reset the data (you couldn't upload directly in a cat, you must use a album)
363 353
 				$album_data_sql['album_images'] = $album_data_sql['album_images_real'] = $album_data_sql['album_last_image_id'] = $album_data_sql['album_last_user_id'] = $album_data_sql['album_last_image_time'] = $album_data_sql['album_contest'] = 0;
364 354
 				$album_data_sql['album_last_username'] = $album_data_sql['album_last_user_colour'] = $album_data_sql['album_last_image_name'] = '';
365
-			}
366
-			else if ($row['album_type'] == \phpbbgallery\core\block::TYPE_UPLOAD && $album_data_sql['album_type'] == \phpbbgallery\core\block::TYPE_CAT)
355
+			} else if ($row['album_type'] == \phpbbgallery\core\block::TYPE_UPLOAD && $album_data_sql['album_type'] == \phpbbgallery\core\block::TYPE_CAT)
367 356
 			{
368 357
 				// Changing a album to a category? Yes!
369 358
 				// we're turning a uploadable album into a non-uploadable album
@@ -374,22 +363,18 @@  discard block
 block discarded – undo
374 363
 					if ($to_album_id)
375 364
 					{
376 365
 						$errors = $this->move_album_content($album_data_sql['album_id'], $to_album_id);
377
-					}
378
-					else
366
+					} else
379 367
 					{
380 368
 						return array($this->language->lang('NO_DESTINATION_ALBUM'));
381 369
 					}
382
-				}
383
-				else if ($album_data_sql['type_action'] == 'delete')
370
+				} else if ($album_data_sql['type_action'] == 'delete')
384 371
 				{
385 372
 					$errors = $this->delete_album_content($album_data_sql['album_id']);
386
-				}
387
-				else
373
+				} else
388 374
 				{
389 375
 					return array($this->language->lang('NO_ALBUM_ACTION'));
390 376
 				}
391
-			}
392
-			else if ($row['album_type'] == \phpbbgallery\core\block::TYPE_CONTEST && $album_data_sql['album_type'] == \phpbbgallery\core\block::TYPE_CONTEST)
377
+			} else if ($row['album_type'] == \phpbbgallery\core\block::TYPE_CONTEST && $album_data_sql['album_type'] == \phpbbgallery\core\block::TYPE_CONTEST)
393 378
 			{
394 379
 				// Changing a contest to contest? Yes!
395 380
 				// We need to check for the contest_data
@@ -417,8 +402,7 @@  discard block
 block discarded – undo
417 402
 				if ($row['album_id'] != $album_data_sql['parent_id'])
418 403
 				{
419 404
 					$errors = $this->move_album($album_data_sql['album_id'], $album_data_sql['parent_id']);
420
-				}
421
-				else
405
+				} else
422 406
 				{
423 407
 					$album_data_sql['parent_id'] = $row['parent_id'];
424 408
 				}
@@ -561,13 +545,11 @@  discard block
 block discarded – undo
561 545
 			if ($to_data['right_id'] > $from_data['right_id'])
562 546
 			{
563 547
 				$diff = '+ ' . ($to_data['right_id'] - $from_data['right_id'] - 1);
564
-			}
565
-			else
548
+			} else
566 549
 			{
567 550
 				$diff = '- ' . abs($to_data['right_id'] - $from_data['right_id'] - 1);
568 551
 			}
569
-		}
570
-		else
552
+		} else
571 553
 		{
572 554
 			$sql = 'SELECT MAX(right_id) AS right_id
573 555
 				FROM ' . $this->albums_table . ' 
@@ -613,14 +595,12 @@  discard block
 block discarded – undo
613 595
 		{
614 596
 			$log_action_images = 'IMAGES';
615 597
 			$errors = array_merge($errors, $this->delete_album_content($album_id));
616
-		}
617
-		else if ($action_images == 'move')
598
+		} else if ($action_images == 'move')
618 599
 		{
619 600
 			if (!$images_to_id)
620 601
 			{
621 602
 				$errors[] = $this->language->lang('NO_DESTINATION_ALBUM');
622
-			}
623
-			else
603
+			} else
624 604
 			{
625 605
 				$log_action_images = 'MOVE_IMAGES';
626 606
 
@@ -634,8 +614,7 @@  discard block
 block discarded – undo
634 614
 				if (!$row)
635 615
 				{
636 616
 					$errors[] = $this->language->lang('NO_ALBUM');
637
-				}
638
-				else
617
+				} else
639 618
 				{
640 619
 					$images_to_name = $row['album_name'];
641 620
 					$errors = array_merge($errors, $this->move_album_content($album_id, $images_to_id));
@@ -669,14 +648,12 @@  discard block
 block discarded – undo
669 648
 			$sql = 'DELETE FROM ' . $this->albums_table . ' 
670 649
 				WHERE ' . $this->db->sql_in_set('album_id', $album_ids);
671 650
 			$this->db->sql_query($sql);
672
-		}
673
-		else if ($action_subalbums == 'move')
651
+		} else if ($action_subalbums == 'move')
674 652
 		{
675 653
 			if (!$subalbums_to_id)
676 654
 			{
677 655
 				$errors[] = $this->language->lang('NO_DESTINATION_ALBUM');
678
-			}
679
-			else
656
+			} else
680 657
 			{
681 658
 				$log_action_albums = 'MOVE_ALBUMS';
682 659
 
@@ -690,8 +667,7 @@  discard block
 block discarded – undo
690 667
 				if (!$row)
691 668
 				{
692 669
 					$errors[] = $this->language->lang('NO_ALBUM');
693
-				}
694
-				else
670
+				} else
695 671
 				{
696 672
 					$subalbums_to_name = $row['album_name'];
697 673
 
@@ -726,8 +702,7 @@  discard block
 block discarded – undo
726 702
 			{
727 703
 				return $errors;
728 704
 			}
729
-		}
730
-		else
705
+		} else
731 706
 		{
732 707
 			$diff = 2;
733 708
 			$sql = 'DELETE FROM ' . $this->albums_table . '  
@@ -1021,8 +996,7 @@  discard block
 block discarded – undo
1021 996
 
1022 997
 			$move_up_left = $album_row['left_id'];
1023 998
 			$move_up_right = $album_row['right_id'];
1024
-		}
1025
-		else
999
+		} else
1026 1000
 		{
1027 1001
 			$left_id = $album_row['left_id'];
1028 1002
 			$right_id = $target['right_id'];
Please login to merge, or discard this patch.
Indentation   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -817,8 +817,8 @@  discard block
 block discarded – undo
817 817
 		$log_action = implode('_', array($log_action_images, $log_action_albums));
818 818
 
819 819
 		/**
820
-		* Log what we did
821
-		*/
820
+		 * Log what we did
821
+		 */
822 822
 		switch ($log_action)
823 823
 		{
824 824
 			case 'MOVE_IMAGES_MOVE_ALBUMS':
@@ -908,14 +908,14 @@  discard block
 block discarded – undo
908 908
 		$this->gallery_notification->delete_albums($from_id);
909 909
 
910 910
 		/**
911
-		* Event related to moving album content
912
-		*
913
-		* @event phpbbgallery.core.album.manage.move_album_content
914
-		* @var	int	from_id		Album we are moving from
915
-		* @var	int	to_id		Album we are moving to
916
-		* @var	bool	sync	Should we sync the albums data
917
-		* @since 1.2.0
918
-		*/
911
+		 * Event related to moving album content
912
+		 *
913
+		 * @event phpbbgallery.core.album.manage.move_album_content
914
+		 * @var	int	from_id		Album we are moving from
915
+		 * @var	int	to_id		Album we are moving to
916
+		 * @var	bool	sync	Should we sync the albums data
917
+		 * @since 1.2.0
918
+		 */
919 919
 		$vars = array('from_id', 'to_id', 'sync');
920 920
 		extract($this->dispatcher->trigger_event('phpbbgallery.core.album.manage.move_album_content', compact($vars)));
921 921
 
@@ -1017,12 +1017,12 @@  discard block
 block discarded – undo
1017 1017
 		$this->gallery_config->set('num_comments', (int) $row['num_comments']);
1018 1018
 
1019 1019
 		/**
1020
-		* Event delete album content
1021
-		*
1022
-		* @event phpbbgallery.core.album.manage.delete_album_content
1023
-		* @var	int	album_id		Album we are deleting
1024
-		* @since 1.2.0
1025
-		*/
1020
+		 * Event delete album content
1021
+		 *
1022
+		 * @event phpbbgallery.core.album.manage.delete_album_content
1023
+		 * @var	int	album_id		Album we are deleting
1024
+		 * @since 1.2.0
1025
+		 */
1026 1026
 		$vars = array('album_id');
1027 1027
 		extract($this->dispatcher->trigger_event('phpbbgallery.core.album.manage.delete_album_content', compact($vars)));
1028 1028
 
@@ -1045,11 +1045,11 @@  discard block
 block discarded – undo
1045 1045
 	public function move_album_by($album_row, $action = 'move_up', $steps = 1)
1046 1046
 	{
1047 1047
 		/**
1048
-		* Fetch all the siblings between the module's current spot
1049
-		* and where we want to move it to. If there are less than $steps
1050
-		* siblings between the current spot and the target then the
1051
-		* module will move as far as possible
1052
-		*/
1048
+		 * Fetch all the siblings between the module's current spot
1049
+		 * and where we want to move it to. If there are less than $steps
1050
+		 * siblings between the current spot and the target then the
1051
+		 * module will move as far as possible
1052
+		 */
1053 1053
 		$sql = 'SELECT album_id, album_name, left_id, right_id
1054 1054
 			FROM ' . $this->albums_table . ' 
1055 1055
 			WHERE parent_id = ' . (int) $album_row['parent_id'] . '
@@ -1071,12 +1071,12 @@  discard block
 block discarded – undo
1071 1071
 		}
1072 1072
 
1073 1073
 		/**
1074
-		* $left_id and $right_id define the scope of the nodes that are affected by the move.
1075
-		* $diff_up and $diff_down are the values to substract or add to each node's left_id
1076
-		* and right_id in order to move them up or down.
1077
-		* $move_up_left and $move_up_right define the scope of the nodes that are moving
1078
-		* up. Other nodes in the scope of ($left_id, $right_id) are considered to move down.
1079
-		*/
1074
+		 * $left_id and $right_id define the scope of the nodes that are affected by the move.
1075
+		 * $diff_up and $diff_down are the values to substract or add to each node's left_id
1076
+		 * and right_id in order to move them up or down.
1077
+		 * $move_up_left and $move_up_right define the scope of the nodes that are moving
1078
+		 * up. Other nodes in the scope of ($left_id, $right_id) are considered to move down.
1079
+		 */
1080 1080
 		if ($action == 'move_up')
1081 1081
 		{
1082 1082
 			$left_id = $target['left_id'];
Please login to merge, or discard this patch.
core/search.php 3 patches
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -149,8 +149,7 @@  discard block
 block discarded – undo
149 149
 		if (!$sql_limit)
150 150
 		{
151 151
 			$result = $this->db->sql_query($sql);
152
-		}
153
-		else
152
+		} else
154 153
 		{
155 154
 			$result = $this->db->sql_query_limit($sql, $sql_limit);
156 155
 		}
@@ -446,8 +445,7 @@  discard block
 block discarded – undo
446 445
 				'BLOCK_NAME'	=> $block_name ? $block_name : '' ,
447 446
 				'U_BLOCK'	=> $u_block ? $u_block : $this->helper->route('phpbbgallery_core_search_egosearch'),
448 447
 			));
449
-		}
450
-		else
448
+		} else
451 449
 		{
452 450
 			$this->template->assign_block_vars('imageblock', array(
453 451
 				'BLOCK_NAME'	=>  $block_name ? $block_name : $this->language->lang('RECENT_IMAGES'),
@@ -505,8 +503,7 @@  discard block
 block discarded – undo
505 503
 					'phpbbgallery_core_search_egosearch_page',),
506 504
 					'params' => array()), 'pagination', 'page', $count, $limit, $start
507 505
 			);
508
-		}
509
-		else
506
+		} else
510 507
 		{
511 508
 			$this->template->assign_vars(array(
512 509
 				'TOTAL_IMAGES'				=> $this->language->lang('VIEW_ALBUM_IMAGES', $count),
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
 			$this->template->assign_block_vars('commentrow', array(
315 315
 				'COMMENT_ID'	=> (int) $var['comment_id'],
316 316
 				'U_DELETE'	=> ($this->gallery_auth->acl_check('m_comments', $album_tmp['album_id'], $album_tmp['album_user_id']) || ($this->gallery_auth->acl_check('c_delete', $album_tmp['album_id'], $album_tmp['album_user_id']) && ($var['comment_user_id'] == $this->user->data['user_id']) && $this->user->data['is_registered'])) ? $this->helper->route('phpbbgallery_core_comment_delete', array('image_id' => $var['comment_image_id'], 'comment_id' => $var['comment_id'])) : false,
317
-				'U_EDIT'	=> $this->gallery_auth->acl_check('c_edit', $album_tmp['album_id'], $album_tmp['album_user_id'])? $this->helper->route('phpbbgallery_core_comment_edit', array('image_id'	=> $var['comment_image_id'], 'comment_id'	=> $var['comment_id'])) : false,
317
+				'U_EDIT'	=> $this->gallery_auth->acl_check('c_edit', $album_tmp['album_id'], $album_tmp['album_user_id']) ? $this->helper->route('phpbbgallery_core_comment_edit', array('image_id'	=> $var['comment_image_id'], 'comment_id'	=> $var['comment_id'])) : false,
318 318
 				'U_QUOTE'	=> ($this->gallery_auth->acl_check('c_post', $album_tmp['album_id'], $album_tmp['album_user_id'])) ? $this->helper->route('phpbbgallery_core_comment_add', array('image_id'	=> $var['comment_image_id'], 'comment_id'	=> $var['comment_id'])) : false,
319 319
 				'U_COMMENT'	=> $this->helper->route('phpbbgallery_core_image', array('image_id' => $var['comment_image_id'])) . '#comment_' . $var['comment_id'],
320 320
 				'POST_AUTHOR_FULL'	=> (string) $this->user_loader->get_username($var['comment_user_id'], 'full'),
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
 		if ($user > 0)
448 448
 		{
449 449
 			$this->template->assign_block_vars('imageblock', array(
450
-				'BLOCK_NAME'	=> $block_name ? $block_name : '' ,
450
+				'BLOCK_NAME'	=> $block_name ? $block_name : '',
451 451
 				'U_BLOCK'	=> $u_block ? $u_block : $this->helper->route('phpbbgallery_core_search_egosearch'),
452 452
 			));
453 453
 		}
@@ -547,7 +547,7 @@  discard block
 block discarded – undo
547 547
 		$this->db->sql_freeresult($result);
548 548
 		$count = $row['count'];
549 549
 		$sql_array['SELECT'] = '* , a.album_name, a.album_status, a.album_user_id, a.album_id';
550
-		$sql_array['LEFT_JOIN']	= array(
550
+		$sql_array['LEFT_JOIN'] = array(
551 551
 			array(
552 552
 				'FROM'		=> array($this->albums_table => 'a'),
553 553
 				'ON'		=> 'a.album_id = i.image_album_id',
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -243,9 +243,9 @@
 block discarded – undo
243 243
 	}
244 244
 
245 245
 	/**
246
-	* Get all recent images the user has access to
247
-	* return (int) $images_count
248
-	*/
246
+	 * Get all recent images the user has access to
247
+	 * return (int) $images_count
248
+	 */
249 249
 	public function recent_count()
250 250
 	{
251 251
 		$this->gallery_auth->load_user_permissions($this->user->data['user_id']);
Please login to merge, or discard this patch.
core/file/file.php 3 patches
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -231,9 +231,9 @@  discard block
 block discarded – undo
231 231
 	}
232 232
 
233 233
 	/**
234
-	* We need to disable the "last-modified" caching for guests and in cases of image-errors,
235
-	* so that they can view them, if they logged in or the error was fixed.
236
-	*/
234
+	 * We need to disable the "last-modified" caching for guests and in cases of image-errors,
235
+	 * so that they can view them, if they logged in or the error was fixed.
236
+	 */
237 237
 	public function disable_browser_cache()
238 238
 	{
239 239
 		$this->browser_cache = false;
@@ -460,12 +460,12 @@  discard block
 block discarded – undo
460 460
 	}
461 461
 
462 462
 	/**
463
-	* Delete file from disc.
464
-	*
465
-	* @param	mixed		$files		String with filename or an array of filenames
466
-	*									Array-Format: $image_id => $filename
467
-	* @param	array		$locations	Array of valid url::path()s where the image should be deleted from
468
-	*/
463
+	 * Delete file from disc.
464
+	 *
465
+	 * @param	mixed		$files		String with filename or an array of filenames
466
+	 *									Array-Format: $image_id => $filename
467
+	 * @param	array		$locations	Array of valid url::path()s where the image should be deleted from
468
+	 */
469 469
 	public function delete($files, $locations = array('thumbnail', 'medium', 'upload'))
470 470
 	{
471 471
 		if (!is_array($files))
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -294,13 +294,13 @@
 block discarded – undo
294 294
 
295 295
 		if (($this->image_size['height'] / $max_height) > ($this->image_size['width'] / $max_width))
296 296
 		{
297
-			$this->thumb_height	= $max_height;
298
-			$this->thumb_width	= round($max_width * (($this->image_size['width'] / $max_width) / ($this->image_size['height'] / $max_height)));
297
+			$this->thumb_height = $max_height;
298
+			$this->thumb_width = round($max_width * (($this->image_size['width'] / $max_width) / ($this->image_size['height'] / $max_height)));
299 299
 		}
300 300
 		else
301 301
 		{
302
-			$this->thumb_height	= round($max_height * (($this->image_size['height'] / $max_height) / ($this->image_size['width'] / $max_width)));
303
-			$this->thumb_width	= $max_width;
302
+			$this->thumb_height = round($max_height * (($this->image_size['height'] / $max_height) / ($this->image_size['width'] / $max_width)));
303
+			$this->thumb_width = $max_width;
304 304
 		}
305 305
 
306 306
 		$image_copy = (($this->gd_version == self::GDLIB1) ? @imagecreate($this->thumb_width, $this->thumb_height + $additional_height) : @imagecreatetruecolor($this->thumb_width, $this->thumb_height + $additional_height));
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -161,8 +161,7 @@  discard block
 block discarded – undo
161 161
 		if (isset($this->image_size['file']))
162 162
 		{
163 163
 			$file_size = $this->image_size['file'];
164
-		}
165
-		else if ($force_filesize)
164
+		} else if ($force_filesize)
166 165
 		{
167 166
 			$file_size = @filesize($this->image_source);
168 167
 		}
@@ -296,8 +295,7 @@  discard block
 block discarded – undo
296 295
 		{
297 296
 			$this->thumb_height	= $max_height;
298 297
 			$this->thumb_width	= round($max_width * (($this->image_size['width'] / $max_width) / ($this->image_size['height'] / $max_height)));
299
-		}
300
-		else
298
+		} else
301 299
 		{
302 300
 			$this->thumb_height	= round($max_height * (($this->image_size['height'] / $max_height) / ($this->image_size['width'] / $max_width)));
303 301
 			$this->thumb_width	= $max_width;
@@ -407,8 +405,7 @@  discard block
 block discarded – undo
407 405
 		{
408 406
 			$this->image_source = $get_wm_name;
409 407
 			$this->read_image();
410
-		}
411
-		else
408
+		} else
412 409
 		{
413 410
 			$this->watermark_size = getimagesize($this->watermark_source);
414 411
 			switch ($this->watermark_size['mime'])
@@ -437,16 +434,14 @@  discard block
 block discarded – undo
437 434
 			if ($watermark_position & $phpbb_gallery_constants::WATERMARK_LEFT)
438 435
 			{
439 436
 				$dst_x = 5;
440
-			}
441
-			else if ($watermark_position & $phpbb_gallery_constants::WATERMARK_RIGHT)
437
+			} else if ($watermark_position & $phpbb_gallery_constants::WATERMARK_RIGHT)
442 438
 			{
443 439
 				$dst_x = ($this->image_size['width'] - $this->watermark_size[0] - 5);
444 440
 			}
445 441
 			if ($watermark_position & $phpbb_gallery_constants::WATERMARK_TOP)
446 442
 			{
447 443
 				$dst_y = 5;
448
-			}
449
-			else if ($watermark_position & $phpbb_gallery_constants::WATERMARK_MIDDLE)
444
+			} else if ($watermark_position & $phpbb_gallery_constants::WATERMARK_MIDDLE)
450 445
 			{
451 446
 				$dst_y = (($this->image_size['height'] * 0.5) - ($this->watermark_size[1] * 0.5));
452 447
 			}
Please login to merge, or discard this patch.
core/event/main_listener.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,13 +122,13 @@
 block discarded – undo
122 122
 		}
123 123
 		if ($recent)
124 124
 		{
125
-			$block_name	= $this->language->lang('RECENT_IMAGES');
125
+			$block_name = $this->language->lang('RECENT_IMAGES');
126 126
 			$u_block = ' ';
127 127
 			$this->gallery_search->recent($this->gallery_config->get('rrc_profile_items'), -1, $event['member']['user_id'], 'rrc_profile_display', $block_name, $u_block);
128 128
 		}
129 129
 		if ($random)
130 130
 		{
131
-			$block_name	= $this->language->lang('RANDOM_IMAGES');
131
+			$block_name = $this->language->lang('RANDOM_IMAGES');
132 132
 			$u_block = ' ';
133 133
 			$this->gallery_search->random($this->gallery_config->get('rrc_profile_items'), $event['member']['user_id'], 'rrc_profile_display', $block_name, $u_block);
134 134
 		}
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -146,8 +146,7 @@
 block discarded – undo
146 146
 					'U_GALLERY_IMAGES_ALLOW'	=> true,
147 147
 					'U_GALLERY_IMAGES'	=> $user_info['user_images'],
148 148
 				));
149
-			}
150
-			else
149
+			} else
151 150
 			{
152 151
 				$this->template->assign_vars(array(
153 152
 					'U_GALLERY_IMAGES_ALLOW'	=> true,
Please login to merge, or discard this patch.
core/comment.php 3 patches
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -183,10 +183,10 @@  discard block
 block discarded – undo
183 183
 	}
184 184
 
185 185
 	/**
186
-	* Delete comments
187
-	*
188
-	* @param	mixed	$comment_ids	Array or integer with comment_id we delete.
189
-	*/
186
+	 * Delete comments
187
+	 *
188
+	 * @param	mixed	$comment_ids	Array or integer with comment_id we delete.
189
+	 */
190 190
 	public function delete_comments($comment_ids)
191 191
 	{
192 192
 		$comment_ids = $this->cast_mixed_int2array($comment_ids);
@@ -216,11 +216,11 @@  discard block
 block discarded – undo
216 216
 	}
217 217
 
218 218
 	/**
219
-	* Delete comments for given image_ids
220
-	*
221
-	* @param	mixed	$image_ids		Array or integer with image_id where we delete the comments.
222
-	* @param	bool	$reset_stats	Shall we also reset the statistics? We can save that query, when the images are deleted anyway.
223
-	*/
219
+	 * Delete comments for given image_ids
220
+	 *
221
+	 * @param	mixed	$image_ids		Array or integer with image_id where we delete the comments.
222
+	 * @param	bool	$reset_stats	Shall we also reset the statistics? We can save that query, when the images are deleted anyway.
223
+	 */
224 224
 	public function delete_images($image_ids, $reset_stats = false)
225 225
 	{
226 226
 		$image_ids = $this->cast_mixed_int2array($image_ids);
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 			'comment_time'			=> time(),
95 95
 		);
96 96
 
97
-		$this->db->sql_query('INSERT INTO ' .$this->comments_table .' ' . $this->db->sql_build_array('INSERT', $data));
97
+		$this->db->sql_query('INSERT INTO ' . $this->comments_table . ' ' . $this->db->sql_build_array('INSERT', $data));
98 98
 		$newest_comment_id = (int) $this->db->sql_nextid();
99 99
 		$this->config->inc('num_comments', 1);
100 100
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -244,8 +244,7 @@
 block discarded – undo
244 244
 		if (is_array($ids))
245 245
 		{
246 246
 			return array_map('intval', $ids);
247
-		}
248
-		else
247
+		} else
249 248
 		{
250 249
 			return array((int) $ids);
251 250
 		}
Please login to merge, or discard this patch.
core/notification.php 2 patches
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -95,11 +95,11 @@  discard block
 block discarded – undo
95 95
 	}
96 96
 
97 97
 	/**
98
-	* Remove images from watch-list
99
-	*
100
-	* @param	mixed	$image_ids		Array or integer with image_id where we delete from the watch-list.
101
-	* @param	mixed	$user_ids		If not set, it uses the currents user_id
102
-	*/
98
+	 * Remove images from watch-list
99
+	 *
100
+	 * @param	mixed	$image_ids		Array or integer with image_id where we delete from the watch-list.
101
+	 * @param	mixed	$user_ids		If not set, it uses the currents user_id
102
+	 */
103 103
 	public function remove($image_ids, $user_ids = false)
104 104
 	{
105 105
 		$image_ids = self::cast_mixed_int2array($image_ids);
@@ -112,11 +112,11 @@  discard block
 block discarded – undo
112 112
 	}
113 113
 
114 114
 	/**
115
-	* Remove albums from watch-list
116
-	*
117
-	* @param	mixed	$album_ids		Array or integer with album_id where we delete from the watch-list.
118
-	* @param	mixed	$user_ids		If not set, it uses the currents user_id
119
-	*/
115
+	 * Remove albums from watch-list
116
+	 *
117
+	 * @param	mixed	$album_ids		Array or integer with album_id where we delete from the watch-list.
118
+	 * @param	mixed	$user_ids		If not set, it uses the currents user_id
119
+	 */
120 120
 	public function remove_albums($album_ids, $user_ids = false)
121 121
 	{
122 122
 		$album_ids = self::cast_mixed_int2array($album_ids);
@@ -129,10 +129,10 @@  discard block
 block discarded – undo
129 129
 	}
130 130
 
131 131
 	/**
132
-	* Delete given image_ids from watch-list
133
-	*
134
-	* @param	mixed	$image_ids		Array or integer with image_id where we delete from watch-list.
135
-	*/
132
+	 * Delete given image_ids from watch-list
133
+	 *
134
+	 * @param	mixed	$image_ids		Array or integer with image_id where we delete from watch-list.
135
+	 */
136 136
 	public function delete_images($image_ids)
137 137
 	{
138 138
 		$image_ids = self::cast_mixed_int2array($image_ids);
@@ -144,10 +144,10 @@  discard block
 block discarded – undo
144 144
 
145 145
 
146 146
 	/**
147
-	* Delete given album_ids from watch-list
148
-	*
149
-	* @param	mixed	$album_ids		Array or integer with album_id where we delete from watch-list.
150
-	*/
147
+	 * Delete given album_ids from watch-list
148
+	 *
149
+	 * @param	mixed	$album_ids		Array or integer with album_id where we delete from watch-list.
150
+	 */
151 151
 	public function delete_albums($album_ids)
152 152
 	{
153 153
 		$album_ids = self::cast_mixed_int2array($album_ids);
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -244,8 +244,7 @@
 block discarded – undo
244 244
 		if (is_array($ids))
245 245
 		{
246 246
 			return array_map('intval', $ids);
247
-		}
248
-		else
247
+		} else
249 248
 		{
250 249
 			return array((int) $ids);
251 250
 		}
Please login to merge, or discard this patch.