phpbbgallery\core\search::recent_count()

Complexity

Conditions	8
Paths	18

Size

Total Lines	55
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	21
CRAP Score	9

Importance

Changes	1
Bugs	0	Features	0

<?php
	public function recent_count()
	{
		$this->gallery_auth->load_user_permissions($this->user->data['user_id']);

		$exclude_albums = [];

		if (!$this->gallery_config->get('rrc_gindex_pegas'))
		{
			$sql_no_user = 'SELECT album_id FROM ' . $this->albums_table . ' WHERE album_user_id > 0';
			$result = $this->db->sql_query($sql_no_user);
			while ($row = $this->db->sql_fetchrow($result))
			{
				$exclude_albums[] = (int) $row['album_id'];
			}
			$this->db->sql_freeresult($result);
		}

		$exclude_albums = array_merge($exclude_albums, $this->gallery_auth->get_exclude_zebra());

		// Get allowed album ids for view and mod permissions excluding excluded albums
		$view_album_ids = array_diff($this->gallery_auth->acl_album_ids('i_view'), $exclude_albums);

It seems like $this->gallery_auth->acl_album_ids('i_view') can also be of type true; however, parameter $array of array_diff() does only seem to accept array, maybe add an additional type check?

		$mod_album_ids = array_diff($this->gallery_auth->acl_album_ids('m_status'), $exclude_albums);

		if (empty($view_album_ids) && empty($mod_album_ids))
		{
			return 0;
		}

		$sql = 'SELECT COUNT(image_id) AS count
			FROM ' . $this->images_table . '
			WHERE image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN;

		$conditions = [];

		if (!empty($view_album_ids))
		{
			$conditions[] = '(' . $this->db->sql_in_set('image_album_id', $view_album_ids) . '
				AND image_status <> ' . (int) \phpbbgallery\core\block::STATUS_UNAPPROVED . ')';
		}

		if (!empty($mod_album_ids))
		{
			$conditions[] = $this->db->sql_in_set('image_album_id', $mod_album_ids);
		}

		if (!empty($conditions))
		{
			$sql .= ' AND (' . implode(' OR ', $conditions) . ')';
		}

		$result = $this->db->sql_query($sql);
		$row = $this->db->sql_fetchrow($result);
		$this->db->sql_freeresult($result);

		return (int) $row['count'];
	}