@@ -117,8 +117,7 @@ discard block |
||
117 | 117 | try |
118 | 118 | { |
119 | 119 | $this->loader->load($album_id); |
120 | - } |
|
121 | - catch (\Exception $e) |
|
120 | + } catch (\Exception $e) |
|
122 | 121 | { |
123 | 122 | throw new \phpbb\exception\http_exception(404, 'ALBUM_NOT_EXIST'); |
124 | 123 | } |
@@ -178,8 +177,7 @@ discard block |
||
178 | 177 | 'phpbbgallery_core_album_upload', |
179 | 178 | array('album_id' => (int) $album_id) |
180 | 179 | )); |
181 | - } |
|
182 | - else |
|
180 | + } else |
|
183 | 181 | { |
184 | 182 | if ($album_data['contest_start'] + $album_data['contest_rating'] > time()) |
185 | 183 | { |
@@ -236,8 +234,7 @@ discard block |
||
236 | 234 | if (in_array($sort_key, array('r', 'ra'))) |
237 | 235 | { |
238 | 236 | $sql_help_sort = ', image_id ' . (($sort_dir == 'd') ? 'ASC' : 'DESC'); |
239 | - } |
|
240 | - else |
|
237 | + } else |
|
241 | 238 | { |
242 | 239 | $sql_help_sort = ', image_id ' . (($sort_dir == 'd') ? 'DESC' : 'ASC'); |
243 | 240 | } |
@@ -460,8 +457,7 @@ discard block |
||
460 | 457 | )); |
461 | 458 | $this->url->meta_refresh(3, $back_link); |
462 | 459 | return $this->helper->render('gallery/message.html', $this->language->lang('GALLERY')); |
463 | - } |
|
464 | - else |
|
460 | + } else |
|
465 | 461 | { |
466 | 462 | $this->notifications_helper->add_albums($album_id); |
467 | 463 | $this->template->assign_vars(array( |
@@ -470,14 +466,12 @@ discard block |
||
470 | 466 | $this->url->meta_refresh(3, $back_link); |
471 | 467 | return $this->helper->render('gallery/message.html', $this->language->lang('GALLERY')); |
472 | 468 | } |
473 | - } |
|
474 | - else |
|
469 | + } else |
|
475 | 470 | { |
476 | 471 | if ($this->notifications_helper->get_watched_album($album_id) == 1) |
477 | 472 | { |
478 | 473 | $lang = $this->language->lang('UNWATCH_ALBUM'); |
479 | - } |
|
480 | - else |
|
474 | + } else |
|
481 | 475 | { |
482 | 476 | $lang = $this->language->lang('WATCH_ALBUM'); |
483 | 477 | } |
@@ -509,8 +503,7 @@ discard block |
||
509 | 503 | if (!$this->user->data['is_registered']) |
510 | 504 | { |
511 | 505 | login_box(); |
512 | - } |
|
513 | - else |
|
506 | + } else |
|
514 | 507 | { |
515 | 508 | //return $this->error('NOT_AUTHORISED', 403); |
516 | 509 | trigger_error($this->language->lang('NOT_AUTHORISED')); |
@@ -85,8 +85,7 @@ discard block |
||
85 | 85 | { |
86 | 86 | $mod_array[] = 0; |
87 | 87 | } |
88 | - } |
|
89 | - else |
|
88 | + } else |
|
90 | 89 | { |
91 | 90 | $mod_array = array($album); |
92 | 91 | } |
@@ -162,8 +161,7 @@ discard block |
||
162 | 161 | $this->template->assign_vars(array( |
163 | 162 | 'TOTAL_PAGES' => $this->lang->lang('PAGE_TITLE_NUMBER', $page + 1), |
164 | 163 | )); |
165 | - } |
|
166 | - else |
|
164 | + } else |
|
167 | 165 | { |
168 | 166 | $this->pagination->generate_template_pagination(array( |
169 | 167 | 'routes' => array( |
@@ -160,8 +160,7 @@ discard block |
||
160 | 160 | if (isset($this->data[$key])) |
161 | 161 | { |
162 | 162 | return $this->data[$key]; |
163 | - } |
|
164 | - else if ($default && $this->get_default_value($key) !== null) |
|
163 | + } else if ($default && $this->get_default_value($key) !== null) |
|
165 | 164 | { |
166 | 165 | return $this->get_default_value($key); |
167 | 166 | } |
@@ -359,12 +358,10 @@ discard block |
||
359 | 358 | if (is_array($user_ids) && !empty($user_ids)) |
360 | 359 | { |
361 | 360 | $sql_where = 'WHERE ' . $this->db->sql_in_set('user_id', array_map('intval', $user_ids)); |
362 | - } |
|
363 | - else if ($user_ids == 'all') |
|
361 | + } else if ($user_ids == 'all') |
|
364 | 362 | { |
365 | 363 | $sql_where = ''; |
366 | - } |
|
367 | - else |
|
364 | + } else |
|
368 | 365 | { |
369 | 366 | $sql_where = 'WHERE user_id = ' . (int) $user_ids; |
370 | 367 | } |
@@ -395,8 +392,7 @@ discard block |
||
395 | 392 | { |
396 | 393 | // While incrementing, the iamges might be lower than 0. |
397 | 394 | $validated_data[$name] = (int) $value; |
398 | - } |
|
399 | - else |
|
395 | + } else |
|
400 | 396 | { |
401 | 397 | $validated_data[$name] = max(0, (int) $value); |
402 | 398 | } |
@@ -542,8 +538,7 @@ discard block |
||
542 | 538 | 'warnings' => 0, |
543 | 539 | 'allow_pm' => 0, |
544 | 540 | ); |
545 | - } |
|
546 | - else |
|
541 | + } else |
|
547 | 542 | { |
548 | 543 | $user_sig = ''; |
549 | 544 | // We add the signature to every posters entry because enable_sig is post dependent |
@@ -589,8 +584,7 @@ discard block |
||
589 | 584 | if ((!empty($row['user_allow_viewemail']) && $this->auth->acl_get('u_sendemail')) || $this->auth->acl_get('a_email')) |
590 | 585 | { |
591 | 586 | $user_cache[$user_id]['email'] = ($this->config['board_email_form'] && $this->config['email_enable']) ? append_sid("{$this->root_path}memberlist.$this->php_ext", "mode=email&u=$user_id") : (($this->config['board_hide_emails'] && !$this->auth->acl_get('a_email')) ? '' : 'mailto:' . $row['user_email']); |
592 | - } |
|
593 | - else |
|
587 | + } else |
|
594 | 588 | { |
595 | 589 | $user_cache[$user_id]['email'] = ''; |
596 | 590 | } |
@@ -603,8 +597,7 @@ discard block |
||
603 | 597 | if ($diff == 0) |
604 | 598 | { |
605 | 599 | $diff = ($now['mday'] - $bday_day < 0) ? 1 : 0; |
606 | - } |
|
607 | - else |
|
600 | + } else |
|
608 | 601 | { |
609 | 602 | $diff = ($diff < 0) ? 1 : 0; |
610 | 603 | } |
@@ -245,8 +245,7 @@ discard block |
||
245 | 245 | } |
246 | 246 | |
247 | 247 | $this->loader->load($this->data['image_album_id']); |
248 | - } |
|
249 | - catch (\Exception $e) |
|
248 | + } catch (\Exception $e) |
|
250 | 249 | { |
251 | 250 | throw new \phpbb\exception\http_exception(404, 'INVALID_IMAGE'); |
252 | 251 | } |
@@ -306,8 +305,7 @@ discard block |
||
306 | 305 | if (in_array($sort_key, array('r', 'ra'))) |
307 | 306 | { |
308 | 307 | $sql_help_sort = ', image_id ' . (($sort_dir == 'd') ? 'ASC' : 'DESC'); |
309 | - } |
|
310 | - else |
|
308 | + } else |
|
311 | 309 | { |
312 | 310 | $sql_help_sort = ', image_id ' . (($sort_dir == 'd') ? 'DESC' : 'ASC'); |
313 | 311 | } |
@@ -532,8 +530,7 @@ discard block |
||
532 | 530 | if (isset($album_data['contest_start'])) |
533 | 531 | { |
534 | 532 | $s_hide_comment_input = (time() < ($album_data['contest_start'] + $album_data['contest_end'])) ? true : false; |
535 | - } |
|
536 | - else |
|
533 | + } else |
|
537 | 534 | { |
538 | 535 | $s_hide_comment_input = false; |
539 | 536 | } |
@@ -580,8 +577,7 @@ discard block |
||
580 | 577 | //$this->template->assign_var('S_COMMENT_ACTION', append_sid($this->url->path('full') . 'comment/' . $image_id . '/add/0')); |
581 | 578 | $this->template->assign_var('S_COMMENT_ACTION', $this->helper->route('phpbbgallery_core_comment_add', array('image_id' => $image_id, 'comment_id' => 0))); |
582 | 579 | } |
583 | - } |
|
584 | - else if ($this->gallery_config->get('comment_user_control') && !$image_data['image_allow_comments']) |
|
580 | + } else if ($this->gallery_config->get('comment_user_control') && !$image_data['image_allow_comments']) |
|
585 | 581 | { |
586 | 582 | $this->template->assign_var('S_COMMENTS_DISABLED', true); |
587 | 583 | } |
@@ -772,8 +768,7 @@ discard block |
||
772 | 768 | 'NAME' => $field_data['PROFILE_FIELD_NAME'], |
773 | 769 | 'U_CONTACT' => $field_data['PROFILE_FIELD_CONTACT'], |
774 | 770 | )); |
775 | - } |
|
776 | - else |
|
771 | + } else |
|
777 | 772 | { |
778 | 773 | $this->template->assign_block_vars('commentrow.custom_fields', $field_data); |
779 | 774 | } |
@@ -901,8 +896,7 @@ discard block |
||
901 | 896 | { |
902 | 897 | $change_image_count = true; |
903 | 898 | } |
904 | - } |
|
905 | - else if ($this->request->variable('change_author', '', true)) |
|
899 | + } else if ($this->request->variable('change_author', '', true)) |
|
906 | 900 | { |
907 | 901 | $errors[] = $this->language->lang('INVALID_USERNAME'); |
908 | 902 | } |
@@ -923,8 +917,7 @@ discard block |
||
923 | 917 | { |
924 | 918 | $personal_album_id = $this->album->generate_personal_album($image_data['image_username'], $image_data['image_user_id'], $image_data['image_user_colour'], $image_user); |
925 | 919 | } |
926 | - } |
|
927 | - else |
|
920 | + } else |
|
928 | 921 | { |
929 | 922 | $personal_album_id = $this->gallery_user->get_data('personal_album_id'); |
930 | 923 | if (!$personal_album_id && $this->gallery_auth->acl_check('i_upload', $this->gallery_auth->get_own_album())) |
@@ -1092,8 +1085,7 @@ discard block |
||
1092 | 1085 | $this->notification_helper->read('approval', $album_id); |
1093 | 1086 | $this->url->meta_refresh(3, $album_backlink); |
1094 | 1087 | trigger_error($message); |
1095 | - } |
|
1096 | - else |
|
1088 | + } else |
|
1097 | 1089 | { |
1098 | 1090 | if (isset($_POST['cancel'])) |
1099 | 1091 | { |
@@ -1101,8 +1093,7 @@ discard block |
||
1101 | 1093 | $message .= '<br />' . sprintf($this->language->lang('CLICK_RETURN_IMAGE'), '<a href="' . $image_backlink . '">', '</a>'); |
1102 | 1094 | $this->url->meta_refresh(3, $image_backlink); |
1103 | 1095 | trigger_error($message); |
1104 | - } |
|
1105 | - else |
|
1096 | + } else |
|
1106 | 1097 | { |
1107 | 1098 | confirm_box(false, 'DELETE_IMAGE2', $s_hidden_fields); |
1108 | 1099 | } |
@@ -1207,8 +1198,7 @@ discard block |
||
1207 | 1198 | { |
1208 | 1199 | // @todo Add "redirect after login" url |
1209 | 1200 | login_box(); |
1210 | - } |
|
1211 | - else |
|
1201 | + } else |
|
1212 | 1202 | { |
1213 | 1203 | //return $this->error('NOT_AUTHORISED', 403); |
1214 | 1204 | redirect('/gallery/album/' . $album_id); |
@@ -222,8 +222,7 @@ discard block |
||
222 | 222 | { |
223 | 223 | $padding .= ' '; |
224 | 224 | $padding_store[$row['parent_id']] = $padding; |
225 | - } |
|
226 | - else if ($row['left_id'] > $right + 1) |
|
225 | + } else if ($row['left_id'] > $right + 1) |
|
227 | 226 | { |
228 | 227 | $padding = (isset($padding_store[$row['parent_id']])) ? $padding_store[$row['parent_id']] : ''; |
229 | 228 | } |
@@ -249,15 +248,13 @@ discard block |
||
249 | 248 | if (($select_id == $this->gallery_auth->get_setting_permissions()) && !$row['album_user_id']) |
250 | 249 | { |
251 | 250 | $list = true; |
252 | - } |
|
253 | - else if (!$row['album_user_id']) |
|
251 | + } else if (!$row['album_user_id']) |
|
254 | 252 | { |
255 | 253 | if ($this->gallery_auth->acl_check('a_list', $row['album_id'], $row['album_user_id']) || defined('IN_ADMIN')) |
256 | 254 | { |
257 | 255 | $list = true; |
258 | 256 | } |
259 | - } |
|
260 | - else if (!$ignore_personals) |
|
257 | + } else if (!$ignore_personals) |
|
261 | 258 | { |
262 | 259 | if ($row['album_user_id'] == $this->user->data['user_id']) |
263 | 260 | { |
@@ -268,16 +265,14 @@ discard block |
||
268 | 265 | if ($requested_permission) |
269 | 266 | { |
270 | 267 | $requested_own = !$this->gallery_auth->acl_check($requested_permission, $this->gallery_auth->get_own_album()); |
271 | - } |
|
272 | - else |
|
268 | + } else |
|
273 | 269 | { |
274 | 270 | $requested_own = false; // We need the negated version of true here |
275 | 271 | } |
276 | 272 | } |
277 | 273 | $list = (!$list) ? $access_own : $list; |
278 | 274 | $disabled = (!$disabled) ? $requested_own : $disabled; |
279 | - } |
|
280 | - else if ($row['album_user_id']) |
|
275 | + } else if ($row['album_user_id']) |
|
281 | 276 | { |
282 | 277 | if (!$c_access_personal) |
283 | 278 | { |
@@ -286,8 +281,7 @@ discard block |
||
286 | 281 | if ($requested_permission) |
287 | 282 | { |
288 | 283 | $requested_personal = !$this->gallery_auth->acl_check($requested_permission, $this->gallery_auth->get_personal_album()); |
289 | - } |
|
290 | - else |
|
284 | + } else |
|
291 | 285 | { |
292 | 286 | $requested_personal = false; // We need the negated version of true here |
293 | 287 | } |
@@ -299,8 +293,7 @@ discard block |
||
299 | 293 | if (($album_user_id != \phpbbgallery\core\block::PUBLIC_ALBUM) && ($album_user_id != $row['album_user_id'])) |
300 | 294 | { |
301 | 295 | $list = false; |
302 | - } |
|
303 | - else if (($album_user_id != \phpbbgallery\core\block::PUBLIC_ALBUM) && ($row['parent_id'] == 0)) |
|
296 | + } else if (($album_user_id != \phpbbgallery\core\block::PUBLIC_ALBUM) && ($row['parent_id'] == 0)) |
|
304 | 297 | { |
305 | 298 | $disabled = true; |
306 | 299 | } |
@@ -318,8 +311,7 @@ discard block |
||
318 | 311 | $gallery_albumbox = "<select name='$select_name' id='$select_name'>"; |
319 | 312 | $gallery_albumbox .= $album_list; |
320 | 313 | $gallery_albumbox .= '</select>'; |
321 | - } |
|
322 | - else |
|
314 | + } else |
|
323 | 315 | { |
324 | 316 | $gallery_albumbox = $album_list; |
325 | 317 | } |
@@ -388,8 +380,7 @@ discard block |
||
388 | 380 | 'album_last_user_colour' => $row['image_user_colour'], |
389 | 381 | 'album_last_user_id' => $row['image_user_id'], |
390 | 382 | ); |
391 | - } |
|
392 | - else |
|
383 | + } else |
|
393 | 384 | { |
394 | 385 | // No approved image, so we clear the columns |
395 | 386 | $sql_ary = array( |
@@ -204,8 +204,7 @@ discard block |
||
204 | 204 | $sql_array['GROUP_BY'] = 'l.description, l.log_id, i.image_id'; |
205 | 205 | break; |
206 | 206 | } |
207 | - } |
|
208 | - else |
|
207 | + } else |
|
209 | 208 | { |
210 | 209 | $sql_array['ORDER_BY'] = 'l.log_time ' . (isset($additional['sort_dir']) ? 'ASC' : 'DESC'); |
211 | 210 | $sql_array['GROUP_BY'] = 'l.log_time, l.log_id, i.image_id'; |
@@ -219,8 +218,7 @@ discard block |
||
219 | 218 | if ($row) |
220 | 219 | { |
221 | 220 | $count = $row['count']; |
222 | - } |
|
223 | - else |
|
221 | + } else |
|
224 | 222 | { |
225 | 223 | $count = 0; |
226 | 224 | } |
@@ -281,8 +279,7 @@ discard block |
||
281 | 279 | 'params' => array( |
282 | 280 | ), |
283 | 281 | ), 'pagination', 'page', $count, $limit, ($page-1) * $limit); |
284 | - } |
|
285 | - else if ($album == -1) |
|
282 | + } else if ($album == -1) |
|
286 | 283 | { |
287 | 284 | $url_array = array( |
288 | 285 | 'i' => '-phpbbgallery-core-acp-gallery_logs_module', |
@@ -303,8 +300,7 @@ discard block |
||
303 | 300 | $url = http_build_query($url_array,'','&'); |
304 | 301 | |
305 | 302 | $this->pagination->generate_template_pagination(append_sid('index.php?' . $url), 'pagination', 'page', $count, $limit, ($page-1) * $limit); |
306 | - } |
|
307 | - else |
|
303 | + } else |
|
308 | 304 | { |
309 | 305 | $this->pagination->generate_template_pagination(array( |
310 | 306 | 'routes' => array( |