phpbbgallery\core\search::recent()

Complexity

Conditions	26
Paths	8065

Size

Total Lines	177
Code Lines	119

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	78
CRAP Score	41.5501

Importance

Changes	4
Bugs	0	Features	0

<?php
	public function recent($limit, $start = 0, $user = 0, $fields = 'rrc_gindex_display', $block_name = false, $u_block = false)
	{
		// We will do small escape for not devising by 0
		if ($limit == 0)
		{
			return;
		}
		if ($limit < -1)
		{
			$limit = -1;
		}
		$pagination = true;
		if ($start == -1)
		{
			$start = 0;
			$pagination = false;
		}
		$this->gallery_auth->load_user_permissions($this->user->data['user_id']);
		$sql_order = '';
		switch ($this->gallery_config->get('default_sort_key'))
		{
			case 't':
				$sql_order = 'image_time';
				break;
			case 'n':
				$sql_order = 'image_name_clean';
				break;
			case 'vc':
				$sql_order = 'image_view_count';
				break;
			case 'u':
				$sql_order = 'image_username_clean';
				break;
			case 'ra':
				$sql_order = 'image_rate_avg';
				break;
			case 'r':
				$sql_order = 'image_rates';
				break;
			case 'c':
				$sql_order = 'image_comments';
				break;
			case 'lc':
				$sql_order = 'image_last_comment';
				break;
		}
		$sql_order = $sql_order . ($this->gallery_config->get('default_sort_dir') == 'd' ? ' DESC' : ' ASC');
		$sql_limit = $limit;
		$exclude_albums = array();
		if (!$this->gallery_config->get('rrc_gindex_pegas'))
		{
			$sql_no_user = 'SELECT album_id FROM ' . $this->albums_table . ' WHERE album_user_id > 0';
			$result = $this->db->sql_query($sql_no_user);
			while ($row = $this->db->sql_fetchrow($result))
			{
				$exclude_albums[] = (int) $row['album_id'];
			}
			$this->db->sql_freeresult($result);
		}
		$exclude_albums = array_merge($exclude_albums, $this->gallery_auth->get_exclude_zebra());
		$sql_ary = array(
			'FROM'	=>	array(
				$this->images_table	=> 'i'
			),
			'WHERE'	=> 'image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN
		);
		if ($user > 0)
		{
			$sql_ary['WHERE'] .= ' and image_user_id = ' . (int) $user;
		}
		$user_id = $this->user->data['user_id'];
		$sql_ary['WHERE'] .= ' AND ((' . $this->db->sql_in_set('image_album_id', array_diff($this->gallery_auth->acl_album_ids('i_view'), $exclude_albums), false, true) . ' AND (image_status <> ' . \phpbbgallery\core\block::STATUS_UNAPPROVED . ' OR image_user_id = ' . $user_id . '))

It seems like $this->gallery_auth->acl_album_ids('i_view') can also be of type true; however, parameter $array of array_diff() does only seem to accept array, maybe add an additional type check?

					OR ' . $this->db->sql_in_set('image_album_id', array_diff($this->gallery_auth->acl_album_ids('m_status'), $exclude_albums), false, true) . ')';

		$sql_ary['SELECT'] = 'COUNT(image_id) as count';
		$sql = $this->db->sql_build_query('SELECT', $sql_ary);
		$result = $this->db->sql_query($sql);
		$row = $this->db->sql_fetchrow($result);
		$this->db->sql_freeresult($result);
		$count = $row['count'];

		$sql_ary['SELECT'] = 'image_id';
		$sql_ary['ORDER_BY'] = $sql_order;
		$sql = $this->db->sql_build_query('SELECT', $sql_ary);
		$result = $this->db->sql_query_limit($sql, $sql_limit, $start);
		$id_ary = [];
		while ($row = $this->db->sql_fetchrow($result))
		{
			$id_ary[] = $row['image_id'];
		}

		$this->db->sql_freeresult($result);

		$total_match_count = sizeof($id_ary);

		$l_search_matches = $this->language->lang('FOUND_SEARCH_MATCHES', $total_match_count);

The assignment to $l_search_matches is dead and can be removed.

		if ($user > 0)
		{
			$this->template->assign_block_vars('imageblock', array(
				'BLOCK_NAME'	=> $block_name ? $block_name : '' ,
				'U_BLOCK'	=> $u_block ? $u_block : $this->helper->route('phpbbgallery_core_search_egosearch'),
			));
		}
		else
		{
			$this->template->assign_block_vars('imageblock', array(
				'BLOCK_NAME'	=>  $block_name ? $block_name : $this->language->lang('RECENT_IMAGES'),
				'U_BLOCK'	=> $u_block ? $u_block : $this->helper->route('phpbbgallery_core_search_recent'),
			));
		}

		// For some searches we need to print out the "no results" page directly to allow re-sorting/refining the search options.
		if (!sizeof($id_ary))
		{
			$this->template->assign_block_vars('imageblock', array(
				'ERROR'	=> $this->language->lang('NO_SEARCH_RESULTS_RECENT')
			));
			return;
		}

		$id_ary = array_map('intval', $id_ary);

		$sql_where = $this->db->sql_in_set('i.image_id', $id_ary);

		$sql_array = array(
			'SELECT'		=> 'i.*, a.album_name, a.album_status, a.album_user_id, a.album_id',
			'FROM'			=> array($this->images_table => 'i'),

			'LEFT_JOIN'		=> array(
				array(
					'FROM'		=> array($this->albums_table => 'a'),
					'ON'		=> 'a.album_id = i.image_album_id',
				),
			),

			'WHERE'			=> 'i.image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN . ' AND ' . $sql_where,
			'ORDER_BY'		=> $sql_order,
		);
		$sql = $this->db->sql_build_query('SELECT', $sql_array);
		$result = $this->db->sql_query($sql);

		$show_options = $this->gallery_config->get($fields);
		$thumbnail_link = $this->gallery_config->get('link_thumbnail');
		$imagename_link = $this->gallery_config->get('link_image_name');

		while ($row = $this->db->sql_fetchrow($result))
		{
			$this->image->assign_block('imageblock.image', $row, $show_options, $thumbnail_link, $imagename_link);
		}
		$this->db->sql_freeresult($result);

		if ($user > 0)
		{
			$this->template->assign_vars(array(
				'SEARCH_MATCHES'	=> $this->language->lang('TOTAL_IMAGES_SPRINTF', $count),
				'SEARCH_TITLE'		=> $this->language->lang('SEARCH_USER_IMAGES_OF', $this->user->data['username']),
			));
			$this->pagination->generate_template_pagination(array(
				'routes' => array(
					'phpbbgallery_core_search_egosearch',
					'phpbbgallery_core_search_egosearch_page',),
					'params' => array()), 'pagination', 'page', $count, $limit, $start
			);
		}
		else
		{
			$this->template->assign_vars(array(
				'TOTAL_IMAGES'				=> $this->language->lang('VIEW_ALBUM_IMAGES', $count),
			));
			if ($pagination)
			{
				$this->pagination->generate_template_pagination(array(
					'routes' => array(
						'phpbbgallery_core_search_recent',
						'phpbbgallery_core_search_recent_page',),
						'params' => array()), 'pagination', 'page', $count, $limit, $start
				);