phpbbgallery\core\ucp\main_module

Complexity

Total Complexity

110

Size/Duplication

Total Lines	1092
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	1	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	subscribe_pegas()	0	15	2
A	move_album()	0	69	4
D	manage_subscriptions()	0	143	15
F	create_album()	0	141	17
A	info()	0	21	2
F	edit_album()	0	239	30
A	initialise_album()	0	50	3
F	delete_album()	0	187	14
C	manage_albums()	0	90	11
C	main()	0	105	12

<?php
/**
 * phpBB Gallery - Core Extension
 *
 * @package   phpbbgallery/core
 * @author    nickvergessen
 * @author    satanasov
 * @author    Leinad4Mind
 * @copyright 2014 nickvergessen, 2014- satanasov, 2018- Leinad4Mind
 * @license   GPL-2.0-only
 */

namespace phpbbgallery\core\ucp;

/**
* @package ucp
*/
class main_module
{
	var $u_action;
	protected $language;
	public $tpl_name;
	public $page_title;

	function main($id, $mode)

The parameter $mode is not used and could be removed.

The parameter $id is not used and could be removed.

	{
		global $user, $phpbb_container, $table_prefix, $phpbb_gallery_url;
		global $phpbb_ext_gallery_core_album, $albums_table, $phpbb_ext_gallery_core_auth, $phpbb_ext_gallery_core_album_display, $images_table;
		global $phpbb_gallery_image, $users_table, $phpbb_ext_gallery_config, $comments_table, $rates_table, $reports_table, $watch_table, $contests_table;
		global $phpbb_ext_gallery_user, $request;

		$phpbb_gallery_url = $phpbb_container->get('phpbbgallery.core.url');
		$phpbb_gallery_url->_include('functions_display', 'phpbb');

		$phpbb_ext_gallery_core_album =$phpbb_container->get('phpbbgallery.core.album');

		$phpbb_ext_gallery_core_auth = $phpbb_container->get('phpbbgallery.core.auth');

		$phpbb_ext_gallery_config = $phpbb_container->get('phpbbgallery.core.config');

		$phpbb_ext_gallery_core_album_display = $phpbb_container->get('phpbbgallery.core.album.display');

		$phpbb_gallery_image = $phpbb_container->get('phpbbgallery.core.image');

		$phpbb_ext_gallery_user = $phpbb_container->get('phpbbgallery.core.user');
		$this->language = $phpbb_container->get('language');

		$albums_table = $table_prefix . 'gallery_albums';
		$roles_table = $table_prefix . 'gallery_roles';

The assignment to $roles_table is dead and can be removed.

		$permissions_table = $table_prefix . 'gallery_permissions';

The assignment to $permissions_table is dead and can be removed.

		$modscache_table = $table_prefix . 'gallery_modscache';

The assignment to $modscache_table is dead and can be removed.

		$contests_table = $table_prefix . 'gallery_contests';
		$users_table = $table_prefix . 'gallery_users';
		$images_table = $table_prefix . 'gallery_images';
		$comments_table = $table_prefix . 'gallery_comments';
		$rates_table = $table_prefix . 'gallery_rates';
		$reports_table = $table_prefix . 'gallery_reports';
		$watch_table = $table_prefix . 'gallery_watch';

		$this->language->add_lang(array('gallery', 'gallery_acp', 'gallery_mcp', 'gallery_ucp'), 'phpbbgallery/core');
		$this->language->add_lang('posting');
		$this->tpl_name = 'gallery/ucp_gallery';
		add_form_key('ucp_gallery');

The function add_form_key was not found. Maybe you did not declare it correctly or list all dependencies?

		$mode = $request->variable('mode', 'manage_albums');
		$action = $request->variable('action', '');
		$cancel = (isset($_POST['cancel'])) ? true : false;
		$phpbb_ext_gallery_core_auth->load_user_permissions($user->data['user_id']);
		if ($cancel)
		{
			$action = '';
		}
		switch ($mode)
		{
			case 'manage_albums':
				switch ($action)
				{
					case 'manage':
						$title = 'MANAGE_SUBALBUMS';
						$this->page_title = $this->language->lang($title);
						$this->manage_albums();
					break;

					case 'create':
						$title = 'CREATE_SUBALBUM';
						$this->page_title = $this->language->lang($title);
						$this->create_album();
					break;

					case 'edit':
						$title = 'EDIT_SUBALBUM';
						$this->page_title = $this->language->lang($title);
						$this->edit_album();
					break;

					case 'delete':
						$title = 'DELETE_ALBUM';
						$this->page_title = $this->language->lang($title);
						$this->delete_album();
					break;

					case 'move':
						$this->move_album();
					break;

					case 'initialise':
						$this->initialise_album();
					break;

					default:
						$title = 'UCP_GALLERY_PERSONAL_ALBUMS';
						$this->page_title = $this->language->lang($title);
						if (!$phpbb_ext_gallery_user->get_data('personal_album_id'))
						{
							$this->info();
						}
						else
						{
							$this->manage_albums();
						}
					break;
				}
			break;

			case 'manage_subscriptions':
				$title = 'UCP_GALLERY_WATCH';
				$this->page_title = $this->language->lang($title);
				$this->manage_subscriptions();
			break;
		}
	}

	function info()

It is generally recommended to explicitly declare the visibility for methods.

	{
		global $template, $user, $phpbb_ext_gallery_user, $phpbb_gallery_url, $phpbb_container;
		$this->language = $phpbb_container->get('language');

		//We need to set user_ID so we can test for any other thing
		$phpbb_ext_gallery_user->set_user_id($user->data['user_id']);
		if (!$phpbb_ext_gallery_user->get_data('personal_album_id'))
		{
			// User will probably go to initialise_album()
			$template->assign_vars(array(
				'S_INFO_CREATE'				=> true,
				'S_UCP_ACTION'		=> $this->u_action . '&action=initialise',

				'L_TITLE'			=> $this->language->lang('UCP_GALLERY_PERSONAL_ALBUMS'),
				'L_TITLE_EXPLAIN'	=> $this->language->lang('NO_PERSONAL_ALBUM'),
			));
		}
		else
		{
			$phpbb_gallery_url->redirect('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&mode=manage_albums&action=manage');
		}
	}

	function initialise_album()

It is generally recommended to explicitly declare the visibility for methods.

	{
		global $cache, $db,  $user, $phpbb_ext_gallery_core_auth, $phpbb_ext_gallery_core_album, $phpbb_ext_gallery_config, $albums_table, $phpbb_ext_gallery_user;
		global $request, $users_table, $phpbb_container;

		// we will have to initialise $phpbb_ext_gallery_user
		$phpbb_ext_gallery_user->set_user_id($user->data['user_id']);
		if (!$phpbb_ext_gallery_user->get_data('personal_album_id'))
		{
			// Check if the user is allowed to have on
			if (!$phpbb_ext_gallery_core_auth->acl_check('i_upload', $phpbb_ext_gallery_core_auth::OWN_ALBUM))
			{
				trigger_error('NO_PERSALBUM_ALLOWED');
			}

			$album_data = array(
				'album_name'					=> $user->data['username'],
				'parent_id'						=> $request->variable('parent_id', 0),
				//left_id and right_id default by db
				'album_desc_options'			=> 7,
				'album_desc'					=> utf8_normalize_nfc($request->variable('album_desc', '', true)),

The function utf8_normalize_nfc was not found. Maybe you did not declare it correctly or list all dependencies?

				'album_parents'					=> '',
				'album_type'					=> (int) \phpbbgallery\core\block::TYPE_UPLOAD,
				'album_status'					=> (int) \phpbbgallery\core\block::ALBUM_OPEN,
				'album_user_id'					=> $user->data['user_id'],
				'album_last_username'			=> '',
				'album_last_user_colour'		=> $user->data['user_colour'],
			);
			$db->sql_query('INSERT INTO ' . $albums_table . ' ' . $db->sql_build_array('INSERT', $album_data));
			$album_id = $db->sql_nextid();

			$phpbb_ext_gallery_user->update_data(array(
				'personal_album_id'	=> $album_id,
			));

			$this->subscribe_pegas($album_id);
			$phpbb_ext_gallery_config->inc('num_pegas', 1);

			// Update the config for the statistic on the index
			$phpbb_ext_gallery_config->set('newest_pega_user_id', $user->data['user_id']);
			$phpbb_ext_gallery_config->set('newest_pega_username', $user->data['username']);
			$phpbb_ext_gallery_config->set('newest_pega_user_colour', $user->data['user_colour']);
			$phpbb_ext_gallery_config->set('newest_pega_album_id', $album_id);

			$cache->destroy('_albums');
			$cache->destroy('sql', $albums_table);
			$cache->destroy('sql', $users_table);
			$phpbb_ext_gallery_core_auth->set_user_permissions('all', '');
		}
		redirect($this->u_action);

The function redirect was not found. Maybe you did not declare it correctly or list all dependencies?

	}

	function manage_albums()

It is generally recommended to explicitly declare the visibility for methods.

	{
		global $cache, $db, $template, $user, $phpbb_ext_gallery_core_album, $albums_table, $phpbb_ext_gallery_core_auth, $phpbb_ext_gallery_core_album_display;
		global $phpbb_container, $request, $phpbb_gallery_url, $phpbb_ext_gallery_user;

		$parent_id = $request->variable('parent_id', $phpbb_ext_gallery_user->get_data('personal_album_id'));
		$phpbb_ext_gallery_core_album->check_user($parent_id);
		$helper = $phpbb_container->get('controller.helper');
		$this->language = $phpbb_container->get('language');

		$sql = 'SELECT COUNT(album_id) albums
			FROM ' . $albums_table . '
			WHERE album_user_id = ' . (int) $user->data['user_id'];
		$result = $db->sql_query($sql);
		$albums = (int) $db->sql_fetchfield('albums');
		$db->sql_freeresult($result);

		$s_allowed_create = ($phpbb_ext_gallery_core_auth->acl_check('a_unlimited', $phpbb_ext_gallery_core_auth::OWN_ALBUM) || ($phpbb_ext_gallery_core_auth->acl_check('a_count', $phpbb_ext_gallery_core_auth::OWN_ALBUM) > $albums)) ? true : false;
		$template->assign_vars(array(
			'S_MANAGE_SUBALBUMS'			=> true,
			'U_CREATE_SUBALBUM'				=> ($s_allowed_create) ? ($this->u_action . '&action=create' . (($parent_id) ? '&parent_id=' . $parent_id : '')) : '',

			'L_TITLE'			=> $this->language->lang('MANAGE_SUBALBUMS'),
			//'ACP_GALLERY_TITLE_EXPLAIN'	=> $user->lang['ALBUM'],
		));

		if (!$parent_id)
		{
			$navigation = $this->language->lang('PERSONAL_ALBUM');
		}
		else
		{
			$navigation = $this->language->lang('PERSONAL_ALBUM');

			$albums_nav = $phpbb_ext_gallery_core_album_display->get_branch($user->data['user_id'], $parent_id, 'parents', 'descending');
			foreach ($albums_nav as $row)
			{
				if ($row['album_id'] == $parent_id)
				{
					$navigation .= ' » ' . $row['album_name'];
				}
				else
				{
					$navigation .= ' &raquo; <a href="' . $this->u_action . '&amp;action=manage&amp;parent_id=' . $row['album_id'] . '">' . $row['album_name'] . '</a>';
				}
			}
		}

		$album = array();
		$sql = 'SELECT *
			FROM ' . $albums_table . '
			WHERE parent_id = ' . (int) $parent_id . '
				AND album_user_id = ' . (int) $user->data['user_id'] . '
			ORDER BY left_id ASC';
		$result = $db->sql_query($sql);

		while ($row = $db->sql_fetchrow($result))
		{
			$album[] = $row;
		}
		$db->sql_freeresult($result);

		for ($i = 0, $end = count($album); $i < $end; $i++)
		{
			$folder_img = ($album[$i]['left_id'] + 1 != $album[$i]['right_id']) ? 'forum_read_subforum' : 'forum_read';
			$template->assign_block_vars('album_row', array(
				'FOLDER_IMAGE'			=> $user->img($folder_img, $album[$i]['album_name'], false, '', 'src'),
				'U_ALBUM'				=> $this->u_action . '&amp;action=manage&amp;parent_id=' . $album[$i]['album_id'],
				'ALBUM_NAME'			=> $album[$i]['album_name'],
				'ALBUM_DESCRIPTION'		=> generate_text_for_display($album[$i]['album_desc'], $album[$i]['album_desc_uid'], $album[$i]['album_desc_bitfield'], $album[$i]['album_desc_options']),

The function generate_text_for_display was not found. Maybe you did not declare it correctly or list all dependencies?

				'U_MOVE_UP'				=> $this->u_action . '&action=move&move=move_up&album_id=' . $album[$i]['album_id'],
				'U_MOVE_DOWN'			=> $this->u_action . '&action=move&move=move_down&album_id=' . $album[$i]['album_id'],
				'U_EDIT'				=> $this->u_action . '&action=edit&album_id=' . $album[$i]['album_id'],
				'U_DELETE'				=> $this->u_action . '&action=delete&album_id=' . $album[$i]['album_id'],
			));
		}

		$template->assign_vars(array(
			'NAVIGATION'		=> $navigation,
			'S_ALBUM'			=> $parent_id,
			'U_GOTO'			=> $helper->route('phpbbgallery_core_album', array('album_id' => $parent_id)),
			'U_EDIT'			=> $this->u_action . '&action=edit&album_id=' . $parent_id,
			'U_DELETE'			=> $this->u_action . '&action=delete&album_id=' . $parent_id,
			'U_UPLOAD'			=> $helper->route('phpbbgallery_core_album_upload', array('album_id' => $parent_id)),
			'ICON_MOVE_DOWN'			=> '<img src="' . $phpbb_gallery_url->path('images') . 'icon_down.gif" alt="" />',
			'ICON_MOVE_DOWN_DISABLED'	=> '<img src="' . $phpbb_gallery_url->path('images') . 'icon_down_disabled.gif" alt="" />',
			'ICON_MOVE_UP'				=> '<img src="' . $phpbb_gallery_url->path('images') . 'icon_up.gif" alt="" />',
			'ICON_MOVE_UP_DISABLED'		=> '<img src="' . $phpbb_gallery_url->path('images') . 'icon_up_disabled.gif" alt="" />',
			'ICON_EDIT'					=> '<img src="' . $phpbb_gallery_url->path('images') . 'icon_edit.gif" alt="" />',
			'ICON_DELETE'				=> '<img src="' . $phpbb_gallery_url->path('images') . 'icon_delete.gif" alt="" />',
		));
	}

	function create_album()

It is generally recommended to explicitly declare the visibility for methods.

	{
		global $cache, $db, $template, $user, $phpbb_gallery_url, $phpbb_ext_gallery_core_auth, $albums_table, $phpbb_ext_gallery_core_album, $request;
		global $phpbb_container, $phpbb_ext_gallery_user, $users_table;
		$phpbb_gallery_url->_include(array('bbcode', 'message_parser'), 'phpbb');
		$this->language = $phpbb_container->get('language');

		// Check if the user has already reached his limit
		if (!$phpbb_ext_gallery_core_auth->acl_check('i_upload', $phpbb_ext_gallery_core_auth::OWN_ALBUM))
		{
			trigger_error('NO_PERSALBUM_ALLOWED');
		}

		$sql = 'SELECT COUNT(album_id) albums
			FROM ' . $albums_table . '
			WHERE album_user_id = ' . (int) $user->data['user_id'];
		$result = $db->sql_query($sql);
		$albums = $db->sql_fetchfield('albums');
		$db->sql_freeresult($result);

		if (!$phpbb_ext_gallery_core_auth->acl_check('a_unlimited', $phpbb_ext_gallery_core_auth::OWN_ALBUM) && ($phpbb_ext_gallery_core_auth->acl_check('a_count', $phpbb_ext_gallery_core_auth::OWN_ALBUM) <= $albums))
		{
			trigger_error('NO_MORE_SUBALBUMS_ALLOWED');
		}

		$submit = (isset($_POST['submit'])) ? true : false;
		$redirect = $request->variable('redirect', '');

		if (!$submit)
		{
			$parent_id = $request->variable('parent_id', 0);
			$phpbb_ext_gallery_core_album->check_user($parent_id);
			$parents_list = $phpbb_ext_gallery_core_album->get_albumbox(false, '', $parent_id, false, false, $user->data['user_id']);

			$s_access_options = '';
			if ($phpbb_ext_gallery_core_auth->acl_check('a_restrict', $phpbb_ext_gallery_core_auth::OWN_ALBUM))
			{
				$access_options = array(
					$phpbb_ext_gallery_core_auth::ACCESS_ALL			=> 'ALL',
					$phpbb_ext_gallery_core_auth::ACCESS_REGISTERED	=> 'REGISTERED',
					$phpbb_ext_gallery_core_auth::ACCESS_NOT_FOES		=> 'NOT_FOES',
					$phpbb_ext_gallery_core_auth::ACCESS_FRIENDS		=> 'FRIENDS',
				);
				foreach ($access_options as $value => $lang_key)
				{
					$s_access_options .= '<option value="' . $value . '">' . $this->language->lang('ACCESS_CONTROL_' . $lang_key) . '</option>';
				}
			}

			$template->assign_vars(array(
				'S_CREATE_SUBALBUM'		=> true,
				'S_UCP_ACTION'			=> $this->u_action . '&amp;action=create' . (($redirect != '') ? '&amp;redirect=album' : ''),
				'L_TITLE'				=> $this->language->lang('CREATE_SUBALBUM'),
				'L_TITLE_EXPLAIN'		=> $this->language->lang('CREATE_SUBALBUM_EXP'),

				'S_DESC_BBCODE_CHECKED'		=> true,
				'S_DESC_SMILIES_CHECKED'	=> true,
				'S_DESC_URLS_CHECKED'		=> true,
				'S_PARENT_OPTIONS'			=> '<option value="' . $phpbb_ext_gallery_user->get_data('personal_album_id') . '">' . $this->language->lang('NO_PARENT_ALBUM') . '</option>' . $parents_list,

				'S_AUTH_ACCESS_OPTIONS'		=> $s_access_options,
				'L_ALBUM_ACCESS_EXPLAIN'	=> $this->language->lang('ALBUM_ACCESS_EXPLAIN', '<a href="' . $phpbb_gallery_url->append_sid('phpbb', 'faq') . '#f6r0">', '</a>'),
			));
		}
		else
		{
			if (!check_form_key('ucp_gallery'))

The function check_form_key was not found. Maybe you did not declare it correctly or list all dependencies?

			{
				trigger_error('FORM_INVALID');
			}

			// Create the subalbum
			$album_data = array(
				'album_name'					=> $request->variable('album_name', '', true),
				'parent_id'						=> $request->variable('parent_id', 0),
				'album_parents'					=> '',
				'album_type'					=> (int) \phpbbgallery\core\block::TYPE_UPLOAD,
				'album_status'					=> (int) \phpbbgallery\core\block::ALBUM_OPEN,
				'album_desc_options'			=> 7,
				'album_desc'					=> utf8_normalize_nfc($request->variable('album_desc', '', true)),

The function utf8_normalize_nfc was not found. Maybe you did not declare it correctly or list all dependencies?

				'album_user_id'					=> $user->data['user_id'],
				'album_last_username'			=> '',
				'album_auth_access'				=> ($phpbb_ext_gallery_core_auth->acl_check('a_restrict', $phpbb_ext_gallery_core_auth::OWN_ALBUM)) ? $request->variable('album_auth_access', 0) : 0,
			);

			$album_data['album_auth_access'] = min(3, max(0, $album_data['album_auth_access']));

			if (!$album_data['album_name'])
			{
				trigger_error('MISSING_ALBUM_NAME');
			}
			$album_data['parent_id'] = ($album_data['parent_id']) ? $album_data['parent_id'] : $phpbb_ext_gallery_user->get_data('personal_album_id');
			generate_text_for_storage($album_data['album_desc'], $album_data['album_desc_uid'], $album_data['album_desc_bitfield'], $album_data['album_desc_options'], $request->variable('desc_parse_bbcode', false), $request->variable('desc_parse_urls', false), $request->variable('desc_parse_smilies', false));

The function generate_text_for_storage was not found. Maybe you did not declare it correctly or list all dependencies?

			/**
			* borrowed from phpBB3
			* @author: phpBB Group
			* @location: acp_forums->manage_forums
			*/
			// Parent should always be filled otherwise we use initialise_album()
			if ($album_data['parent_id'])
			{
				$sql = 'SELECT left_id, right_id, album_type
					FROM ' . $albums_table . '
					WHERE album_id = ' . (int) $album_data['parent_id'];
				$result = $db->sql_query($sql);
				$row = $db->sql_fetchrow($result);
				$db->sql_freeresult($result);

				if (!$row)
				{
					trigger_error('PARENT_NOT_EXIST', E_USER_WARNING);
				}

				$sql = 'UPDATE ' . $albums_table . '
					SET left_id = left_id + 2, right_id = right_id + 2
					WHERE left_id > ' . (int) $row['right_id'] . '
						AND album_user_id = ' . (int) $album_data['album_user_id'];
				$db->sql_query($sql);

				$sql = 'UPDATE ' . $albums_table . '
					SET right_id = right_id + 2
					WHERE ' . $row['left_id'] . ' BETWEEN left_id AND right_id
						AND album_user_id = ' . $album_data['album_user_id'];
				$db->sql_query($sql);

				$album_data['left_id'] = $row['right_id'];
				$album_data['right_id'] = $row['right_id'] + 1;
			}
			$db->sql_query('INSERT INTO ' . $albums_table . ' ' . $db->sql_build_array('INSERT', $album_data));
			$redirect_album_id = $db->sql_nextid();

			$this->subscribe_pegas($redirect_album_id);

			$cache->destroy('_albums');
			$cache->destroy('sql', $albums_table);
			$cache->destroy('sql', $users_table);
			$phpbb_ext_gallery_core_auth->set_user_permissions('all', '');

			trigger_error($this->language->lang('CREATED_SUBALBUM') . '<br /><br />
				<a href="' . (($redirect) ? $phpbb_gallery_url->append_sid('album', "album_id=$redirect_album_id") : $phpbb_gallery_url->append_sid('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&amp;mode=manage_albums&amp;action=manage&amp;parent_id=' . (($album_data['parent_id']) ? $album_data['parent_id'] : $phpbb_ext_gallery_user->get_data('personal_album_id')))) . '">' . $user->lang('BACK_TO_PREV') . '</a>');
		}
	}

	function edit_album()

It is generally recommended to explicitly declare the visibility for methods.

	{
		global $config, $cache, $db, $template, $user, $phpbb_gallery_url, $phpbb_ext_gallery_core_album, $phpbb_ext_gallery_core_auth, $albums_table, $phpbb_ext_gallery_core_album_display;
		global $request, $phpbb_container, $phpbb_ext_gallery_user, $users_table;

		$this->language = $phpbb_container->get('language');

		$phpbb_gallery_url->_include(array('bbcode','message_parser'), 'phpbb');

		$album_id = $request->variable('album_id', 0);
		$phpbb_ext_gallery_core_album->check_user($album_id);

		$submit = (isset($_POST['submit'])) ? true : false;
		$redirect = $request->variable('redirect', '');
		if (!$submit)
		{
			$album_data = $phpbb_ext_gallery_core_album->get_info($album_id);
			$album_desc_data = generate_text_for_edit($album_data['album_desc'], $album_data['album_desc_uid'], $album_data['album_desc_options']);

The function generate_text_for_edit was not found. Maybe you did not declare it correctly or list all dependencies?

			// Make sure no direct child forums are able to be selected as parents.
			$exclude_albums = array($album_id);
			foreach ($phpbb_ext_gallery_core_album_display->get_branch($album_data['album_user_id'], $album_id, 'children') as $row)
			{
				$exclude_albums[] = (int) $row['album_id'];
			}

			$parents_list = $phpbb_ext_gallery_core_album->get_albumbox(false, '', $album_data['parent_id'], false, $exclude_albums, $user->data['user_id']);

			$s_access_options = '';
			if ($phpbb_ext_gallery_core_auth->acl_check('a_restrict', $phpbb_ext_gallery_core_auth::OWN_ALBUM) && $album_data['parent_id'])
			{
				$access_options = array(
					$phpbb_ext_gallery_core_auth::ACCESS_ALL			=> 'ALL',
					$phpbb_ext_gallery_core_auth::ACCESS_REGISTERED	=> 'REGISTERED',
					$phpbb_ext_gallery_core_auth::ACCESS_NOT_FOES		=> 'NOT_FOES',
					$phpbb_ext_gallery_core_auth::ACCESS_FRIENDS		=> 'FRIENDS',
				);
				if (isset($config['zebra_enhance_version']))
				{
					$access_options[$phpbb_ext_gallery_core_auth::ACCESS_SPECIAL_FRIENDS] = 'SPECIAL_FRIENDS';
				}
				foreach ($access_options as $value => $lang_key)
				{
					$s_access_options .= '<option value="' . $value . (($value == $album_data['album_auth_access']) ? '" selected="selected' : '') . '">' . $this->language->lang('ACCESS_CONTROL_' . $lang_key) . '</option>';
				}
			}

			$template->assign_vars(array(
				'S_EDIT_SUBALBUM'			=> true,
				'S_PERSONAL_ALBUM'			=> ($album_id == $phpbb_ext_gallery_user->get_data('personal_album_id')) ? true : false,
				'S_AUTH_ACCESS_OPTIONS'		=> $s_access_options,
				'L_ALBUM_ACCESS_EXPLAIN'	=> $this->language->lang('ALBUM_ACCESS_EXPLAIN', '<a href="' . $phpbb_gallery_url->append_sid('phpbb', 'faq') . '#f6r0">', '</a>'),

				'L_TITLE'					=> $this->language->lang('EDIT_SUBALBUM'),
				'L_TITLE_EXPLAIN'			=> $this->language->lang('EDIT_SUBALBUM_EXP'),

				'S_ALBUM_ACTION' 			=> $this->u_action . '&amp;action=edit&amp;album_id=' . $album_id . (($redirect != '') ? '&amp;redirect=album' : ''),
				'S_PARENT_OPTIONS'			=> '<option value="' . $phpbb_ext_gallery_user->get_data('personal_album_id') . '">' . $this->language->lang('NO_PARENT_ALBUM') . '</option>' . $parents_list,

				'ALBUM_NAME' 				=> $album_data['album_name'],
				'ALBUM_DESC'				=> $album_desc_data['text'],
				'ALBUM_TYPE'				=> $album_data['album_type'],
				'S_DESC_BBCODE_CHECKED'		=> ($album_desc_data['allow_bbcode']) ? true : false,
				'S_DESC_SMILIES_CHECKED'	=> ($album_desc_data['allow_smilies']) ? true : false,
				'S_DESC_URLS_CHECKED'		=> ($album_desc_data['allow_urls']) ? true : false,

				'S_MODE' 					=> 'edit',
			));
		}
		else
		{
			// Is it salty ?
			if (!check_form_key('ucp_gallery'))

The function check_form_key was not found. Maybe you did not declare it correctly or list all dependencies?

			{
				trigger_error('FORM_INVALID');
			}

			$album_data = array(
				'album_name'					=> ($album_id == $phpbb_ext_gallery_user->get_data('personal_album_id')) ? $user->data['username'] : $request->variable('album_name', '', true),
				'parent_id'						=> $request->variable('parent_id', (($album_id == $phpbb_ext_gallery_user->get_data('personal_album_id')) ? 0 : $phpbb_ext_gallery_user->get_data('personal_album_id'))),
				//left_id and right_id are created some lines later
				'album_parents'					=> '',
				'album_type'					=> (int) \phpbbgallery\core\block::TYPE_UPLOAD,
				'album_desc_options'			=> 7,
				'album_desc'					=> utf8_normalize_nfc($request->variable('album_desc', '', true)),

The function utf8_normalize_nfc was not found. Maybe you did not declare it correctly or list all dependencies?

				'album_auth_access'				=> ($phpbb_ext_gallery_core_auth->acl_check('a_restrict', $phpbb_ext_gallery_core_auth::OWN_ALBUM)) ? $request->variable('album_auth_access', 0) : 0,
			);

			generate_text_for_storage($album_data['album_desc'], $album_data['album_desc_uid'], $album_data['album_desc_bitfield'], $album_data['album_desc_options'], $request->variable('desc_parse_bbcode', false), $request->variable('desc_parse_urls', false), $request->variable('desc_parse_smilies', false));

The function generate_text_for_storage was not found. Maybe you did not declare it correctly or list all dependencies?

			$row = $phpbb_ext_gallery_core_album->get_info($album_id);
			$parent_id = (int) $album_data['parent_id'];
			if (!$row['parent_id'])
			{
				// do not allow to restrict access on the base-album
				$album_data['album_auth_access'] = 0;
			}

			// Ensure that no child is selected as parent
			$exclude_albums = array($album_id);
			foreach ($phpbb_ext_gallery_core_album_display->get_branch($row['album_user_id'], $album_id, 'children') as $loop)
			{
				$exclude_albums[] = (int) $loop['album_id'];
			}
			if (in_array($parent_id, $exclude_albums))
			{
				$parent_id = (int) $row['parent_id'];
			}

			// If the parent is different, the left_id and right_id have changed.
			if ($row['parent_id'] != $parent_id)
			{
				if ($parent_id > 0)
				{
					// Get the parent album now, so it throws an error when it does not exist, before we change the database.
					$parent = $phpbb_ext_gallery_core_album->get_info($parent_id);

The assignment to $parent is dead and can be removed.

				}

				// How many do we have to move and how far.
				$moving_ids = ($row['right_id'] - $row['left_id']) + 1;
				$sql = 'SELECT MAX(right_id) right_id
					FROM ' . $albums_table . '
					WHERE album_user_id = ' . (int) $row['album_user_id'];
				$result = $db->sql_query($sql);
				$moving_distance = ($db->sql_fetchfield('right_id') - $row['left_id']) + 1;
				$db->sql_freeresult($result);

				$stop_updating = $moving_distance + $row['left_id'];

				// Update the moving albums... move them to the end.
				$sql = 'UPDATE ' . $albums_table . '
					SET right_id = right_id + ' . $moving_distance . ',
						left_id = left_id + ' . $moving_distance . '
					WHERE album_user_id = ' . (int) $row['album_user_id'] . '
						AND left_id >= ' . (int) $row['left_id'] . '
						AND right_id <= ' . (int) $row['right_id'];
				$db->sql_query($sql);

				$new['left_id'] = $row['left_id'] + $moving_distance;

$new was never initialized. Although not strictly required by PHP, it is generally a good practice to add $new = array(); before regardless.

				$new['right_id'] = $row['right_id'] + $moving_distance;

				// Close the gap, we produced through moving.
				if ($parent_id == 0)
				{
					$sql = 'UPDATE ' . $albums_table . '
						SET left_id = left_id - ' . $moving_ids . '
						WHERE album_user_id = ' . (int) $row['album_user_id'] . '
							AND left_id >= ' . (int) $row['left_id'];
					$db->sql_query($sql);

					$sql = 'UPDATE ' . $albums_table . '
						SET right_id = right_id - ' . $moving_ids . '
						WHERE album_user_id = ' . (int) $row['album_user_id'] . '
							AND right_id >= ' . (int) $row['left_id'];
					$db->sql_query($sql);
				}
				else
				{
					$sql = 'UPDATE ' . $albums_table . '
						SET left_id = left_id - ' . $moving_ids . '
						WHERE album_user_id = ' . (int) $row['album_user_id'] . '
							AND left_id >= ' . (int) $row['left_id'] . '
							AND right_id <= ' . (int) $stop_updating;
					$db->sql_query($sql);

					$sql = 'UPDATE ' . $albums_table . '
						SET right_id = right_id - ' . $moving_ids . '
						WHERE album_user_id = ' . (int) $row['album_user_id'] . '
							AND right_id >= ' . (int) $row['left_id'] . '
							AND right_id <= ' . (int) $stop_updating;
					$db->sql_query($sql);

					// We should get new parent again for the case if it has been changed
					$parent = $phpbb_ext_gallery_core_album->get_info($parent_id);

					$sql = 'UPDATE ' . $albums_table . '
						SET left_id = left_id + ' . $moving_ids . '
						WHERE album_user_id = ' . (int) $row['album_user_id'] . '
							AND left_id >= ' . (int) $parent['right_id'] . '
							AND right_id <= ' . (int) $stop_updating;
					$db->sql_query($sql);

					$sql = 'UPDATE ' . $albums_table . '
						SET right_id = right_id + ' . $moving_ids . '
						WHERE album_user_id = ' . (int) $row['album_user_id'] . '
							AND right_id >= ' . (int) $parent['right_id'] . '
							AND right_id <= ' . (int) $stop_updating;
					$db->sql_query($sql);

					// We should get new parent again for the case if it has been changed
					$parent = $phpbb_ext_gallery_core_album->get_info($parent_id);

					// Move the albums to the suggested gap.
					$move_back = ($new['right_id'] - $parent['right_id']) + 1;
					$sql = 'UPDATE ' . $albums_table . '
						SET left_id = left_id - ' . $move_back . ',
							right_id = right_id - ' . $move_back . '
						WHERE album_user_id = ' . (int) $row['album_user_id'] . '
							AND left_id >= ' . (int) $stop_updating;
					$db->sql_query($sql);
				}
			}

			// The album name has changed, clear the parents list of all albums.
			if ($album_data['album_name'] == '')
			{
				$album_data['album_name'] = $row['album_name'];
			}
			else if ($row['album_name'] != $album_data['album_name'])
			{
				$sql = 'UPDATE ' . $albums_table . "
					SET album_parents = ''";
				$db->sql_query($sql);
			}

			// The album access has changed, clear the permissions of all users.
			if (isset($config['zebra_enhance_version']))
			{
				$album_data['album_auth_access'] = min(4, max(0, $album_data['album_auth_access']));
			}
			else
			{
				$album_data['album_auth_access'] = min(3, max(0, $album_data['album_auth_access']));
			}
			if ($row['album_auth_access'] != $album_data['album_auth_access'])
			{
				$phpbb_ext_gallery_core_auth->set_user_permissions('all', '');
			}

			$sql = 'UPDATE ' . $albums_table . ' 
					SET ' . $db->sql_build_array('UPDATE', $album_data) . '
					WHERE album_id  = ' . (int) $album_id;
			$db->sql_query($sql);

			$cache->destroy('sql', $albums_table);
			$cache->destroy('sql', $users_table);
			$cache->destroy('_albums');

			trigger_error($this->language->lang('EDITED_SUBALBUM') . '<br /><br />
				<a href="' . (($redirect) ? $phpbb_gallery_url->append_sid('album', "album_id=$album_id") : $phpbb_gallery_url->append_sid('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&amp;mode=manage_albums&amp;action=manage&amp;parent_id=' . (($album_data['parent_id']) ? $album_data['parent_id'] : $phpbb_ext_gallery_user->get_data('personal_album_id')))) . '">' . $this->language->lang('BACK_TO_PREV') . '</a>');
		}
	}

	function delete_album()

It is generally recommended to explicitly declare the visibility for methods.

	{
		global $cache, $db, $template, $user, $phpbb_gallery_url, $phpbb_ext_gallery_core_album, $albums_table, $phpbb_container;
		global $images_table, $phpbb_gallery_image, $phpbb_ext_gallery_config, $phpbb_dispatcher, $request, $users_table;
		global $comments_table, $images_table, $rates_table, $reports_table, $watch_table, $phpbb_ext_gallery_core_auth, $phpbb_ext_gallery_user;

		$this->language = $phpbb_container->get('language');

		$s_hidden_fields = build_hidden_fields(array(

The function build_hidden_fields was not found. Maybe you did not declare it correctly or list all dependencies?

			'album_id'		=> $request->variable('album_id', 0),
		));

		if (confirm_box(true))

The function confirm_box was not found. Maybe you did not declare it correctly or list all dependencies?

		{
			$album_id = $request->variable('album_id', 0);
			$left_id = $right_id = 0;
			$deleted_images_na = '';
			$deleted_albums = array();

			// Check for owner
			$sql = 'SELECT album_id, left_id, right_id, parent_id
				FROM ' . $albums_table . '
				WHERE album_user_id = ' . (int) $user->data['user_id'] . '
				ORDER BY left_id ASC';
			$result = $db->sql_query($sql);

			while ($row = $db->sql_fetchrow($result))
			{
				$album[] = $row;
				if ($row['album_id'] == $album_id)
				{
					$left_id = $row['left_id'];
					$right_id = $row['right_id'];
					$parent_id = $row['parent_id'];
				}
			}
			$db->sql_freeresult($result);

			for ($i = 0, $end = count($album); $i < $end; $i++)

The variable $album does not seem to be defined for all execution paths leading up to this point.

			{
				if (($left_id <= $album[$i]['left_id']) && ($album[$i]['left_id'] <= $right_id))
				{
					$deleted_albums[] = $album[$i]['album_id'];
				}
			}

			// $deleted_albums is the array of albums we are going to delete.
			// Now get the images in $deleted_images
			$sql = 'SELECT image_id, image_filename
				FROM ' . $images_table . '
				WHERE ' . $db->sql_in_set('image_album_id', $deleted_albums) . '
				ORDER BY image_id ASC';
			$result = $db->sql_query($sql);

			$deleted_images = $filenames = array();
			while ($row = $db->sql_fetchrow($result))
			{
				$deleted_images[] = $row['image_id'];
				$filenames[(int) $row['image_id']] = $row['image_filename'];
			}

			// We have all image_ids in $deleted_images which are deleted.
			// Aswell as the album_ids in $deleted_albums.
			// So now drop the comments, ratings, images and albums.
			if (!empty($deleted_images))
			{
				$phpbb_gallery_image->delete_images($deleted_images, $filenames);
			}

			$sql = 'DELETE FROM ' . $albums_table . '
				WHERE ' . $db->sql_in_set('album_id', $deleted_albums);
			$db->sql_query($sql);

			// Make sure the overall image & comment count is correct...
			$sql = 'SELECT COUNT(image_id) AS num_images, SUM(image_comments) AS num_comments
				FROM ' . $images_table . '
				WHERE image_status <> ' . (int) \phpbbgallery\core\block::STATUS_UNAPPROVED . '
					AND image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN;
			$result = $db->sql_query($sql);
			$row = $db->sql_fetchrow($result);
			$db->sql_freeresult($result);

			$phpbb_ext_gallery_config->set('num_images', $row['num_images']);
			$phpbb_ext_gallery_config->set('num_comments', (int) $row['num_comments']);

			$num_images = sizeof($deleted_images);
			if ($num_images)
			{
				// TODO
				//$phpbb_gallery_hookup->add_image($user->data['user_id'], 0 - $num_images);
				$phpbb_ext_gallery_user->update_images((0 - $num_images));
			}

			// Maybe we deleted all, so we have to empty phpbb_gallery::$user->get_data('personal_album_id')
			if (in_array($phpbb_ext_gallery_user->get_data('personal_album_id'), $deleted_albums))
			{
				$phpbb_ext_gallery_user->update_data(array(
					'personal_album_id'		=> 0,
				));

				$phpbb_ext_gallery_config->dec('num_pegas', 1);

				if ($phpbb_ext_gallery_config->get('newest_pega_album_id') == $phpbb_ext_gallery_user->get_data('personal_album_id'))
				{
					// Update the config for the statistic on the index
					if ($phpbb_ext_gallery_config->get('num_pegas') > 0)
					{
						$sql_array = array(
							'SELECT'		=> 'a.album_id, u.user_id, u.username, u.user_colour',
							'FROM'			=> array($albums_table => 'a'),

							'LEFT_JOIN'		=> array(
								array(
									'FROM'		=> array(USERS_TABLE => 'u'),

The constant phpbbgallery\core\ucp\USERS_TABLE was not found. Maybe you did not declare it correctly or list all dependencies?

									'ON'		=> 'u.user_id = a.album_user_id',
								),
							),

							'WHERE'			=> 'a.album_user_id <> ' . (int) \phpbbgallery\core\block::PUBLIC_ALBUM . ' AND a.parent_id = 0',
							'ORDER_BY'		=> 'a.album_id DESC',
						);
						$sql = $db->sql_build_query('SELECT', $sql_array);
						$result = $db->sql_query_limit($sql, 1);
						$newest_pgallery = $db->sql_fetchrow($result);
						$db->sql_freeresult($result);

						$phpbb_ext_gallery_config->set('newest_pega_user_id', $newest_pgallery['user_id']);
						$phpbb_ext_gallery_config->set('newest_pega_username', $newest_pgallery['username']);
						$phpbb_ext_gallery_config->set('newest_pega_user_colour', $newest_pgallery['user_colour']);
						$phpbb_ext_gallery_config->set('newest_pega_album_id', $newest_pgallery['album_id']);
					}
					else
					{
						$phpbb_ext_gallery_config->set('newest_pega_user_id', 0);
						$phpbb_ext_gallery_config->set('newest_pega_username', '');
						$phpbb_ext_gallery_config->set('newest_pega_user_colour', '');
						$phpbb_ext_gallery_config->set('newest_pega_album_id', 0);
					}
				}
			}
			else
			{
				// Solve the left_id right_id problem
				$delete_id = $right_id - ($left_id - 1);

				$sql = 'UPDATE ' . $albums_table . "
					SET left_id = left_id - $delete_id
					WHERE left_id > $left_id
						AND album_user_id = " . (int) $user->data['user_id'];
				$db->sql_query($sql);

				$sql = 'UPDATE ' . $albums_table . "
					SET right_id = right_id - $delete_id
					WHERE right_id > $right_id
						AND album_user_id = ". (int) $user->data['user_id'];
				$db->sql_query($sql);
			}

			/**
			* Event delete user albums
			*
			* @event phpbbgallery.core.ucp.delete_album
			* @var	int		album_id			Album ID
			* @var	array	deleted_albums		Deleted album IDs
			* @since 1.2.0
			*/
			$vars = array('album_id', 'deleted_albums');
			extract($phpbb_dispatcher->trigger_event('phpbbgallery.core.ucp.delete_album', compact($vars)));

			$cache->destroy('sql', $albums_table);
			$cache->destroy('sql', $comments_table);
			$cache->destroy('sql', $images_table);
			$cache->destroy('sql', $rates_table);
			$cache->destroy('sql', $reports_table);
			$cache->destroy('sql', $watch_table);
			$cache->destroy('sql', $users_table);
			$cache->destroy('_albums');
			$phpbb_ext_gallery_core_auth->set_user_permissions('all', '');

			trigger_error($this->language->lang('DELETED_ALBUMS') . '<br /><br />
				<a href="' . (($parent_id) ? $phpbb_gallery_url->append_sid('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&amp;mode=manage_albums&amp;action=manage&amp;parent_id=' . $parent_id) : $phpbb_gallery_url->append_sid('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&amp;mode=manage_albums')) . '">' . $this->language->lang('BACK_TO_PREV') . '</a>');
		}
		else
		{
			$album_id = $request->variable('album_id', 0);
			$phpbb_ext_gallery_core_album->check_user($album_id);
			confirm_box(false, 'DELETE_ALBUM', $s_hidden_fields);
		}
	}

	function move_album()

It is generally recommended to explicitly declare the visibility for methods.

	{
		global $cache, $db, $user, $phpbb_ext_gallery_core_album, $albums_table, $request, $phpbb_gallery_url, $users_table;

		$album_id = $request->variable('album_id', 0);
		$phpbb_ext_gallery_core_album->check_user($album_id);

		$move = $request->variable('move', '', true);
		$moving = $phpbb_ext_gallery_core_album->get_info($album_id);

		$sql = 'SELECT album_id, left_id, right_id
			FROM ' . $albums_table . "
			WHERE parent_id = {$moving['parent_id']}
				AND album_user_id = {$user->data['user_id']}
				AND " . (($move == 'move_up') ? "right_id < {$moving['right_id']} ORDER BY right_id DESC" : "left_id > {$moving['left_id']} ORDER BY left_id ASC");
		$result = $db->sql_query_limit($sql, 1);
		$target = $db->sql_fetchrow($result);
		$db->sql_freeresult($result);

		if (!sizeof($target))
		{
			// The album is already on top or bottom
			return false;
		}

		if ($move == 'move_up')
		{
			$left_id = $target['left_id'];
			$right_id = $moving['right_id'];

			$diff_up = $moving['left_id'] - $target['left_id'];
			$diff_down = $moving['right_id'] + 1 - $moving['left_id'];

			$move_up_left = $moving['left_id'];
			$move_up_right = $moving['right_id'];
		}
		else
		{
			$left_id = $moving['left_id'];
			$right_id = $target['right_id'];

			$diff_up = $moving['right_id'] + 1 - $moving['left_id'];
			$diff_down = $target['right_id'] - $moving['right_id'];

			$move_up_left = $moving['right_id'] + 1;
			$move_up_right = $target['right_id'];
		}

		// Now do the dirty job
		$sql = 'UPDATE ' . $albums_table . "
			SET left_id = left_id + CASE
				WHEN left_id BETWEEN {$move_up_left} AND {$move_up_right} THEN -{$diff_up}
				ELSE {$diff_down}
			END,
			right_id = right_id + CASE
				WHEN right_id BETWEEN {$move_up_left} AND {$move_up_right} THEN -{$diff_up}
				ELSE {$diff_down}
			END,
			album_parents = ''
			WHERE
				left_id BETWEEN {$left_id} AND {$right_id}
				AND right_id BETWEEN {$left_id} AND {$right_id}
				AND album_user_id = {$user->data['user_id']}";
		$db->sql_query($sql);

		$cache->destroy('sql', $albums_table);
		$cache->destroy('sql', $users_table);
		$cache->destroy('_albums');
		$phpbb_gallery_url->redirect('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&amp;mode=manage_albums&amp;action=manage&amp;parent_id=' . $moving['parent_id']);
	}

	function manage_subscriptions()

It is generally recommended to explicitly declare the visibility for methods.

	{
		global $db, $template, $user, $phpbb_container, $phpbb_ext_gallery_core_album, $phpbb_gallery_notification, $watch_table, $albums_table, $contests_table;
		global $images_table, $comments_table, $request, $phpbb_gallery_url, $phpbb_ext_gallery_core_auth;

		$phpbb_ext_gallery_core_image = $phpbb_container->get('phpbbgallery.core.image');
		$phpbb_ext_gallery_config = $phpbb_container->get('phpbbgallery.core.config');
		$phpbb_gallery_notification = $phpbb_container->get('phpbbgallery.core.notification');
		$this->language = $phpbb_container->get('language');

		$action = $request->variable('action', '');
		$image_id_ary = $request->variable('image_id_ary', array(0));
		$album_id_ary = $request->variable('album_id_ary', array(0));
		if (($image_id_ary || $album_id_ary) && ($action == 'unsubscribe'))
		{
			if ($album_id_ary)
			{
				$phpbb_gallery_notification->remove_albums($album_id_ary);
			}
			if ($image_id_ary)
			{
				$phpbb_gallery_notification->remove($image_id_ary);
			}

			meta_refresh(3, $this->u_action);

The function meta_refresh was not found. Maybe you did not declare it correctly or list all dependencies?

			$message = '';
			if ($album_id_ary)
			{
				$message .= $this->language->lang('UNWATCHED_ALBUMS') . '<br />';
			}
			if ($image_id_ary)
			{
				$message .= $this->language->lang('UNWATCHED_IMAGES') . '<br />';
			}
			$message .= '<br />' . sprintf($this->language->lang('RETURN_UCP'), '<a href="' . $this->u_action . '">', '</a>');
			trigger_error($message);
		}

		// Subscribed albums
		$sql_array = array(
			'SELECT'		=> '*',
			'FROM'			=> array($watch_table => 'w'),

			'LEFT_JOIN'		=> array(
				array(
					'FROM'		=> array($albums_table => 'a'),
					'ON'		=> 'w.album_id = a.album_id',
				),
				array(
					'FROM'		=> array($contests_table => 'c'),
					'ON'		=> 'a.album_id = c.contest_album_id',
				),
			),

			'WHERE'			=> 'w.album_id <> 0 AND w.user_id = ' . (int) $user->data['user_id'],
		);
		$sql = $db->sql_build_query('SELECT', $sql_array);
		$result = $db->sql_query($sql);
		while ($row = $db->sql_fetchrow($result))
		{
			$template->assign_block_vars('album_row', array(
				'ALBUM_ID'			=> $row['album_id'],
				'ALBUM_NAME'		=> $row['album_name'],
				'U_VIEW_ALBUM'		=> $phpbb_gallery_url->show_album($row['album_id']),
				'ALBUM_DESC'		=> generate_text_for_display($row['album_desc'], $row['album_desc_uid'], $row['album_desc_bitfield'], $row['album_desc_options']),

The function generate_text_for_display was not found. Maybe you did not declare it correctly or list all dependencies?

				'UC_IMAGE_NAME'		=> $phpbb_ext_gallery_core_image->generate_link('image_name', $phpbb_ext_gallery_config->get('link_image_name'), $row['album_last_image_id'], $row['album_last_image_name'], $row['album_id']),
				'UC_FAKE_THUMBNAIL'	=> $phpbb_ext_gallery_core_image->generate_link('fake_thumbnail', $phpbb_ext_gallery_config->get('link_thumbnail'), $row['album_last_image_id'], $row['album_last_image_name'], $row['album_id']),
				'UPLOADER'			=> (($row['album_type'] == (int) \phpbbgallery\core\block::TYPE_CONTEST) && ($row['contest_marked'] && !$phpbb_ext_gallery_core_auth->acl_check('m_status', $row['album_id'], $row['album_user_id']))) ? $this->language->lang('CONTEST_USERNAME') : get_username_string('full', $row['album_last_user_id'], $row['album_last_username'], $row['album_last_user_colour']),

The function get_username_string was not found. Maybe you did not declare it correctly or list all dependencies?

				'LAST_IMAGE_TIME'	=> $user->format_date($row['album_last_image_time']),
				'LAST_IMAGE'		=> $row['album_last_image_id'],
				'U_IMAGE'			=> $phpbb_gallery_url->show_image($row['image_id']),
			));
		}
		$db->sql_freeresult($result);

		// Subscribed images
		$start				= $request->variable('start', 0);
		$images_per_page	= $phpbb_ext_gallery_config->get('items_per_page');
		$total_images		= 0;

The assignment to $total_images is dead and can be removed.

		$sql = 'SELECT COUNT(image_id) as images
			FROM ' . $watch_table . '
			WHERE image_id <> 0
				AND user_id = ' . (int) $user->data['user_id'];
		$result = $db->sql_query($sql);
		$total_images = (int) $db->sql_fetchfield('images');
		$db->sql_freeresult($result);

		$sql_array = array(
			'SELECT'		=> 'w.*, i.*, a.album_name, c.*',
			'FROM'			=> array($watch_table => 'w'),

			'LEFT_JOIN'		=> array(
				array(
					'FROM'		=> array($images_table => 'i'),
					'ON'		=> 'w.image_id = i.image_id',
				),
				array(
					'FROM'		=> array($albums_table => 'a'),
					'ON'		=> 'a.album_id = i.image_album_id',
				),
				array(
					'FROM'		=> array($comments_table => 'c'),
					'ON'		=> 'i.image_last_comment = c.comment_id',
				),
			),

			'WHERE'			=> 'w.image_id <> 0 AND w.user_id = ' . (int) $user->data['user_id'],
		);
		$sql = $db->sql_build_query('SELECT', $sql_array);
		$result = $db->sql_query($sql, $images_per_page, $start);
		while ($row = $db->sql_fetchrow($result))
		{
			$template->assign_block_vars('image_row', array(
				'UPLOADER'			=> ($row['image_contest'] && !$phpbb_ext_gallery_core_auth->acl_check('m_status', $row['image_album_id'])) ? $this->language->lang('CONTEST_USERNAME') : get_username_string('full', $row['image_user_id'], $row['image_username'], $row['image_user_colour']),
				'LAST_COMMENT_BY'	=> get_username_string('full', $row['comment_user_id'], $row['comment_username'], $row['comment_user_colour']),
				'COMMENT'			=> $row['image_comments'],
				'LAST_COMMENT_TIME'	=> $user->format_date($row['comment_time']),
				'IMAGE_TIME'		=> $user->format_date($row['image_time']),
				'UC_IMAGE_NAME'		=> $phpbb_ext_gallery_core_image->generate_link('image_name', $phpbb_ext_gallery_config->get('link_image_name'), $row['image_id'], $row['image_name'], $row['album_id']),
				'UC_FAKE_THUMBNAIL'	=> $phpbb_ext_gallery_core_image->generate_link('fake_thumbnail', $phpbb_ext_gallery_config->get('link_thumbnail'), $row['image_id'], $row['image_name'], $row['album_id']),
				'ALBUM_NAME'		=> $row['album_name'],
				'IMAGE_ID'			=> $row['image_id'],
				'U_VIEW_ALBUM'		=> $phpbb_gallery_url->show_album($row['image_album_id']),
				'U_IMAGE'			=> $phpbb_gallery_url->show_image($row['image_id']),
			));
		}
		$db->sql_freeresult($result);

		$template->assign_vars(array(
			'S_MANAGE_SUBSCRIPTIONS'	=> true,
			'S_UCP_ACTION'				=> $this->u_action,

			'L_TITLE'					=> $this->language->lang('UCP_GALLERY_WATCH'),
			'L_TITLE_EXPLAIN'			=> $this->language->lang('YOUR_SUBSCRIPTIONS'),

			//'PAGINATION'				=> generate_pagination($phpbb_ext_gallery->url->append_sid('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&amp;mode=manage_subscriptions'), $total_images, $images_per_page, $start),
			//'PAGE_NUMBER'				=> on_page($total_images, $images_per_page, $start),
			//'TOTAL_IMAGES'				=> $user->lang('VIEW_ALBUM_IMAGES', $total_images),

			'DISP_FAKE_THUMB'			=> true,
			'FAKE_THUMB_SIZE'			=> $phpbb_ext_gallery_config->get('mini_thumbnail_size'),
		));
	}

	function subscribe_pegas($album_id)

It is generally recommended to explicitly declare the visibility for methods.

	{
		global $db, $users_table, $phpbb_container;
		$phpbb_gallery_notification = $phpbb_container->get('phpbbgallery.core.notification');

		$sql = 'SELECT user_id
			FROM ' . $users_table . '
			WHERE subscribe_pegas = 1';
		$result = $db->sql_query($sql);

		while ($row = $db->sql_fetchrow($result))
		{
			$phpbb_gallery_notification->add_albums($album_id, (int) $row['user_id']);
		}
		$db->sql_freeresult($result);
	}
}