phpbbgallery\core\album\manage

Complexity

Total Complexity

89

Size/Duplication

Total Lines	1098
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	set_parent()	0	3	1
A	set_u_action()	0	3	1
F	update_album_data()	0	358	42
A	__construct()	0	33	1
A	move_album_content()	0	56	2
A	back_link()	0	3	1
F	delete_album()	0	192	22
A	move_album_by()	0	76	5
A	set_user()	0	3	1
B	move_album()	0	95	6
B	delete_album_content()	0	92	7

<?php
/**
 * phpBB Gallery - Core Extension
 *
 * @package   phpbbgallery/core
 * @author    nickvergessen
 * @author    satanasov
 * @author    Leinad4Mind
 * @copyright 2007-2012 nickvergessen, 2014- satanasov, 2018- Leinad4Mind
 * @license   GPL-2.0-only
 *
 * mostly borrowed from phpBB3
 * @author: phpBB Group
 * @location: includes/acp/acp_forums.php
 *
 * Note: There are several code parts commented out, for example the album/forum_password.
 *       I didn't remove them, to have it easier when I implement this feature one day. I hope it's okay.
 */

/**
* @ignore
*/

namespace phpbbgallery\core\album;

class manage
{
	public $user_id = 0;

	public $parent_id = 0;

	private $u_action = '';

	/** @var \phpbb\user */

The type phpbb\user was not found. Maybe you did not declare it correctly or list all dependencies?

	protected $user;

	/** @var \phpbb\language\language */

The type phpbb\language\language was not found. Maybe you did not declare it correctly or list all dependencies?

	protected $language;

	/** @var \phpbb\request\request */

The type phpbb\request\request was not found. Maybe you did not declare it correctly or list all dependencies?

	protected $request;

	/** @var \phpbb\db\driver\driver_interface */

The type phpbb\db\driver\driver_interface was not found. Maybe you did not declare it correctly or list all dependencies?

	protected $db;

	/** @var \phpbb\event\dispatcher */

The type phpbb\event\dispatcher was not found. Maybe you did not declare it correctly or list all dependencies?

	protected $dispatcher;

	/** @var \phpbbgallery\core\auth\auth */
	protected $gallery_auth;

	/** @var \phpbbgallery\core\album\album */
	protected $gallery_album;

	/** @var \phpbbgallery\core\album\display */
	protected $gallery_display;

	/** @var \phpbbgallery\core\image\image */
	protected $gallery_image;

	/** @var \phpbbgallery\core\cache */
	protected $gallery_cache;

	/** @var \phpbbgallery\core\user */
	protected $gallery_user;

	/** @var \phpbbgallery\core\config */
	protected $gallery_config;

	/** @var \phpbbgallery\core\contest */
	protected $gallery_contest;

	/** @var \phpbbgallery\core\report */
	protected $gallery_report;

	/** @var \phpbbgallery\core\log */
	protected $gallery_log;

	/** @var \phpbbgallery\core\notification */
	protected $gallery_notification;

	/** @var string */
	protected $albums_table;

	/** @var string */
	protected $images_table;

	/** @var string */
	protected $comments_table;

	/** @var string */
	protected $permissions_table;

	/** @var string */
	protected $moderators_table;

	/** @var string */
	protected $contests_table;

	/**
	 * manage constructor.
	 * @param \phpbb\user $user
	 * @param \phpbb\request\request $request
	 * @param \phpbb\db\driver\driver_interface $db
	 * @param \phpbb\event\dispatcher $dispatcher
	 * @param \phpbbgallery\core\auth\auth $gallery_auth
	 * @param album $gallery_album
	 * @param display $gallery_display
	 * @param \phpbbgallery\core\image\image $gallery_image
	 * @param \phpbbgallery\core\cache $gallery_cache
	 * @param \phpbbgallery\core\user $gallery_user
	 * @param \phpbbgallery\core\config $gallery_config
	 * @param \phpbbgallery\core\contest $gallery_contest
	 * @param \phpbbgallery\core\report $gallery_report
	 * @param \phpbbgallery\core\log $gallery_log
	 * @param \phpbbgallery\core\notification $gallery_notification
	 * @param $albums_table
	 * @param $images_table
	 * @param $comments_table
	 * @param $permissions_table
	 * @param $moderators_table
	 * @param $contests_table
	 */
	public function __construct(\phpbb\user $user, \phpbb\language\language $language,
								\phpbb\request\request $request, \phpbb\db\driver\driver_interface $db,
								\phpbb\event\dispatcher $dispatcher,
								\phpbbgallery\core\auth\auth $gallery_auth, \phpbbgallery\core\album\album $gallery_album,
								\phpbbgallery\core\album\display $gallery_display, \phpbbgallery\core\image\image $gallery_image,
								\phpbbgallery\core\cache $gallery_cache, \phpbbgallery\core\user $gallery_user,
								\phpbbgallery\core\config $gallery_config,
								\phpbbgallery\core\contest $gallery_contest, \phpbbgallery\core\report $gallery_report,
								\phpbbgallery\core\log $gallery_log, \phpbbgallery\core\notification $gallery_notification,
								$albums_table, $images_table, $comments_table, $permissions_table, $moderators_table, $contests_table)
	{
		$this->user = $user;
		$this->language = $language;
		$this->request = $request;
		$this->db = $db;
		$this->dispatcher = $dispatcher;
		$this->gallery_auth = $gallery_auth;
		$this->gallery_album = $gallery_album;
		$this->gallery_display = $gallery_display;
		$this->gallery_image = $gallery_image;
		$this->gallery_cache = $gallery_cache;
		$this->gallery_user = $gallery_user;
		$this->gallery_config = $gallery_config;
		$this->gallery_contest = $gallery_contest;
		$this->gallery_report = $gallery_report;
		$this->gallery_log = $gallery_log;
		$this->gallery_notification = $gallery_notification;
		$this->albums_table = $albums_table;
		$this->images_table = $images_table;
		$this->comments_table = $comments_table;
		$this->permissions_table = $permissions_table;
		$this->moderators_table = $moderators_table;
		$this->contests_table = $contests_table;
	}

	public function set_user($user_id)
	{
		$this->user_id = (int) $user_id;
	}

	public function set_parent($parent_id)
	{
		$this->parent_id = (int) $parent_id;
	}

	public function set_u_action($action)
	{
		$this->u_action = $action;
	}

	/**
	 * Generate back link for acp pages
	 * @param $u_action
	 * @return string
	 */
	public function back_link($u_action)
	{
		return '<br /><br /><a href="' . $u_action . '">&laquo; ' . $this->language->lang('BACK_TO_PREV') . '</a>';
	}

	/**
	 * Update album data
	 *
	 * borrowed from phpBB3
	 * @author: phpBB Group
	 * @function: update_forum_data
	 * @param $album_data
	 * @param $contest_data
	 * @return array
	 */
	public function update_album_data(&$album_data, &$contest_data)
	{
		$errors = array();

		if (!$album_data['album_name'])
		{
			$errors[] = $this->language->lang('ALBUM_NAME_EMPTY');
		}

		if (utf8_strlen($album_data['album_desc']) > 4000)

The function utf8_strlen was not found. Maybe you did not declare it correctly or list all dependencies?

		{
			$errors[] = $this->language->lang('ALBUM_DESC_TOO_LONG');
		}

		/*if ($album_data['album_password'] || $album_data['album_password_confirm'])
		{
			if ($album_data['album_password'] != $album_data['album_password_confirm'])
			{
				$album_data['album_password'] = $album_data['album_password_confirm'] = '';
				$errors[] = $user->lang['ALBUM_PASSWORD_MISMATCH'];
			}
		}*/
		// Validate the contest timestamps:
		if ($album_data['album_type'] == (int) \phpbbgallery\core\block::TYPE_CONTEST)
		{
			if ($this->user->data['user_timezone'] == '')
			{
				$timezone = 'UTC';

The assignment to $timezone is dead and can be removed.

			}
			else
			{
				$timezone = $this->user->data['user_timezone'];
			}
			//$timezone = ($this->user->data['user_timezone'] == '' ? $this->user->data['user_timezone'] : 'UTC');
			$time = $this->user->create_datetime();

			$start_date_error = $date_error = false;
			if (!preg_match('#(\\d{4})-(\\d{1,2})-(\\d{1,2}) (\\d{1,2}):(\\d{2})#', $contest_data['contest_start'], $m))
			{
				$errors[] = sprintf($this->language->lang('CONTEST_START_INVALID'), $contest_data['contest_start']);
				$start_date_error = true;
			}
			else
			{
				$contest_data['contest_start'] = gmmktime((int) $m[4], (int) $m[5], 0, (int) $m[2], (int) $m[3], (int) $m[1]) - $time->getOffset();// - $offset;
			}
			if (!preg_match('#(\\d{4})-(\\d{1,2})-(\\d{1,2}) (\\d{1,2}):(\\d{2})#', $contest_data['contest_rating'], $m))
			{
				$errors[] = sprintf($this->language->lang('CONTEST_RATING_INVALID'), $contest_data['contest_rating']);
				$date_error = true;
			}
			else if (!$start_date_error)
			{
				$contest_data['contest_rating'] = gmmktime($m[4], $m[5], 0, $m[2], $m[3], $m[1]) - $contest_data['contest_start'] - $time->getOffset();//- $offset;
			}
			if (!preg_match('#(\\d{4})-(\\d{1,2})-(\\d{1,2}) (\\d{1,2}):(\\d{2})#', $contest_data['contest_end'], $m))
			{
				$errors[] = sprintf($this->language->lang('CONTEST_END_INVALID'), $contest_data['contest_end']);
				$date_error = true;
			}
			else if (!$start_date_error)
			{
				$contest_data['contest_end'] = gmmktime($m[4], $m[5], 0, $m[2], $m[3], $m[1]) - $contest_data['contest_start'] - $time->getOffset();//- $offset;
			}
			if (!$start_date_error && !$date_error)
			{
				if ($contest_data['contest_end'] < $contest_data['contest_rating'])
				{
					$errors[] = $this->language->lang('CONTEST_END_BEFORE_RATING');
				}
				if ($contest_data['contest_rating'] < 0)
				{
					$errors[] = $this->language->lang('CONTEST_RATING_BEFORE_START');
				}
				if ($contest_data['contest_end'] < 0)
				{
					$errors[] = $this->language->lang('CONTEST_END_BEFORE_START');
				}
			}
		}

		// Unset data that are not database fields
		$album_data_sql = $album_data;
		/*
		unset($album_data_sql['album_password_confirm']);
		*/

		// What are we going to do tonight Brain? The same thing we do every night,
		// try to take over the world ... or decide whether to continue update
		// and if so, whether it's a new album/cat/contest or an existing one
		if (sizeof($errors))
		{
			return $errors;
		}

		/*
		// As we don't know the old password, it's kinda tricky to detect changes
		if ($album_data_sql['album_password_unset'])
		{
			$albumdata_sql['album_password'] = '';
		}
		else if (empty($album_data_sql['album_password']))
		{
			unset($album_data_sql['album_password']);
		}
		else
		{
			$album_data_sql['album_password'] = phpbb_hash($album_data_sql['album_password']);
		}
		unset($album_data_sql['album_password_unset']);
		*/

		if (!isset($album_data_sql['album_id']))
		{
			// no album_id means we're creating a new album
			unset($album_data_sql['type_action']);
			$add_on_top = $this->request->variable('add_on_top', 0);

			if ($album_data_sql['parent_id'])
			{
				$sql = 'SELECT left_id, right_id, album_type
					FROM ' . $this->albums_table . '
					WHERE album_id = ' . (int) $album_data_sql['parent_id'];
				$result = $this->db->sql_query($sql);
				$row = $this->db->sql_fetchrow($result);
				$this->db->sql_freeresult($result);

				if (!$row)
				{
					trigger_error($this->language->lang('PARENT_NOT_EXIST') . $this->back_link($this->u_action . '&amp;parent_id=' . $this->parent_id), E_USER_WARNING);
				}

				if (!$add_on_top)
				{
					$sql = 'UPDATE ' . $this->albums_table . ' 
						SET left_id = left_id + 2, right_id = right_id + 2
						WHERE album_user_id = 0
							AND left_id > ' . (int) $row['right_id'];
					$this->db->sql_query($sql);

					$sql = 'UPDATE ' . $this->albums_table . ' 
						SET right_id = right_id + 2
						WHERE album_user_id = 0
							AND ' . (int) $row['left_id'] . ' BETWEEN left_id AND right_id';
					$this->db->sql_query($sql);

					$album_data_sql['left_id'] = $row['right_id'];
					$album_data_sql['right_id'] = $row['right_id'] + 1;
				}
				else
				{
					$sql = 'UPDATE ' . $this->albums_table . ' 
						SET left_id = left_id + 2, right_id = right_id + 2
						WHERE album_user_id = 0
							AND left_id > ' . (int) $row['left_id'];
					$this->db->sql_query($sql);

					$sql = 'UPDATE ' . $this->albums_table . ' 
						SET right_id = right_id + 2
						WHERE album_user_id = 0
							AND ' . (int) $row['left_id'] . ' BETWEEN left_id AND right_id';
					$this->db->sql_query($sql);

					$album_data_sql['left_id'] = $row['left_id'] + 1;
					$album_data_sql['right_id'] = $row['left_id'] + 2;
				}
			}
			else
			{
				if (!$add_on_top)
				{
					$sql = 'SELECT MAX(right_id) AS right_id
						FROM ' . $this->albums_table . ' 
						WHERE album_user_id = 0';
					$result = $this->db->sql_query($sql);
					$row = $this->db->sql_fetchrow($result);
					$this->db->sql_freeresult($result);

					$album_data_sql['left_id'] = $row['right_id'] + 1;
					$album_data_sql['right_id'] = $row['right_id'] + 2;
				}
				else
				{
					$sql = 'UPDATE ' . $this->albums_table . ' 
						SET left_id = left_id + 2, right_id = right_id + 2
						WHERE album_user_id = 0';
					$this->db->sql_query($sql);

					$album_data_sql['left_id'] = 1;
					$album_data_sql['right_id'] = 2;
				}
			}

			$sql = 'INSERT INTO ' . $this->albums_table . ' ' . $this->db->sql_build_array('INSERT', $album_data_sql);
			$this->db->sql_query($sql);
			$album_data['album_id'] = (int) $this->db->sql_nextid();

			// Type is contest, so create it...
			if ($album_data['album_type'] == (int) \phpbbgallery\core\block::TYPE_CONTEST)
			{
				$contest_data_sql = $contest_data;
				$contest_data_sql['contest_album_id'] = $album_data['album_id'];
				$contest_data_sql['contest_marked'] = (int) \phpbbgallery\core\block::IN_CONTEST;

				$sql = 'INSERT INTO ' . $this->contests_table . ' ' . $this->db->sql_build_array('INSERT', $contest_data_sql);
				$this->db->sql_query($sql);
				$album_data['album_contest'] = (int) $this->db->sql_nextid();

				$sql = 'UPDATE ' . $this->albums_table . ' 
					SET album_contest = ' . $album_data['album_contest'] . '
					WHERE album_id = ' . (int) $album_data['album_id'];
				$this->db->sql_query($sql);
			}
			$this->gallery_log->add_log('admin', 'add', $album_data['album_id'], 0, array('LOG_ALBUM_ADD', $album_data['album_name']));
		}
		else
		{
			$row = $this->gallery_album->get_info($album_data_sql['album_id']);
			$reset_marked_images = false;

The assignment to $reset_marked_images is dead and can be removed.

			if ($row['album_type'] == (int) \phpbbgallery\core\block::TYPE_CONTEST && $album_data_sql['album_type'] != (int) \phpbbgallery\core\block::TYPE_CONTEST)
			{
				// Changing a contest to album? No!
				// Changing a contest to category? No!
				$errors[] = $this->language->lang('ALBUM_WITH_CONTEST_NO_TYPE_CHANGE');
				return $errors;
			}
			else if ($row['album_type'] != (int) \phpbbgallery\core\block::TYPE_CONTEST && $album_data_sql['album_type'] == (int) \phpbbgallery\core\block::TYPE_CONTEST)
			{
				// Changing a album to contest? No!
				// Changing a category to contest? No!
				$errors[] = $this->language->lang('ALBUM_NO_TYPE_CHANGE_TO_CONTEST');
				return $errors;
			}
			else if ($row['album_type'] == (int) \phpbbgallery\core\block::TYPE_CAT && $album_data_sql['album_type'] == (int) \phpbbgallery\core\block::TYPE_UPLOAD)
			{
				// Changing a category to a album? Yes!
				// Reset the data (you couldn't upload directly in a cat, you must use a album)
				$album_data_sql['album_images'] = $album_data_sql['album_images_real'] = $album_data_sql['album_last_image_id'] = $album_data_sql['album_last_user_id'] = $album_data_sql['album_last_image_time'] = $album_data_sql['album_contest'] = 0;
				$album_data_sql['album_last_username'] = $album_data_sql['album_last_user_colour'] = $album_data_sql['album_last_image_name'] = '';
			}
			else if ($row['album_type'] == (int) \phpbbgallery\core\block::TYPE_UPLOAD && $album_data_sql['album_type'] == (int) \phpbbgallery\core\block::TYPE_CAT)
			{
				// Changing a album to a category? Yes!
				// we're turning a uploadable album into a non-uploadable album
				if ($album_data_sql['type_action'] == 'move')
				{
					$to_album_id = $this->request->variable('to_album_id', 0);

					if ($to_album_id)
					{
						$errors = $this->move_album_content($album_data_sql['album_id'], $to_album_id);
					}
					else
					{
						return array($this->language->lang('NO_DESTINATION_ALBUM'));
					}
				}
				else if ($album_data_sql['type_action'] == 'delete')
				{
					$errors = $this->delete_album_content($album_data_sql['album_id']);
				}
				else
				{
					return array($this->language->lang('NO_ALBUM_ACTION'));
				}
			}
			else if ($row['album_type'] == (int) \phpbbgallery\core\block::TYPE_CONTEST && $album_data_sql['album_type'] == (int) \phpbbgallery\core\block::TYPE_CONTEST)
			{
				// Changing a contest to contest? Yes!
				// We need to check for the contest_data
				$row_contest = $this->gallery_contest->get_contest($album_data['album_id'], 'album');
				$contest_data['contest_id'] = $row_contest['contest_id'];
				if ($row_contest['contest_marked'] == (int) \phpbbgallery\core\block::NO_CONTEST)
				{
					// If the old contest is finished, but the new one isn't, we need to remark the images!
					// If we change it the other way round, the album.php will do the end on the first visit!
					if (($row_contest['contest_start'] + $row_contest['contest_end']) > time())
					{
						$contest_data['contest_marked'] = (int) \phpbbgallery\core\block::IN_CONTEST;
						$reset_marked_images = true;
					}
				}
			}

			if (sizeof($errors))
			{
				return $errors;
			}

			if ($row['parent_id'] != $album_data_sql['parent_id'])
			{
				if ($row['album_id'] != $album_data_sql['parent_id'])
				{
					$errors = $this->move_album($album_data_sql['album_id'], $album_data_sql['parent_id']);
				}
				else
				{
					$album_data_sql['parent_id'] = $row['parent_id'];
				}
			}

			if (sizeof($errors))
			{
				return $errors;
			}

			unset($album_data_sql['type_action']);

			if ($row['album_name'] != $album_data_sql['album_name'])
			{
				// The album name has changed, clear the parents list of all albums (for safety)
				$sql = 'UPDATE ' . $this->albums_table . "  
					SET album_parents = ''";
				$this->db->sql_query($sql);
			}

			// Setting the album id to the album id is not really received well by some dbs. ;)
			$album_id = $album_data_sql['album_id'];
			unset($album_data_sql['album_id']);

			$sql = 'UPDATE ' . $this->albums_table . '  
				SET ' . $this->db->sql_build_array('UPDATE', $album_data_sql) . '
				WHERE album_id = ' . (int) $album_id;
			$this->db->sql_query($sql);

/*			if ($album_data_sql['album_type'] == $phpbb_ext_gallery_core_album::TYPE_CONTEST)
			{
				// Setting the contest id to the contest id is not really received well by some dbs. ;)
				$contest_id = $contest_data['contest_id'];
				unset($contest_data['contest_id']);

				$sql = 'UPDATE ' . $this->contests_table . '
					SET ' . $db->sql_build_array('UPDATE', $contest_data) . '
					WHERE contest_id = ' . (int) $contest_id;
				$db->sql_query($sql);
				if ($reset_marked_images)
				{
					// If the old contest is finished, but the new one isn't, we need to remark the images!
					$sql = 'UPDATE ' . $this->images_table . '
						SET image_contest_rank = 0,
							image_contest_end = 0,
							image_contest = ' . phpbb_ext_gallery_core_image::IN_CONTEST . '
						WHERE image_album_id = ' . (int) $album_id;
					$db->sql_query($sql);
				}

				// Add it back
				$contest_data['contest_id'] = $contest_id;
			}
*/
			// Add it back
			$album_data['album_id'] = $album_id;

			$this->gallery_log->add_log('admin', 'edit', $album_id, 0, array('LOG_ALBUM_EDIT', $album_data['album_name']));
		}

		return $errors;
	}

	/**
	 * Move album
	 *
	 * borrowed from phpBB3
	 * @author: phpBB Group
	 * @function: move_forum
	 * @param $from_id
	 * @param $to_id
	 * @return array
	 */
	public function move_album($from_id, $to_id)
	{
		$to_data = $moved_ids = $errors = array();

The assignment to $moved_ids is dead and can be removed.

The assignment to $to_data is dead and can be removed.

		// Get the parent data
		if ($to_id > 0)
		{
			$to_data = $this->gallery_album->get_info($to_id);
		}

		$moved_albums = $this->gallery_display->get_branch($this->user_id, $from_id, 'children', 'descending');
	//	var_dump($moved_albums);
		$from_data = $moved_albums[0];

		$diff = sizeof($moved_albums) * 2;

		$moved_ids = array();
		for ($i = 0, $end = sizeof($moved_albums); $i < $end; ++$i)
		{
			// Can not select child as parent
			if ($moved_albums[$i]['album_id'] == $to_id)
			{
				return array($this->language->lang('ALBUM_PARENT_INVALID'));
			}
			$moved_ids[] = $moved_albums[$i]['album_id'];
		}

		// Resync parents
		$sql = 'UPDATE ' . $this->albums_table . " 
			SET right_id = right_id - $diff, album_parents = ''
			WHERE album_user_id = " . (int) $this->user_id . '
				AND left_id < ' . (int) $from_data['right_id'] . "
				AND right_id > " . (int) $from_data['right_id'];
		$this->db->sql_query($sql);

		// Resync right-hand side of tree
		$sql = 'UPDATE ' . $this->albums_table . " 
			SET left_id = left_id - $diff, right_id = right_id - $diff, album_parents = ''
			WHERE album_user_id = " . (int) $this->user_id . '
				AND left_id > ' . (int) $from_data['right_id'];
		$this->db->sql_query($sql);

		if ($to_id > 0)
		{
			// Retrieve $to_data again, it may have been changed...
			$to_data = $this->gallery_album->get_info($to_id);

			// Resync new parents
			$sql = 'UPDATE ' . $this->albums_table . " 
				SET right_id = right_id + $diff, album_parents = ''
				WHERE album_user_id = " . (int) $this->user_id . '
					AND ' . (int) $to_data['right_id'] . ' BETWEEN left_id AND right_id
					AND ' . $this->db->sql_in_set('album_id', $moved_ids, true);
			$this->db->sql_query($sql);

			// Resync the right-hand side of the tree
			$sql = 'UPDATE ' . $this->albums_table . ' 
				SET left_id = left_id + ' . (int) $diff . ', right_id = right_id + ' . (int) $diff . ', album_parents = \'\'
				WHERE album_user_id = ' . (int) $this->user_id . '
					AND left_id > ' . (int) $to_data['right_id'] . '
					AND ' . $this->db->sql_in_set('album_id', $moved_ids, true);
			$this->db->sql_query($sql);

			// Resync moved branch
			$to_data['right_id'] += $diff;

			if ($to_data['right_id'] > $from_data['right_id'])
			{
				$diff = '+ ' . ($to_data['right_id'] - $from_data['right_id'] - 1);
			}
			else
			{
				$diff = '- ' . abs($to_data['right_id'] - $from_data['right_id'] - 1);
			}
		}
		else
		{
			$sql = 'SELECT MAX(right_id) AS right_id
				FROM ' . $this->albums_table . ' 
				WHERE album_user_id = ' . (int) $this->user_id . '
					AND ' . $this->db->sql_in_set('album_id', $moved_ids, true);
			$result = $this->db->sql_query($sql);
			$row = $this->db->sql_fetchrow($result);
			$this->db->sql_freeresult($result);

			$diff = '+ ' . ($row['right_id'] - $from_data['left_id'] + 1);
		}

		$sql = 'UPDATE ' . $this->albums_table . " 
			SET left_id = left_id $diff, right_id = right_id $diff, album_parents = ''
			WHERE album_user_id = " . (int) $this->user_id . '
				AND ' . $this->db->sql_in_set('album_id', $moved_ids);
		$this->db->sql_query($sql);

		return $errors;
	}

	/**
	 * Remove complete album
	 *
	 * borrowed from phpBB3
	 * @author: phpBB Group
	 * @function: delete_forum
	 * @param $album_id
	 * @param string $action_images
	 * @param string $action_subalbums
	 * @param int $images_to_id
	 * @param int $subalbums_to_id
	 * @return array
	 */
	public function delete_album($album_id, $action_images = 'delete', $action_subalbums = 'delete', $images_to_id = 0, $subalbums_to_id = 0)
	{
		$album_data = $this->gallery_album->get_info($album_id);
		$errors = array();
		$log_action_images = $log_action_albums = $images_to_name = $subalbums_to_name = '';
		$album_ids = array($album_id);

		if ($action_images == 'delete')
		{
			$log_action_images = 'IMAGES';
			$errors = array_merge($errors, $this->delete_album_content($album_id));
		}
		else if ($action_images == 'move')
		{
			if (!$images_to_id)
			{
				$errors[] = $this->language->lang('NO_DESTINATION_ALBUM');
			}
			else
			{
				$log_action_images = 'MOVE_IMAGES';

				$sql = 'SELECT album_name
					FROM ' . $this->albums_table . '
					WHERE album_id = ' . (int) $images_to_id;
				$result = $this->db->sql_query($sql);
				$row = $this->db->sql_fetchrow($result);
				$this->db->sql_freeresult($result);

				if (!$row)
				{
					$errors[] = $this->language->lang('NO_ALBUM');
				}
				else
				{
					$images_to_name = $row['album_name'];
					$errors = array_merge($errors, $this->move_album_content($album_id, $images_to_id));
				}
			}
		}

		if (sizeof($errors))
		{
			return $errors;
		}

		if ($action_subalbums == 'delete')
		{
			$log_action_albums = 'ALBUMS';
			$rows = $this->gallery_display->get_branch($this->user_id, $album_id, 'children', 'descending', false);

			foreach ($rows as $row)
			{
				$album_ids[] = $row['album_id'];
				$errors = array_merge($errors, $this->delete_album_content($row['album_id']));
			}

			if (sizeof($errors))
			{
				return $errors;
			}

			$diff = sizeof($album_ids) * 2;

			$sql = 'DELETE FROM ' . $this->albums_table . ' 
				WHERE ' . $this->db->sql_in_set('album_id', $album_ids);
			$this->db->sql_query($sql);
		}
		else if ($action_subalbums == 'move')
		{
			if (!$subalbums_to_id)
			{
				$errors[] = $this->language->lang('NO_DESTINATION_ALBUM');
			}
			else
			{
				$log_action_albums = 'MOVE_ALBUMS';

				$sql = 'SELECT album_name
					FROM ' . $this->albums_table . ' 
					WHERE album_id = ' . (int) $subalbums_to_id;
				$result = $this->db->sql_query($sql);
				$row = $this->db->sql_fetchrow($result);
				$this->db->sql_freeresult($result);

				if (!$row)
				{
					$errors[] = $this->language->lang('NO_ALBUM');
				}
				else
				{
					$subalbums_to_name = $row['album_name'];

					$sql = 'SELECT album_id
						FROM ' . $this->albums_table . ' 
						WHERE parent_id = ' . (int) $album_id;
					$result = $this->db->sql_query($sql);

					while ($row = $this->db->sql_fetchrow($result))
					{
						$this->move_album($row['album_id'], $subalbums_to_id);
					}
					$this->db->sql_freeresult($result);

					// Grab new album data for correct tree updating later
					$album_data = $this->gallery_album->get_info($album_id);

					$sql = 'UPDATE ' . $this->albums_table . ' 
						SET parent_id = ' . (int) $subalbums_to_id .'
						WHERE parent_id = ' . (int) $album_id . '
							AND album_user_id = ' . (int) $this->user_id;
					$this->db->sql_query($sql);

					$diff = 2;
					$sql = 'DELETE FROM ' . $this->albums_table . ' 
						WHERE album_id = ' . (int) $album_id;
					$this->db->sql_query($sql);
				}
			}

			if (sizeof($errors))
			{
				return $errors;
			}
		}
		else
		{
			$diff = 2;
			$sql = 'DELETE FROM ' . $this->albums_table . '  
				WHERE album_id = ' . (int) $album_id;
			$this->db->sql_query($sql);
		}

		// Resync tree
		$sql = 'UPDATE ' . $this->albums_table . '  
			SET right_id = right_id - ' . (int) $diff . '
			WHERE left_id < ' . (int) $album_data['right_id'] . ' AND right_id > ' . (int) $album_data['right_id']. '
				AND album_user_id = ' . (int) $this->user_id;
		$this->db->sql_query($sql);

		$sql = 'UPDATE ' . $this->albums_table . ' 
			SET left_id = left_id - ' . (int) $diff . ', right_id = right_id - ' . (int) $diff . '
			WHERE left_id > ' . (int) $album_data['right_id']. '
				AND album_user_id = ' . (int) $this->user_id;
		$this->db->sql_query($sql);

		$log_action = implode('_', array($log_action_images, $log_action_albums));

		/**
		* Log what we did
		*/
		switch ($log_action)
		{
			case 'MOVE_IMAGES_MOVE_ALBUMS':
				$this->gallery_log->add_log('admin', 'del', 0, 0, array('LOG_ALBUM_DEL_MOVE_IMAGES_MOVE_ALBUMS', $images_to_name, $subalbums_to_name, $album_data['album_name']));
			break;

			case 'MOVE_IMAGES_ALBUMS':
				$this->gallery_log->add_log('admin', 'del', $images_to_id, 0, array('LOG_ALBUM_DEL_MOVE_IMAGES_ALBUMS', $images_to_name, $album_data['album_name']));
			break;

			case 'IMAGES_MOVE_ALBUMS':
				$this->gallery_log->add_log('admin', 'del', $subalbums_to_id, 0, array('LOG_ALBUM_DEL_IMAGES_MOVE_ALBUMS', $subalbums_to_name, $album_data['album_name']));
			break;

			case '_MOVE_ALBUMS':
				$this->gallery_log->add_log('admin', 'del', $subalbums_to_id, 0, array('LOG_ALBUM_DEL_MOVE_ALBUMS', $subalbums_to_name, $album_data['album_name']));
			break;

			case 'MOVE_IMAGES_':
				$this->gallery_log->add_log('admin', 'del', $images_to_id, 0, array('LOG_ALBUM_DEL_MOVE_IMAGES', $images_to_name, $album_data['album_name']));
			break;

			case 'IMAGES_ALBUMS':
				$this->gallery_log->add_log('admin', 'del', 0, 0, array('LOG_ALBUM_DEL_IMAGES_ALBUMS', $album_data['album_name']));
			break;

			case '_ALBUMS':
				$this->gallery_log->add_log('admin', 'del', 0, 0, array('LOG_ALBUM_DEL_ALBUMS', $album_data['album_name']));
			break;

			case 'IMAGES_':
				$this->gallery_log->add_log('admin', 'del', 0, 0, array('LOG_ALBUM_DEL_IMAGES', $album_data['album_name']));
			break;

			default:
				$this->gallery_log->add_log('admin', 'del', 0, 0, array('LOG_ALBUM_DEL_ALBUM', $album_data['album_name']));
			break;
		}

		$this->gallery_auth->set_user_permissions('all', '');

'' of type string is incompatible with the type boolean expected by parameter $permissions of phpbbgallery\core\auth\auth::set_user_permissions().

		return $errors;
	}

	/**
	 * Move album content from one to another album
	 *
	 * borrowed from phpBB3
	 * @author: phpBB Group
	 * @function: move_forum_content
	 * @param $from_id
	 * @param $to_id
	 * @param bool $sync
	 * @return array
	 */
	public function move_album_content($from_id, $to_id, $sync = true)
	{
		// Lucifer TODO - Log to gallery log
		//$sql = 'UPDATE ' . LOG_TABLE . "
		//	SET album_id = $to_id
		//	WHERE album_id = $from_id
		//		AND log_type = " . LOG_GALLERY;
		//$db->sql_query($sql);

		// Reset contest-information for safety.
		$sql = 'UPDATE ' . $this->images_table . ' 
			SET image_album_id = ' . (int) $to_id . ',
				image_contest_rank = 0,
				image_contest_end = 0,
				image_contest = ' . (int) \phpbbgallery\core\block::NO_CONTEST . '
			WHERE image_album_id = ' . (int) $from_id;
		$this->db->sql_query($sql);

		$this->gallery_report->move_album_content($from_id, $to_id);

		$sql = 'DELETE FROM ' . $this->contests_table . ' 
			WHERE contest_album_id = ' . (int) $from_id;
		$this->db->sql_query($sql);

		$sql = 'DELETE FROM ' . $this->permissions_table . ' 
			WHERE perm_album_id = ' . (int) $from_id;
		$this->db->sql_query($sql);

		$sql = 'DELETE FROM ' . $this->moderators_table . ' 
			WHERE album_id = ' . (int) $from_id;
		$this->db->sql_query($sql);

		$this->gallery_notification->delete_albums($from_id);

		/**
		* Event related to moving album content
		*
		* @event phpbbgallery.core.album.manage.move_album_content
		* @var	int	from_id		Album we are moving from
		* @var	int	to_id		Album we are moving to
		* @var	bool	sync	Should we sync the albums data
		* @since 1.2.0
		*/
		$vars = array('from_id', 'to_id', 'sync');
		extract($this->dispatcher->trigger_event('phpbbgallery.core.album.manage.move_album_content', compact($vars)));

		$this->gallery_cache->destroy_albums();

		if ($sync)
		{
			// Resync counters
			$this->gallery_album->update_info($from_id);
			$this->gallery_album->update_info($to_id);
		}

		return array();
	}

	/**
	 * Delete album content:
	 * Deletes all images, comments, rates, image-files, etc.
	 * @param $album_id
	 * @return array
	 */
	public function delete_album_content($album_id)
	{
		$album_id = (int) $album_id;

		// Before we remove anything we make sure we are able to adjust the image counts later. ;)
		$sql = 'SELECT image_user_id
			FROM ' . $this->images_table . ' 
			WHERE image_album_id = ' . (int) $album_id . '
				AND image_status <> ' . (int) \phpbbgallery\core\block::STATUS_UNAPPROVED . '
				AND image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN;
		$result = $this->db->sql_query($sql);

		$image_counts = array();
		while ($row = $this->db->sql_fetchrow($result))
		{
			$image_counts[$row['image_user_id']] = (!empty($image_counts[$row['image_user_id']])) ? $image_counts[$row['image_user_id']] + 1 : 1;
		}
		$this->db->sql_freeresult($result);

		$sql = 'SELECT image_id, image_filename, image_album_id
			FROM ' . $this->images_table . ' 
			WHERE image_album_id = ' . (int) $album_id;
		$result = $this->db->sql_query($sql);

		$filenames = $deleted_images = array();
		while ($row = $this->db->sql_fetchrow($result))
		{
			$deleted_images[] = $row['image_id'];
			$filenames[(int) $row['image_id']] = $row['image_filename'];
		}
		$this->db->sql_freeresult($result);

		if (!empty($deleted_images))
		{
			$this->gallery_image->delete_images($deleted_images, $filenames);
		}

		// Lucifer TODO: Log Gallery deletion from log
		//$sql = 'DELETE FROM ' . LOG_TABLE . "
		//	WHERE album_id = $album_id
		//		AND log_type = " . LOG_GALLERY;
		//$db->sql_query($sql);

		//@todo: merge queries into loop
		$sql = 'DELETE FROM ' . $this->permissions_table . ' 
			WHERE perm_album_id = ' . (int) $album_id;
		$this->db->sql_query($sql);
		$sql = 'DELETE FROM ' . $this->contests_table . ' 
			WHERE contest_album_id = ' . (int) $album_id;
		$this->db->sql_query($sql);

		$sql = 'DELETE FROM ' . $this->moderators_table . ' 
			WHERE album_id = ' . (int) $album_id;
		$this->db->sql_query($sql);

		$this->gallery_notification->delete_albums($album_id);

		// Adjust users image counts
		if (!empty($image_counts))
		{
			foreach ($image_counts as $image_user_id => $subtract)
			{
				$this->gallery_user->set_user_id($image_user_id);
				$this->gallery_user->update_images((0 - $subtract));
			}
		}

		// Make sure the overall image & comment count is correct...
		$sql = 'SELECT COUNT(image_id) AS num_images, SUM(image_comments) AS num_comments
			FROM ' . $this->images_table . '  
			WHERE image_status <> ' . (int) \phpbbgallery\core\block::STATUS_UNAPPROVED . '
				AND image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN;
		$result = $this->db->sql_query($sql);
		$row = $this->db->sql_fetchrow($result);
		$this->db->sql_freeresult($result);

		$this->gallery_config->set('num_images', $row['num_images']);
		$this->gallery_config->set('num_comments', (int) $row['num_comments']);

		/**
		* Event delete album content
		*
		* @event phpbbgallery.core.album.manage.delete_album_content
		* @var	int	album_id		Album we are deleting
		* @since 1.2.0
		*/
		$vars = array('album_id');
		extract($this->dispatcher->trigger_event('phpbbgallery.core.album.manage.delete_album_content', compact($vars)));

		$this->gallery_cache->destroy_albums();

		return array();
	}

	/**
	 * Move album position by $steps up/down
	 *
	 * borrowed from phpBB3
	 * @author: phpBB Group
	 * @function: move_forum_by
	 * @param $album_row
	 * @param string $action
	 * @param int $steps
	 * @return mixed
	 */
	public function move_album_by($album_row, $action = 'move_up', $steps = 1)
	{
		/**
		* Fetch all the siblings between the module's current spot
		* and where we want to move it to. If there are less than $steps
		* siblings between the current spot and the target then the
		* module will move as far as possible
		*/
		$sql = 'SELECT album_id, album_name, left_id, right_id
			FROM ' . $this->albums_table . ' 
			WHERE parent_id = ' . (int) $album_row['parent_id'] . '
				AND album_user_id = ' . (int) $this->user_id . '
				AND ' . (($action == 'move_up') ? 'right_id < ' . $album_row['right_id'] . ' ORDER BY right_id DESC' : 'left_id > ' . $album_row['left_id'] . ' ORDER BY left_id ASC');
		$result = $this->db->sql_query_limit($sql, $steps);

		$target = array();
		while ($row = $this->db->sql_fetchrow($result))
		{
			$target = $row;
		}
		$this->db->sql_freeresult($result);

		if (!sizeof($target))
		{
			// The album is already on top or bottom
			return false;
		}

		/**
		* $left_id and $right_id define the scope of the nodes that are affected by the move.
		* $diff_up and $diff_down are the values to subtract or add to each node's left_id
		* and right_id in order to move them up or down.
		* $move_up_left and $move_up_right define the scope of the nodes that are moving
		* up. Other nodes in the scope of ($left_id, $right_id) are considered to move down.
		*/
		if ($action == 'move_up')
		{
			$left_id = $target['left_id'];
			$right_id = $album_row['right_id'];

			$diff_up = $album_row['left_id'] - $target['left_id'];
			$diff_down = $album_row['right_id'] + 1 - $album_row['left_id'];

			$move_up_left = $album_row['left_id'];
			$move_up_right = $album_row['right_id'];
		}
		else
		{
			$left_id = $album_row['left_id'];
			$right_id = $target['right_id'];

			$diff_up = $album_row['right_id'] + 1 - $album_row['left_id'];
			$diff_down = $target['right_id'] - $album_row['right_id'];

			$move_up_left = $album_row['right_id'] + 1;
			$move_up_right = $target['right_id'];
		}

		// Now do the dirty job
		$sql = 'UPDATE ' . $this->albums_table . ' 
			SET left_id = left_id + CASE
				WHEN left_id BETWEEN ' . (int) $move_up_left . ' AND ' . (int) $move_up_right . ' THEN -' .(int) $diff_up . '
				ELSE ' .(int) $diff_down . '
			END,
			right_id = right_id + CASE
				WHEN right_id BETWEEN ' . (int) $move_up_left . ' AND ' . (int) $move_up_right . ' THEN -' . (int) $diff_up . '
				ELSE ' . (int) $diff_down . '
			END,
			album_parents = \'\'
			WHERE
				left_id BETWEEN ' . (int) $left_id . ' AND ' . (int) $right_id . '
				AND right_id BETWEEN ' . (int) $left_id . ' AND ' . (int) $right_id . '
				AND album_user_id = ' . (int) $this->user_id;
		$this->db->sql_query($sql);

		return $target['album_name'];
	}
}