sarala-io / sarala-laravel

src/Transformer/TransformerAbstract.php

<?php

declare(strict_types=1);

namespace Sarala\Transformer;

use Illuminate\Support\Arr;
use League\Fractal\TransformerAbstract as BaseTransformerAbstract;
use Sarala\Links;
use Sarala\Query\Fields;

abstract class TransformerAbstract extends BaseTransformerAbstract
{
    const REQUIRED_FIELDS = [
        'id',
    ];

    public function transform($data): array
    {
        $user = auth(config('sarala.guard'))->user();

        $links = $this->links($data, $user)->all();
        $meta = $this->meta($data, $user);
        $data = $this->filterFields($this->data($data));

The method data() does not exist on Sarala\Transformer\TransformerAbstract. Since it exists in all sub-types, consider adding an abstract or default implementation to Sarala\Transformer\TransformerAbstract.

        if (! empty($links)) {
            $data['links'] = $links;
        }

        if (! empty($meta)) {
            $data['meta'] = $meta;
        }

        return $data;
    }

    protected function links($model, $user = null): Links

The parameter $user is not used and could be removed.

The parameter $model is not used and could be removed.

    {
        return Links::make();
    }

    protected function meta($model, $user = null): array

The parameter $user is not used and could be removed.

The parameter $model is not used and could be removed.

    {
        return [];
    }

    private function filterFields(array $data): array
    {
        $resourceName = $this->getCurrentScope()->getResource()->getResourceKey();
        /** @var Fields $fields */
        $fields = request()->fields();

        if (! $fields->has($resourceName)) {
            return $data;
        }

        $fields = array_merge($fields->get($resourceName), self::REQUIRED_FIELDS);

It seems like $fields->get($resourceName) can also be of type null; however, parameter $arrays of array_merge() does only seem to accept array, maybe add an additional type check?

        return Arr::only($data, $fields);
    }
}