Sarala\Http\Middleware\ETag::handle()

Complexity

Conditions	4
Paths	3

Size

Total Lines

17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handle(Request $request, Closure $next)
    {
        $response = $next($request);

        if ($request->isMethod('get')) {
            $etag = md5($response->getContent());
            $requestEtag = str_replace('"', '', $request->getETags());

            if ($requestEtag && $requestEtag[0] == $etag) {

The expression $requestEtag of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $response->setNotModified();
            }

            $response->setEtag($etag);
        }

        return $response;
    }
}