SaralaServiceProvider::boot() - Code Metrics - Inspection of "Added countExact countAlias query helpers" - sarala-io/sarala-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Milroy

created 2019-01-27 10:59 UTC

SaralaServiceProvider::boot() A

↳ Parent: SaralaServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.568
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Sarala;

use Sarala\Query\Sorts;
use Sarala\Query\Fields;
use League\Fractal\Manager;
use Illuminate\Http\Request;
use Sarala\Query\QueryParamBag;
use Illuminate\Support\ServiceProvider;
use League\Fractal\Serializer\JsonApiSerializer;
use League\Fractal\Serializer\DataArraySerializer;

class SaralaServiceProvider extends ServiceProvider
{
    public function boot()
    {
        $this->publishes([
            __DIR__.'/../config/sarala.php' => config_path('sarala.php'),
        ], 'config');

        Request::macro('filters', function () {
            return new QueryParamBag($this, 'filter');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        });

        Request::macro('includes', function () {
            return new QueryParamBag($this, 'include');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        });

        Request::macro('fields', function () {
            return new Fields($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        });

        Request::macro('sorts', function () {
            return new Sorts($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        });
    }

    public function register(): void
    {
        $this->app->bind(JsonApiSerializer::class, function ($app) {

            return new JsonApiSerializer(config('sarala.base_url'));
        });

        $this->app->bind(DataArraySerializer::class, function ($app) {

            return new DataArraySerializer();
        });

        $this->app->bind(Manager::class, function ($app) {

            return (new Manager())->setSerializer(Sarala::resolve()->getSerializer());
        });
    }
}


1			<?php
2
3			namespace Sarala;
4
5			use Sarala\Query\Sorts;
6			use Sarala\Query\Fields;
7			use League\Fractal\Manager;
8			use Illuminate\Http\Request;
9			use Sarala\Query\QueryParamBag;
10			use Illuminate\Support\ServiceProvider;
11			use League\Fractal\Serializer\JsonApiSerializer;
12			use League\Fractal\Serializer\DataArraySerializer;
13
14			class SaralaServiceProvider extends ServiceProvider
15			{
16			public function boot()
17			{
18			$this->publishes([
19			__DIR__.'/../config/sarala.php' => config_path('sarala.php'),
20			], 'config');
21
22			Request::macro('filters', function () {
23			return new QueryParamBag($this, 'filter');
			0 ignored issues – show Documentation introduced 2019-01-27 10:59 UTC by Report Bug Copy Issue Report `$this` is of type `this<Sarala\SaralaServiceProvider>`, but the function expects a `object<Illuminate\Http\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24			});
25
26			Request::macro('includes', function () {
27			return new QueryParamBag($this, 'include');
			0 ignored issues – show Documentation introduced 2019-01-27 10:59 UTC by Report Bug Copy Issue Report `$this` is of type `this<Sarala\SaralaServiceProvider>`, but the function expects a `object<Illuminate\Http\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			});
29
30			Request::macro('fields', function () {
31			return new Fields($this);
			0 ignored issues – show Documentation introduced 2019-01-27 10:59 UTC by Report Bug Copy Issue Report `$this` is of type `this<Sarala\SaralaServiceProvider>`, but the function expects a `object<Illuminate\Http\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			});
33
34			Request::macro('sorts', function () {
35			return new Sorts($this);
			0 ignored issues – show Documentation introduced 2019-01-27 10:59 UTC by Report Bug Copy Issue Report `$this` is of type `this<Sarala\SaralaServiceProvider>`, but the function expects a `object<Illuminate\Http\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			});
37			}
38
39			public function register(): void
40			{
41			$this->app->bind(JsonApiSerializer::class, function ($app) {
			0 ignored issues – show Unused Code introduced 2019-01-23 13:20 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
42			return new JsonApiSerializer(config('sarala.base_url'));
43			});
44
45			$this->app->bind(DataArraySerializer::class, function ($app) {
			0 ignored issues – show Unused Code introduced 2019-01-23 13:20 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
46			return new DataArraySerializer();
47			});
48
49			$this->app->bind(Manager::class, function ($app) {
			0 ignored issues – show Unused Code introduced 2019-01-09 20:30 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
50			return (new Manager())->setSerializer(Sarala::resolve()->getSerializer());
51			});
52			}
53			}
54

sarala-io / sarala-laravel

Pull Request — master (#10)

SaralaServiceProvider::boot() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like