QueryHelper::appendExact() - Code Metrics - Inspection of "Merge pull request #10 from sarala-io/add-count-ex..." - sarala-io/sarala-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d78d08...71c71b )

by Milroy

created 2019-01-27 11:07 UTC

QueryHelper::appendExact() A

↳ Parent: QueryHelper

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.6
c	0
b	0
f	0
cc	4
nc	4
nop	2

<?php

declare(strict_types=1);

namespace Sarala\Query;

use Illuminate\Database\Eloquent\Builder;

class QueryHelper
{
    /** @var Builder $query */
    private $query;

    /** @var QueryParamBag $includes */
    private $includes;

    public function __construct(Builder $query, QueryParamBag $includes)
    {
        $this->query = $query;
        $this->includes = $includes;
    }

    public function exact($fields): self
    {
        return $this->appendExact($fields, 'appendQuery');
    }

    public function countExact($fields)
    {
        return $this->appendExact($fields, 'appendCountQuery');
    }

    private function appendExact($fields, $method)
    {
        if (is_string($fields)) {
            $this->{$method}($fields, $fields);

            return $this;
        }

        if (! is_array($fields)) {
            throw new \InvalidArgumentException(
                'Expects a string or an array. '.gettype($fields).' given'
            );
        }

        foreach (array_intersect($this->includes->keys(), $fields) as $field) {
            $this->{$method}($field, $field);
        }

        return $this;
    }

    public function alias($fields, $value = null): self
    {
        return $this->appendAlias($fields, $value, 'appendQuery');
    }

    public function countAlias($fields, $value = null)
    {
        return $this->appendAlias($fields, $value, 'appendCountQuery');
    }

    private function appendAlias($fields, $value, $method): self
    {
        if (is_array($fields) && is_null($value)) {
            foreach ($fields as $field => $value) {
                $this->{$method}($field, $value);
            }
        }

        if (is_string($fields) && ! is_null($value)) {
            $this->{$method}($fields, $value);
        }

        return $this;
    }

    private function appendCountQuery($field, $relationship)
    {
        if (is_string($relationship)) {
            $this->appendQuery($field, function ($query) use ($relationship) {
                $relationship = str_replace_last('Count', '', camel_case($relationship));
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)

                $query->withCount($relationship);
            });

            return;
        }

        throw new \InvalidArgumentException(
            'countAlias() method expects second parameter to be a string. '.gettype($relationship).' given'
        );
    }

    private function appendQuery($name, $value)
    {
        if (is_callable($value)) {
            $this->query->when($this->includes->has($name), $value);

            return;
        }

        $this->query->when($this->includes->has($name), function (Builder $query) use ($value) {
            $query->with($value);
        });
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Sarala\Query;
6
7			use Illuminate\Database\Eloquent\Builder;
8
9			class QueryHelper
10			{
11			/** @var Builder $query */
12			private $query;
13
14			/** @var QueryParamBag $includes */
15			private $includes;
16
17			public function __construct(Builder $query, QueryParamBag $includes)
18			{
19			$this->query = $query;
20			$this->includes = $includes;
21			}
22
23			public function exact($fields): self
24			{
25			return $this->appendExact($fields, 'appendQuery');
26			}
27
28			public function countExact($fields)
29			{
30			return $this->appendExact($fields, 'appendCountQuery');
31			}
32
33			private function appendExact($fields, $method)
34			{
35			if (is_string($fields)) {
36			$this->{$method}($fields, $fields);
37
38			return $this;
39			}
40
41			if (! is_array($fields)) {
42			throw new \InvalidArgumentException(
43			'Expects a string or an array. '.gettype($fields).' given'
44			);
45			}
46
47			foreach (array_intersect($this->includes->keys(), $fields) as $field) {
48			$this->{$method}($field, $field);
49			}
50
51			return $this;
52			}
53
54			public function alias($fields, $value = null): self
55			{
56			return $this->appendAlias($fields, $value, 'appendQuery');
57			}
58
59			public function countAlias($fields, $value = null)
60			{
61			return $this->appendAlias($fields, $value, 'appendCountQuery');
62			}
63
64			private function appendAlias($fields, $value, $method): self
65			{
66			if (is_array($fields) && is_null($value)) {
67			foreach ($fields as $field => $value) {
68			$this->{$method}($field, $value);
69			}
70			}
71
72			if (is_string($fields) && ! is_null($value)) {
73			$this->{$method}($fields, $value);
74			}
75
76			return $this;
77			}
78
79			private function appendCountQuery($field, $relationship)
80			{
81			if (is_string($relationship)) {
82			$this->appendQuery($field, function ($query) use ($relationship) {
83			$relationship = str_replace_last('Count', '', camel_case($relationship));
			0 ignored issues – show Bug introduced 2019-01-27 10:59 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$relationship`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
84
85			$query->withCount($relationship);
86			});
87
88			return;
89			}
90
91			throw new \InvalidArgumentException(
92			'countAlias() method expects second parameter to be a string. '.gettype($relationship).' given'
93			);
94			}
95
96			private function appendQuery($name, $value)
97			{
98			if (is_callable($value)) {
99			$this->query->when($this->includes->has($name), $value);
100
101			return;
102			}
103
104			$this->query->when($this->includes->has($name), function (Builder $query) use ($value) {
105			$query->with($value);
106			});
107			}
108			}
109

sarala-io / sarala-laravel

Push — master ( d78d08...71c71b )

QueryHelper::appendExact() A

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like