ArticleController::one() - Code Metrics - Inspection of "Merged branch master into development" - sant0ro/chocolatey - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( e2df92...98c85a )

by Claudio

created 2017-02-14 03:31 UTC

ArticleController::one() A

↳ Parent: ArticleController

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	2
eloc	9
nc	2
nop	2

<?php

namespace App\Http\Controllers;

use App\Models\Article;
use App\Models\ArticleCategory;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Laravel\Lumen\Routing\Controller as BaseController;

/**
 * Class ArticleController
 * @package App\Http\Controllers
 */
class ArticleController extends BaseController
{
    /**
     * Render a specific view of Article set
     *
     * @param string $countryId
     * @param string $articleCategory
     * @return Response
     */
    public function many(string $countryId, string $articleCategory): Response
    {
        $category = ArticleCategory::find(strstr(($articleCategory =
            str_replace('.html', '', $articleCategory)), '_', true));

        $categoryPage = strstr(strrev($articleCategory), '_', true);

        return $articleCategory == 'front' ? $this->front() :
            $this->category($countryId, $category, $categoryPage,
                $categoryPage == 1 ? 0 : (10 * ($categoryPage - 1)));
    }

    /**
     * Render the Front Page of the Articles Page
     *
     * @return Response
     */
    protected function front(): Response
    {
        return response(view('habbo-web-news.articles-front', ['set' =>
            Article::orderBy('id', 'ASC')->limit(10)->get()]));
    }

    /**
     * Render a specific Category Articles Page
     *
     * @TODO: Proper Way to use Country ID
     *
     * @param string $countryId
     * @param ArticleCategory $category
     * @param int $categoryPage
     * @param int $start
     * @return Response
     */
    protected function category(string $countryId, ArticleCategory $category, int $categoryPage, int $start): Response

    {
        $articles = Article::where('id', '>=', $start)
            ->limit(10)->get()->filter(function ($item) use ($category) {
                return $category->name == 'all' || in_array($category, $item->categories);
            });

        if ($articles->count() == 0)
            return response()->json(null, 404);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return response(view('habbo-web-news.articles-category', [
            'category' => $category,
            'page' => $categoryPage,
            'categories' => ArticleCategory::all(),
            'articles' => $articles
        ]));
    }

    /**
     * Render a specific view of a specific Article
     *
     * @TODO: Proper Way to use Country ID
     *
     * @param string $countryId
     * @param string $articleName
     * @return Response
     */
    public function one(string $countryId, string $articleName): Response

    {
        if (($article = Article::find(strstr($articleName, '_', true))) == null)
            return response()->json(null, 404);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $related = ($latest = Article::all())->filter(function ($item) use ($article) {
            return in_array($article->categories[0], $item->categories);
        });

        return response(view('habbo-web-news.articles-view', [
            'article' => $article,
            'latest' => $latest->slice(0, 5),
            'related' => $related->slice(0, 5)
        ]));
    }

    /**
     * Get All Habbo Articles as XML/RSS
     *
     * @param Request $request
     * @return Response
     */
    public function getRss(Request $request)

    {
        return response(view('habbo-rss', [
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'articles' => Article::limit(20)->get()
        ]))->header('Content-Type', 'text/xml');
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Models\Article;
6			use App\Models\ArticleCategory;
7			use Illuminate\Http\Request;
8			use Illuminate\Http\Response;
9			use Laravel\Lumen\Routing\Controller as BaseController;
10
11			/**
12			* Class ArticleController
13			* @package App\Http\Controllers
14			*/
15			class ArticleController extends BaseController
16			{
17			/**
18			* Render a specific view of Article set
19			*
20			* @param string $countryId
21			* @param string $articleCategory
22			* @return Response
23			*/
24			public function many(string $countryId, string $articleCategory): Response
25			{
26			$category = ArticleCategory::find(strstr(($articleCategory =
27			str_replace('.html', '', $articleCategory)), '_', true));
28
29			$categoryPage = strstr(strrev($articleCategory), '_', true);
30
31			return $articleCategory == 'front' ? $this->front() :
32			$this->category($countryId, $category, $categoryPage,
33			$categoryPage == 1 ? 0 : (10 * ($categoryPage - 1)));
34			}
35
36			/**
37			* Render the Front Page of the Articles Page
38			*
39			* @return Response
40			*/
41			protected function front(): Response
42			{
43			return response(view('habbo-web-news.articles-front', ['set' =>
44			Article::orderBy('id', 'ASC')->limit(10)->get()]));
45			}
46
47			/**
48			* Render a specific Category Articles Page
49			*
50			* @TODO: Proper Way to use Country ID
51			*
52			* @param string $countryId
53			* @param ArticleCategory $category
54			* @param int $categoryPage
55			* @param int $start
56			* @return Response
57			*/
58			protected function category(string $countryId, ArticleCategory $category, int $categoryPage, int $start): Response
			0 ignored issues – show Unused Code introduced 2017-02-09 18:05 UTC by Report Bug Copy Issue Report The parameter `$countryId` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
59			{
60			$articles = Article::where('id', '>=', $start)
61			->limit(10)->get()->filter(function ($item) use ($category) {
62			return $category->name == 'all' \|\| in_array($category, $item->categories);
63			});
64
65			if ($articles->count() == 0)
66			return response()->json(null, 404);
			0 ignored issues – show Bug introduced 2017-02-14 03:33 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Laravel\Lumen\Http\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
67
68			return response(view('habbo-web-news.articles-category', [
69			'category' => $category,
70			'page' => $categoryPage,
71			'categories' => ArticleCategory::all(),
72			'articles' => $articles
73			]));
74			}
75
76			/**
77			* Render a specific view of a specific Article
78			*
79			* @TODO: Proper Way to use Country ID
80			*
81			* @param string $countryId
82			* @param string $articleName
83			* @return Response
84			*/
85			public function one(string $countryId, string $articleName): Response
			0 ignored issues – show Unused Code introduced 2017-01-31 02:42 UTC by Report Bug Copy Issue Report The parameter `$countryId` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
86			{
87			if (($article = Article::find(strstr($articleName, '_', true))) == null)
88			return response()->json(null, 404);
			0 ignored issues – show Bug introduced 2017-02-14 03:33 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Laravel\Lumen\Http\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
89
90			$related = ($latest = Article::all())->filter(function ($item) use ($article) {
91			return in_array($article->categories[0], $item->categories);
92			});
93
94			return response(view('habbo-web-news.articles-view', [
95			'article' => $article,
96			'latest' => $latest->slice(0, 5),
97			'related' => $related->slice(0, 5)
98			]));
99			}
100
101			/**
102			* Get All Habbo Articles as XML/RSS
103			*
104			* @param Request $request
105			* @return Response
106			*/
107			public function getRss(Request $request)
			0 ignored issues – show Unused Code introduced 2017-02-14 03:33 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
108			{
109			return response(view('habbo-rss', [
			0 ignored issues – show Bug introduced 2017-02-14 03:33 UTC by Report Bug Copy Issue Report The method `header` does only exist in `Illuminate\Http\Response`, but not in `Laravel\Lumen\Http\ResponseFactory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
110			'articles' => Article::limit(20)->get()
111			]))->header('Content-Type', 'text/xml');
112			}
113			}
114

sant0ro / chocolatey

Push — development ( e2df92...98c85a )

ArticleController::one() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like