AccountController::uniqueName() - Code Metrics - Inspection of "Fix" - sant0ro/chocolatey - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — development ( 7b263d...51bdc1 )

by Claudio
created 2017-03-29 02:59 UTC
AccountController::uniqueName() A

↳ Parent: Project
Complexity

Conditions	1
Paths	1
Size

Total Lines	9
Code Lines	5
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	1
<?php

namespace App\Http\Controllers;

use App\Facades\Nux;
use App\Facades\Session;
use App\Models\ChocolateyId;
use App\Models\User;
use App\Models\UserPreferences;
use App\Models\UserSettings;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Illuminate\Support\Facades\Config;
use Laravel\Lumen\Routing\Controller as BaseController;

/**
 * Class AccountController
 * @package App\Http\Controllers
 */
class AccountController extends BaseController
{
    /**
     * Check an User Name
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function checkName(Request $request): JsonResponse
    {
        if (User::where('username', $request->json()->get('name'))->count() > 0 && $request->json()->get('name') != $request->user()->name)
            return response()->json(['code' => 'NAME_IN_USE', 'validationResult' => null, 'suggestions' => []]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        if (strlen($request->json()->get('name')) > 50 || !$this->filterName($request->json()->get('name')))
            return response()->json(['code' => 'INVALID_NAME', 'validationResult' => ['resultType' => 'VALIDATION_ERROR_ILLEGAL_WORDS'], 'suggestions' => []]);

        return response()->json(['code' => 'OK', 'validationResult' => null, 'suggestions' => []]);
    }

    /**
     * Filter an Username from the Invalid Names Base
     *
     * @param string $userName
     * @return bool
     */
    protected function filterName(string $userName): bool
    {
        return count(array_filter(Config::get('chocolatey.invalid'), function ($username) use ($userName) {
                return strpos($userName, $username) !== false;
            })) == 0;
    }

    /**
     * Select an User Name
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function selectName(Request $request): JsonResponse
    {
        $request->user()->update(['username' => $request->json()->get('name')]);

        Session::set(Config::get('chocolatey.security.session'), $request->user());

        return response()->json(['code' => 'OK', 'validationResult' => null, 'suggestions' => []]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Save User Look
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function saveLook(Request $request): JsonResponse
    {
        $request->user()->update([
            'look' => $request->json()->get('figure'),
            'gender' => $request->json()->get('gender')]);

        Session::set(Config::get('chocolatey.security.session'), $request->user());

        return response()->json($request->user());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Select a Room
     *
     * @TODO: Generate the Room for the User
     * @TODO: Get Room Models.
     *
     * @param Request $request
     * @return Response
     */
    public function selectRoom(Request $request): Response
    {
        if (!in_array($request->json()->get('roomIndex'), [1, 2, 3]))
            return response('', 400);

        $nuxRoom = Nux::generateRoom($request);

        $request->user()->traits = $nuxRoom ? ["USER"] : ["NEW_USER", "USER"];

        return response('', $nuxRoom ? 200 : 400);
    }

    /**
     * Get User Non Read Messenger Discussions
     *
     * @TODO: Code Integration with HabboMessenger
     * @TODO: Create Messenger Model
     *
     * @return JsonResponse
     */
    public function getDiscussions(): JsonResponse
    {
        return response()->json([]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Get User Preferences
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function getPreferences(Request $request): JsonResponse
    {
        $userPreferences = UserPreferences::find($request->user()->uniqueId);

        foreach ($userPreferences->getAttributes() as $attributeName => $attributeValue)
            $userPreferences->{$attributeName} = $attributeValue == 1;

        return response()->json($userPreferences);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Save New User Preferences
     *
     * @param Request $request
     * @return Response
     */
    public function savePreferences(Request $request): Response
    {
        UserSettings::updateOrCreate(['user_id' => $request->user()->uniqueId], [
            'block_following' => $request->json()->get('friendCanFollow') == false ? '1' : '0',
            'block_friendrequests' => $request->json()->get('friendRequestEnabled') == false ? '1' : '0'
        ]);

        foreach ((array)$request->json()->all() as $setting => $value)
            UserPreferences::find($request->user()->uniqueId)->update([$setting => $value == true ? '1' : '0']);

        return response('');
    }

    /**
     * Get All E-Mail Accounts
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function getAvatars(Request $request): JsonResponse
    {
        $azureIdAccounts = ChocolateyId::where('mail', $request->user()->email)->first();

        return response()->json($azureIdAccounts->relatedAccounts);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Check if an Username is available
     * for a new Avatar Account
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function checkNewName(Request $request): JsonResponse
    {
        if (User::where('username', $request->input('name'))->count() > 0 || !$this->filterName($request->input('name')))

            return response()->json(['isAvailable' => false]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return response()->json(['isAvailable' => true]);
    }

    /**
     * Create a New User Avatar
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function createAvatar(Request $request): JsonResponse
    {
        if (User::where('username', $request->json()->get('name'))->count() > 0 || !$this->filterName($request->json()->get('name')))

            return response()->json(['isAvailable' => false]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $request->user()->name = $request->json()->get('name');

        $this->createUser($request, $request->user()->getAttributes());

        return response()->json('');
    }

    /**
     * Create a New User
     *
     * @param Request $request
     * @param array $userInfo
     * @param bool $newUser If is a New User
     * @return User
     */
    public function createUser(Request $request, array $userInfo, bool $newUser = false): User
    {
        $userName = $newUser ? $this->uniqueName($userInfo['email']) : $userInfo['username'];
        $userMail = $newUser ? $userInfo['email'] : $userInfo['mail'];

        $mailController = new MailController;

        $mailController->send(['mail' => $userMail, 'name' => $userName, 'subject' => 'Welcome to ' . Config::get('chocolatey.name'),
            'url' => "/activate/{$mailController->prepare($userMail, 'public/registration/activate')}", 'sendMail' => $userMail
        ]);

        $userData = new User;
        $userData->store($userName, $userInfo['password'], $userMail, $request->ip())->save();
        $userData->createData();

        Session::set(Config::get('chocolatey.security.session'), $userData);

        return $userData;
    }

    /**
     * Create Random Unique Username
     *
     * @WARNING: Doesn't create Like Habbo Way
     *
     * @param string $userMail
     * @return string
     */
    protected function uniqueName(string $userMail): string
    {
        $partialMail = strstr($userMail, '@', true);

        $firstPart = substr(uniqid(), 0, 4);
        $secondPart = substr(uniqid(), 6, 10);

        return $firstPart . $partialMail . $secondPart;
    }

    /**
     * Change Logged In User
     *
     * @param Request $request
     */
    public function selectAvatar(Request $request)
    {
        $userData = User::find($request->json()->get('uniqueId'));

        Session::set(Config::get('chocolatey.security.session'), $userData);
    }

    /**
     * Confirm E-Mail Activation
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function confirmActivation(Request $request): JsonResponse
    {
        if (($mail = (new MailController)->getMail($request->json()->get('token'))) == null)

            return response()->json(['error' => 'activation.invalid_token'], 400);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        if (strpos($mail->link, 'change-email') !== false):
            $mail = str_replace('change-email/', '', $mail->link);

            User::where('mail', $mail->mail)->update(['mail' => $mail]);

            ChocolateyId::where('mail', $mail->mail)->update(['mail' => $mail]);
        endif;

        User::where('mail', $mail->mail)->update(['mail_verified' => '1']);

        return response()->json(['email' => $mail->mail, 'emailVerified' => true, 'identityVerified' => true]);
    }

    /**
     * Send User Forgot E-Mail
     *
     * @param Request $request
     * @return JsonResponse
     */
    public function forgotPassword(Request $request): JsonResponse
    {
        if (($user = User::where('mail', $request->json()->get('email'))->first()) == null)
            return response()->json(['email' => $request->json()->get('email')]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $mailController = new MailController;

        $mailController->send(['name' => $user->name, 'mail' => $user->email, 'sendMail' => $user->email, 'subject' => 'Password reset confirmation',
            'url' => "/reset-password/{$mailController->prepare($user->email, 'public/forgotPassword')}"
        ], 'habbo-web-mail.password-reset');

        return response()->json(['email' => $user->email]);
    }

    /**
     * Send an Account Confirmation E-Mail
     *
     * @param Request $request
     * @return Response
     */
    public function verifyAccount(Request $request): Response
    {
        $mailController = new MailController;

        $mailController->send(['name' => $request->user()->name, 'mail' => $request->user()->email, 'subject' => 'Welcome to ' . Config::get('chocolatey.name'),
            'url' => "/activate/{$mailController->prepare($request->user()->email, 'public/registration/activate')}", 'sendMail' => $request->user()->email
        ]);

        return response(null);
    }
}

Push — development ( 7b263d...51bdc1 )

AccountController::uniqueName() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

sant0ro / chocolatey

Push — development ( 7b263d...51bdc1 )

AccountController::uniqueName() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
