RoomItem::store() - Code Metrics - sant0ro/chocolatey - Measure and Improve Code Quality continuously with Scrutinizer

RoomItem::store() A
last analyzed 2017-11-06 14:00 UTC

↳ Parent: RoomItem

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	14
nc	2
nop	9

How to fix Many Parameters

<?php

namespace App\Models;

/**
 * Class RoomItem.
 */
class RoomItem extends ChocolateyModel
{
    /**
     * Disable Timestamps.
     *
     * @var bool
     */
    public $timestamps = false;

    /**
     * The table associated with the model.
     *
     * @var string
     */
    protected $table = 'items';

    /**
     * Primary Key of the Table.
     *
     * @var string
     */
    protected $primaryKey = 'id';

    /**
     * Store a RoomItem.
     *
     * @param int    $userId
     * @param int    $roomId
     * @param int    $itemId
     * @param int    $xPosition
     * @param int    $yPosition
     * @param string $zPosition
     * @param int    $rotation
     * @param string $extraData
     * @param string $wallPosition
     *
     * @return RoomItem
     */
    public function store(int $userId, int $roomId, int $itemId, int $xPosition, int $yPosition, string $zPosition, int $rotation, string $extraData, string $wallPosition = ''): RoomItem
    {
        $this->attributes['user_id'] = $userId;
        $this->attributes['room_id'] = $roomId;
        $this->attributes['item_id'] = $itemId;
        $this->attributes['x'] = $xPosition;
        $this->attributes['y'] = $yPosition;
        $this->attributes['z'] = $zPosition;
        $this->attributes['rot'] = $rotation;
        $this->attributes['extra_data'] = $extraData;
        $this->timestamps = false;

        if (!empty($wallPosition)) {
            $this->attributes['wall_pos'] = $wallPosition;
        }

        $this->save();

        return $this;
    }
}


1			<?php
2
3			namespace App\Models;
4
5			/**
6			* Class RoomItem.
7			*/
8			class RoomItem extends ChocolateyModel
9			{
10			/**
11			* Disable Timestamps.
12			*
13			* @var bool
14			*/
15			public $timestamps = false;
16
17			/**
18			* The table associated with the model.
19			*
20			* @var string
21			*/
22			protected $table = 'items';
23
24			/**
25			* Primary Key of the Table.
26			*
27			* @var string
28			*/
29			protected $primaryKey = 'id';
30
31			/**
32			* Store a RoomItem.
33			*
34			* @param int $userId
35			* @param int $roomId
36			* @param int $itemId
37			* @param int $xPosition
38			* @param int $yPosition
39			* @param string $zPosition
40			* @param int $rotation
41			* @param string $extraData
42			* @param string $wallPosition
43			*
44			* @return RoomItem
45			*/
46			public function store(int $userId, int $roomId, int $itemId, int $xPosition, int $yPosition, string $zPosition, int $rotation, string $extraData, string $wallPosition = ''): RoomItem
47			{
48			$this->attributes['user_id'] = $userId;
49			$this->attributes['room_id'] = $roomId;
50			$this->attributes['item_id'] = $itemId;
51			$this->attributes['x'] = $xPosition;
52			$this->attributes['y'] = $yPosition;
53			$this->attributes['z'] = $zPosition;
54			$this->attributes['rot'] = $rotation;
55			$this->attributes['extra_data'] = $extraData;
56			$this->timestamps = false;
57
58			if (!empty($wallPosition)) {
59			$this->attributes['wall_pos'] = $wallPosition;
60			}
61
62			$this->save();
63
64			return $this;
65			}
66			}
67

sant0ro / chocolatey

RoomItem::store() A last analyzed 2017-11-06 14:00 UTC

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like

RoomItem::store() A
last analyzed 2017-11-06 14:00 UTC