Authenticate::handle() - Code Metrics - sant0ro/chocolatey - Measure and Improve Code Quality continuously with Scrutinizer

Authenticate::handle() A
last analyzed 2017-11-06 14:00 UTC

↳ Parent: Authenticate

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	3

<?php

namespace App\Http\Middleware;

use Closure;
use Illuminate\Contracts\Auth\Factory as Auth;

class Authenticate
{
	/**
	 * The authentication guard factory instance.
	 *
	 * @var \Illuminate\Contracts\Auth\Factory
	 */
	protected $auth;

	/**
	 * Create a new middleware instance.
	 *
	 * @param  \Illuminate\Contracts\Auth\Factory $auth
	 */
	public function __construct(Auth $auth)
	{
		$this->auth = $auth;
	}

	/**
	 * Handle an incoming request.
	 *
	 * @param  \Illuminate\Http\Request $request
	 * @param  \Closure $next
	 * @param  string|null $guard
	 * @return mixed
	 */
	public function handle($request, Closure $next, $guard = null)
	{
		if ($this->auth->guard($guard)->guest()) {
			return response()->json(['message' => 'authentication-needed'], 401);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		}

		if ($request->user()->isBanned == true) {
			return response('Unauthorized.', 401);
		}

		return $next($request);
	}
}

1			<?php
2
3			namespace App\Http\Middleware;
4
5			use Closure;
6			use Illuminate\Contracts\Auth\Factory as Auth;
7
8			class Authenticate
9			{
10			/**
11			* The authentication guard factory instance.
12			*
13			* @var \Illuminate\Contracts\Auth\Factory
14			*/
15			protected $auth;
16
17			/**
18			* Create a new middleware instance.
19			*
20			* @param \Illuminate\Contracts\Auth\Factory $auth
21			*/
22			public function __construct(Auth $auth)
23			{
24			$this->auth = $auth;
25			}
26
27			/**
28			* Handle an incoming request.
29			*
30			* @param \Illuminate\Http\Request $request
31			* @param \Closure $next
32			* @param string\|null $guard
33			* @return mixed
34			*/
35			public function handle($request, Closure $next, $guard = null)
36			{
37			if ($this->auth->guard($guard)->guest()) {
38			return response()->json(['message' => 'authentication-needed'], 401);
			0 ignored issues – show Bug introduced 2017-01-31 17:43 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Laravel\Lumen\Http\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
39			}
40
41			if ($request->user()->isBanned == true) {
42			return response('Unauthorized.', 401);
43			}
44
45			return $next($request);
46			}
47			}

sant0ro / chocolatey

Authenticate::handle() A last analyzed 2017-11-06 14:00 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

Authenticate::handle() A
last analyzed 2017-11-06 14:00 UTC