Session::destroy() - Code Metrics - sant0ro/chocolatey - Measure and Improve Code Quality continuously with Scrutinizer

Session::destroy() A
last analyzed 2017-11-06 14:00 UTC

↳ Parent: Session

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace App\Helpers;

use App\Singleton;

/**
 * Class Session.
 */
final class Session extends Singleton
{
    /**
     * Rename the Session ID.
     *
     * @param string $name
     */
    public function rename($name)
    {
        session_name($name);
    }

    /**
     * Start Session Handler.
     */
    public function start()
    {
        @session_start();
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }

    /**
     * Stop Session Handler.
     */
    public function destroy()
    {
        @session_destroy();
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }

    /**
     * Store a Variable in the Session.
     *
     * @param string $key
     * @param mixed  $value
     *
     * @return mixed
     */
    public function set($key, $value)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SESSION[$key] = $value;

        return $value;
    }

    /**
     * Get a Attribute Value from Session.
     *
     * @param string $key
     *
     * @return mixed
     */
    public function get($key)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return $this->has($key) ? $_SESSION[$key] : null;
    }

    /**
     * Check if a Key exists in the Session.
     *
     * @param mixed $key
     *
     * @return bool
     */
    public function has($key)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return array_key_exists($key, $_SESSION);
    }

    /**
     * Erase a Attribute from Session.
     *
     * @param string $key
     */
    public function erase($key)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SESSION[$key] = null;

        unset($_SESSION[$key]);
    }
}


1			<?php
2
3			namespace App\Helpers;
4
5			use App\Singleton;
6
7			/**
8			* Class Session.
9			*/
10			final class Session extends Singleton
11			{
12			/**
13			* Rename the Session ID.
14			*
15			* @param string $name
16			*/
17			public function rename($name)
18			{
19			session_name($name);
20			}
21
22			/**
23			* Start Session Handler.
24			*/
25			public function start()
26			{
27			@session_start();
			0 ignored issues – show Security Best Practice introduced 2017-04-23 20:30 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
28			}
29
30			/**
31			* Stop Session Handler.
32			*/
33			public function destroy()
34			{
35			@session_destroy();
			0 ignored issues – show Security Best Practice introduced 2017-08-05 22:32 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
36			}
37
38			/**
39			* Store a Variable in the Session.
40			*
41			* @param string $key
42			* @param mixed $value
43			*
44			* @return mixed
45			*/
46			public function set($key, $value)
			0 ignored issues – show Coding Style introduced 2017-08-05 22:32 UTC by Report Bug Copy Issue Report `set` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
47			{
48			$_SESSION[$key] = $value;
49
50			return $value;
51			}
52
53			/**
54			* Get a Attribute Value from Session.
55			*
56			* @param string $key
57			*
58			* @return mixed
59			*/
60			public function get($key)
			0 ignored issues – show Coding Style introduced 2017-08-05 22:32 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
61			{
62			return $this->has($key) ? $_SESSION[$key] : null;
63			}
64
65			/**
66			* Check if a Key exists in the Session.
67			*
68			* @param mixed $key
69			*
70			* @return bool
71			*/
72			public function has($key)
			0 ignored issues – show Coding Style introduced 2017-08-05 22:32 UTC by Report Bug Copy Issue Report `has` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
73			{
74			return array_key_exists($key, $_SESSION);
75			}
76
77			/**
78			* Erase a Attribute from Session.
79			*
80			* @param string $key
81			*/
82			public function erase($key)
			0 ignored issues – show Coding Style introduced 2017-08-05 22:32 UTC by Report Bug Copy Issue Report `erase` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
83			{
84			$_SESSION[$key] = null;
85
86			unset($_SESSION[$key]);
87			}
88			}
89

sant0ro / chocolatey

Session::destroy() A last analyzed 2017-11-06 14:00 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Session::destroy() A
last analyzed 2017-11-06 14:00 UTC