| Conditions | 1 |
| Paths | 1 |
| Total Lines | 61 |
| Code Lines | 53 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 85 | protected function createPoolRoom(User $user): bool |
||
| 86 | { |
||
| 87 | $room = (new Room())->store("{$user->name}'s room", "{$user->name} has entered the building", 'model_h', 25, 12, 307, 3104, 1.10, $user->uniqueId, $user->name); |
||
| 88 | |||
| 89 | $user->update(['home_room' => $room->id]); |
||
| 90 | |||
| 91 | // Floor Items |
||
| 92 | (new RoomItem())->store($user->uniqueId, $room->id, 16715, 5, 11, 1.30000, 0, ''); |
||
| 93 | (new RoomItem())->store($user->uniqueId, $room->id, 16732, 3, 10, 0.40000, 0, ''); |
||
| 94 | (new RoomItem())->store($user->uniqueId, $room->id, 17016, 3, 9, 0.00000, 2, '1'); |
||
| 95 | (new RoomItem())->store($user->uniqueId, $room->id, 17016, 3, 11, 0.00000, 0, ''); |
||
| 96 | (new RoomItem())->store($user->uniqueId, $room->id, 17016, 4, 9, 0.00000, 4, ''); |
||
| 97 | (new RoomItem())->store($user->uniqueId, $room->id, 17090, 3, 9, 0.00000, 2, '1'); |
||
| 98 | (new RoomItem())->store($user->uniqueId, $room->id, 17176, 3, 9, 0.00000, 0, ''); |
||
| 99 | (new RoomItem())->store($user->uniqueId, $room->id, 17176, 3, 9, 0.40000, 0, ''); |
||
| 100 | (new RoomItem())->store($user->uniqueId, $room->id, 17176, 3, 10, 0.00000, 0, ''); |
||
| 101 | (new RoomItem())->store($user->uniqueId, $room->id, 17190, 3, 11, 0.00000, 2, ''); |
||
| 102 | (new RoomItem())->store($user->uniqueId, $room->id, 17190, 4, 9, 0.00000, 4, ''); |
||
| 103 | (new RoomItem())->store($user->uniqueId, $room->id, 17191, 3, 10, 0.40000, 2, ''); |
||
| 104 | (new RoomItem())->store($user->uniqueId, $room->id, 17191, 3, 12, 0.00000, 2, ''); |
||
| 105 | (new RoomItem())->store($user->uniqueId, $room->id, 17484, 8, 3, 1.00000, 0, '0', 0); |
||
| 106 | (new RoomItem())->store($user->uniqueId, $room->id, 17499, 7, 3, 1.00000, 2, ''); |
||
| 107 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 7, 2, 1.00000, 0, ''); |
||
| 108 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 7, 4, 1.00000, 0, ''); |
||
| 109 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 7, 5, 1.00000, 0, ''); |
||
| 110 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 8, 2, 1.00000, 0, ''); |
||
| 111 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 8, 5, 1.00000, 0, ''); |
||
| 112 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 9, 2, 1.00000, 0, ''); |
||
| 113 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 9, 5, 1.00000, 0, ''); |
||
| 114 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 10, 2, 1.00000, 0, ''); |
||
| 115 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 10, 3, 1.00000, 0, ''); |
||
| 116 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 10, 4, 1.00000, 0, ''); |
||
| 117 | (new RoomItem())->store($user->uniqueId, $room->id, 17520, 10, 5, 1.00000, 0, ''); |
||
| 118 | (new RoomItem())->store($user->uniqueId, $room->id, 17987, 5, 11, 0.00000, 0, ''); |
||
| 119 | (new RoomItem())->store($user->uniqueId, $room->id, 18051, 5, 2, 1.00000, 0, ''); |
||
| 120 | (new RoomItem())->store($user->uniqueId, $room->id, 18051, 5, 4, 1.00000, 0, ''); |
||
| 121 | (new RoomItem())->store($user->uniqueId, $room->id, 18051, 8, 9, 0.00000, 0, ''); |
||
| 122 | (new RoomItem())->store($user->uniqueId, $room->id, 18051, 8, 11, 0.00000, 0, ''); |
||
| 123 | (new RoomItem())->store($user->uniqueId, $room->id, 18051, 9, 9, 0.00000, 0, ''); |
||
| 124 | (new RoomItem())->store($user->uniqueId, $room->id, 18051, 9, 11, 0.00000, 0, ''); |
||
| 125 | (new RoomItem())->store($user->uniqueId, $room->id, 18061, 8, 8, 0.00000, 2, ''); |
||
| 126 | (new RoomItem())->store($user->uniqueId, $room->id, 18061, 8, 9, 0.00000, 6, '1'); |
||
| 127 | (new RoomItem())->store($user->uniqueId, $room->id, 18061, 10, 8, 0.00000, 4, '1'); |
||
| 128 | (new RoomItem())->store($user->uniqueId, $room->id, 18070, 8, 2, 1.50000, 0, '1'); |
||
| 129 | (new RoomItem())->store($user->uniqueId, $room->id, 18079, 9, 8, 0.00000, 0, '1'); |
||
| 130 | (new RoomItem())->store($user->uniqueId, $room->id, 18363, 3, 9, 0.80000, 0, '2'); |
||
| 131 | |||
| 132 | // Wall Items |
||
| 133 | (new RoomItem())->store($user->uniqueId, $room->id, 22996, 0, 0, '0', 0, '', ':w=4,8 l=7,45 r'); |
||
| 134 | (new RoomItem())->store($user->uniqueId, $room->id, 22996, 0, 0, '0', 0, '', ':w=4,8 l=9,45 l'); |
||
| 135 | (new RoomItem())->store($user->uniqueId, $room->id, 23063, 0, 0, '0', 0, '', ':w=2,10 l=10,56 l'); |
||
| 136 | (new RoomItem())->store($user->uniqueId, $room->id, 23063, 0, 0, '0', 0, '', ':w=2,11 l=6,58 l'); |
||
| 137 | (new RoomItem())->store($user->uniqueId, $room->id, 23078, 0, 0, '0', 0, '1', ':w=6,1 l=0,26 r'); |
||
| 138 | (new RoomItem())->store($user->uniqueId, $room->id, 23078, 0, 0, '0', 0, '3', ':w=7,1 l=4,28 r'); |
||
| 139 | (new RoomItem())->store($user->uniqueId, $room->id, 23078, 0, 0, '0', 0, '1', ':w=8,1 l=13,33 r'); |
||
| 140 | (new RoomItem())->store($user->uniqueId, $room->id, 23078, 0, 0, '0', 0, '3', ':w=10,1 l=0,26 r'); |
||
| 141 | (new RoomItem())->store($user->uniqueId, $room->id, 23229, 0, 0, '0', 0, '1', ':w=4,3 l=6,49 l'); |
||
| 142 | (new RoomItem())->store($user->uniqueId, $room->id, 23229, 0, 0, '0', 0, '1', ':w=4,5 l=11,45 l'); |
||
| 143 | |||
| 144 | return true; |
||
| 145 | } |
||
| 146 | |||
| 191 |
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: