App\Http\Controllers\PhotosController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	4	1
A	report()	0	6	1
A	delete()	0	12	3
A	likePhoto()	0	10	2
A	unlikePhoto()	0	10	2

<?php

namespace App\Http\Controllers;

use App\Facades\User as UserFacade;
use App\Models\Photo;
use App\Models\PhotoLike;
use App\Models\PhotoReport;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Laravel\Lumen\Routing\Controller as BaseController;

/**
 * Class PhotosController.
 */
class PhotosController extends BaseController
{
    /**
     * Render a set of Public HabboWEB Photos.
     *
     * @TODO: Exclude Approved Reported Photos from the List
     *
     * @return JsonResponse
     */
    public function show(): JsonResponse
    {
        return response()->json(Photo::all(), 200, [], JSON_UNESCAPED_SLASHES);

It seems like \App\Models\Photo::all() targeting Illuminate\Database\Eloquent\Model::all() can also be of type object<Illuminate\Database\Eloquent\Collection>; however, Laravel\Lumen\Http\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

The method json does only exist in Laravel\Lumen\Http\ResponseFactory, but not in Illuminate\Http\Response.

    }

    /**
     * Register a Report of a Photo
     * Observation.: We will not create a limit of max reports.
     * Since it's a retro we don't really care about reports.
     *
     * @MODERATION: Reporting Status (0 = Not Reviewed, 1 = Report Approved, 2 = Report Not Approved
     *
     * @param Request $request
     * @param int     $photoId
     *
     * @return Response
     */
    public function report(Request $request, int $photoId): Response
    {
        (new PhotoReport())->store($photoId, $request->json()->get('reason'), UserFacade::getUser()->uniqueId);

        return response(null);
    }

    /**
     * Like a Photo.
     *
     * @param int $photoId
     *
     * @return Response
     */
    public function likePhoto(int $photoId): Response
    {
        if (PhotoLike::where('username', UserFacade::getUser()->name)->where('photo_id', $photoId)->count() > 0) {
            return response(null);
        }

        (new PhotoLike())->store($photoId, UserFacade::getUser()->name);

        return response(null);
    }

    /**
     * Unlike a Photo.
     *
     * @param int $photoId
     *
     * @return Response
     */
    public function unlikePhoto(int $photoId): Response
    {
        if (PhotoLike::where('username', UserFacade::getUser()->name)->where('photo_id', $photoId)->count() == 0) {
            return response(null);
        }

        PhotoLike::where('username', UserFacade::getUser()->name)->where('photo_id', $photoId)->delete();

        return response(null);
    }

    /**
     * Delete a Photo.
     *
     * @param int $photoId
     *
     * @return Response
     */
    public function delete(int $photoId): Response
    {
        $photo = Photo::find($photoId);

        if ($photo == null || $photo->creator_id != UserFacade::getUser()->uniqueId) {
            return response(null, 401);
        }

        $photo->delete();

        return response(null);
    }
}