Client::open() - Code Metrics - Inspection of "Use HTTP factory and remove VPACK stream" - sandrokeil/arangodb-php-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#7)

by Sandro

created 2019-03-31 18:14 UTC

Client::open() B

↳ Parent: Client

Complexity

Conditions	8
Paths	10

Size

Total Lines	53
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	16.8542

Importance

Changes

Metric	Value
eloc	33
dl	0
loc	53
ccs	14
cts	29
cp	0.4828
rs	8.1475
c	0
b	0
f	0
cc	8
nc	10
nop	1
crap	16.8542

How to fix Long Method

<?php
/**
 * Sandro Keil (https://sandro-keil.de)
 *
 * @link      http://github.com/sandrokeil/arangodb-php-client for the canonical source repository
 * @copyright Copyright (c) 2018-2019 Sandro Keil
 * @license   http://github.com/sandrokeil/arangodb-php-client/blob/master/LICENSE.md New BSD License
 */

declare(strict_types=1);

namespace ArangoDb;

use ArangoDb\Exception\ConnectionException;
use ArangoDb\Exception\NetworkException;
use ArangoDb\Exception\RequestFailedException;
use ArangoDb\Exception\TimeoutException;
use ArangoDb\Http\JsonStream;
use Fig\Http\Message\StatusCodeInterface;
use Psr\Http\Client\ClientInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ResponseInterface;

final class Client implements ClientInterface
{
    /**
     * Chunk size in bytes
     */
    private const CHUNK_SIZE = 8192;

    /**
     * End of line mark used in HTTP
     */
    private const EOL = "\r\n";

    /**
     * Connection handle
     *
     * @var resource
     */
    private $handle;

    /**
     * @var bool
     */
    private $useKeepAlive;

    /**
     * @var ClientOptions
     */
    private $options;

    /**
     * @var string
     */
    private $baseUrl = '';

    /**
     * Default headers for all requests
     *
     * @var string
     */
    private $headerLines = '';

    /**
     * @var string
     */
    private $database = '';

    /**
     * @var ResponseFactoryInterface
     */
    private $responseFactory;

    /**
     * @param array|ClientOptions $options
     * @param ResponseFactoryInterface $responseFactory
     */
    public function __construct(
        $options,
        ResponseFactoryInterface $responseFactory
    ) {
        $this->options = $options instanceof ClientOptions ? $options : new ClientOptions($options);
        $this->useKeepAlive = ($this->options[ClientOptions::OPTION_CONNECTION] === 'Keep-Alive');
        $this->responseFactory = $responseFactory;
        $this->updateCommonHttpHeaders();
    }

    /**
     * Delegate / shorthand method
     *
     * @param RequestInterface $request
     * @return ResponseInterface
     * @throws \Psr\Http\Client\ClientExceptionInterface
     */
    public function __invoke(RequestInterface $request): ResponseInterface
    {
        return $this->sendRequest($request);
    }

    public function sendRequest(RequestInterface $request): ResponseInterface
    {
        try {
            $body = $request->getBody()->getContents();
            $method = $request->getMethod();

            $customHeaders = $request->getHeaders();
            unset($customHeaders['Connection'], $customHeaders['Content-Length']);

            if (! isset($customHeaders['Content-Type'])) {
                $customHeaders['Content-Type'] = ['application/json'];
            }

            $customHeader = '';
            foreach ($customHeaders as $headerKey => $headerValues) {
                foreach ($headerValues as $headerValue) {
                    $customHeader .= $headerKey . ': ' . $headerValue . self::EOL;
                }
            }
        } catch (\Throwable $e) {
            throw RequestFailedException::ofRequest($request, $e);
        }

        $customHeader .= 'Content-Length: ' . strlen($body) . self::EOL;

        $url = $this->baseUrl . $request->getUri();

        try {
            $this->open($request);

            $result = $this->transmit(
                $method . ' ' . $url . ' HTTP/1.1' .
                $this->headerLines .
                $customHeader . self::EOL .
                $body,
                $method
            );
            // TODO https://docs.arangodb.com/3.4/Manual/Architecture/DeploymentModes/ActiveFailover/Architecture.html
            $status = stream_get_meta_data($this->handle);

            if (! empty($status['timed_out'])) {
                throw TimeoutException::ofRequest($request);
            }
            if (! $this->useKeepAlive) {
                $this->close();
            }

            [$httpCode, $headers, $body] = HttpHelper::parseMessage($result);
        } catch (\Throwable $e) {
            throw NetworkException::with($request, $e);
        }
        $response = $this->responseFactory->createResponse($httpCode);

        foreach ($headers as $headerName => $header) {
            $response = $response->withAddedHeader($headerName, $header);
        }

        return $response->withBody(new JsonStream($body));
    }

    /**
     * Sends request to server and reads response.
     *
     * @param string $request
     * @param string $method
     * @return string
     */
    private function transmit(string $request, string $method): string
    {
        fwrite($this->handle, $request);
        fflush($this->handle);

        $contentLength = 0;
        $bodyLength = 0;
        $readTotal = 0;
        $matches = [];
        $message = '';

        do {
            $read = fread($this->handle, self::CHUNK_SIZE);
            if (false === $read || $read === '') {
                break;
            }
            $readLength = strlen($read);
            $readTotal += $readLength;
            $message .= $read;

            if ($contentLength === 0
                && $method !== 'HEAD'
                && 1 === preg_match('/content-length: (\d+)/i', $message, $matches)
            ) {
                $contentLength = (int)$matches[1];
            }

            if ($bodyLength === 0) {
                $bodyStart = strpos($message, "\r\n\r\n");

                if (false !== $bodyStart) {
                    $bodyLength = $bodyStart + $contentLength + 4;
                }
            }
        } while ($readTotal < $bodyLength && ! feof($this->handle));

        return $message;
    }

    /**
     * Update common HTTP headers for all HTTP requests
     */
    private function updateCommonHttpHeaders(): void
    {
        $this->headerLines = self::EOL;

        $endpoint = $this->options[ClientOptions::OPTION_ENDPOINT];
        if (1 !== preg_match('/^unix:\/\/.+/', $endpoint)) {
            $this->headerLines .= 'Host: '
                . preg_replace('/^(tcp|ssl):\/\/(.+?):(\d+)\/?$/', '\\2', $endpoint)
                . self::EOL;
        }
        // add basic auth header
        if (isset(
            $this->options[ClientOptions::OPTION_AUTH_TYPE],
            $this->options[ClientOptions::OPTION_AUTH_USER]
        )) {
            $this->headerLines .= sprintf(
                'Authorization: %s %s%s',
                $this->options[ClientOptions::OPTION_AUTH_TYPE],
                base64_encode(
                    $this->options[ClientOptions::OPTION_AUTH_USER] . ':' .
                    $this->options[ClientOptions::OPTION_AUTH_PASSWD]
                ),
                self::EOL
            );
        }

        if (isset($this->options[ClientOptions::OPTION_CONNECTION])) {
            $this->headerLines .= 'Connection: ' . $this->options[ClientOptions::OPTION_CONNECTION] . self::EOL;
        }

        $this->database = $this->options[ClientOptions::OPTION_DATABASE];
        $this->baseUrl = '/_db/' . urlencode($this->database);
    }

    /**
     * Opens connection depending on options.
     *
     * @param RequestInterface $request
     */
    private function open(RequestInterface $request): void
    {
        if ($this->useKeepAlive && $this->handle !== null && is_resource($this->handle)) {
            if (! feof($this->handle)) {
                return;
            }

            $this->close();

            if (false === $this->options[ClientOptions::OPTION_RECONNECT]) {
                throw ConnectionException::forRequest(
                    $request,
                    'Server has closed the connection already.',
                    StatusCodeInterface::STATUS_REQUEST_TIMEOUT
                );
            }
        }

        $endpoint = $this->options[ClientOptions::OPTION_ENDPOINT];
        $context = stream_context_create();

        if (1 === preg_match('/^ssl:\/\/.+/', $endpoint)) {
            stream_context_set_option(
                $context,
                [
                    'ssl' => [
                        'verify_peer' => $this->options[ClientOptions::OPTION_VERIFY_CERT],
                        'verify_peer_name' => $this->options[ClientOptions::OPTION_VERIFY_CERT_NAME],
                        'allow_self_signed' => $this->options[ClientOptions::OPTION_ALLOW_SELF_SIGNED],
                        'ciphers' => $this->options[ClientOptions::OPTION_CIPHERS],
                    ],
                ]
            );
        }

        $handle = stream_socket_client(
            $endpoint,
            $errNo,
            $message,
            $this->options[ClientOptions::OPTION_TIMEOUT],
            STREAM_CLIENT_CONNECT,
            $context
        );

        if (false === $handle) {
            throw ConnectionException::forRequest(
                $request,
                sprintf('Cannot connect to endpoint "%s". Message: %s', $endpoint, $message),
                $errNo
            );
        }
        $this->handle = $handle;
        stream_set_timeout($this->handle, $this->options[ClientOptions::OPTION_TIMEOUT]);
    }

    /**
     * Closes connection
     */
    private function close(): void
    {
        fclose($this->handle);
        unset($this->handle);
    }
}


1		<?php
2		/**
3		* Sandro Keil (https://sandro-keil.de)
4		*
5		* @link http://github.com/sandrokeil/arangodb-php-client for the canonical source repository
6		* @copyright Copyright (c) 2018-2019 Sandro Keil
7		* @license http://github.com/sandrokeil/arangodb-php-client/blob/master/LICENSE.md New BSD License
8		*/
9
10		declare(strict_types=1);
11
12		namespace ArangoDb;
13
14		use ArangoDb\Exception\ConnectionException;
15		use ArangoDb\Exception\NetworkException;
16		use ArangoDb\Exception\RequestFailedException;
17		use ArangoDb\Exception\TimeoutException;
18		use ArangoDb\Http\JsonStream;
19		use Fig\Http\Message\StatusCodeInterface;
20		use Psr\Http\Client\ClientInterface;
21		use Psr\Http\Message\RequestInterface;
22		use Psr\Http\Message\ResponseFactoryInterface;
23		use Psr\Http\Message\ResponseInterface;
24
25		final class Client implements ClientInterface
26		{
27		/**
28		* Chunk size in bytes
29		*/
30		private const CHUNK_SIZE = 8192;
31
32		/**
33		* End of line mark used in HTTP
34		*/
35		private const EOL = "\r\n";
36
37		/**
38		* Connection handle
39		*
40		* @var resource
41		*/
42		private $handle;
43
44		/**
45		* @var bool
46		*/
47		private $useKeepAlive;
48
49		/**
50		* @var ClientOptions
51		*/
52		private $options;
53
54		/**
55		* @var string
56		*/
57		private $baseUrl = '';
58
59		/**
60		* Default headers for all requests
61		*
62		* @var string
63		*/
64		private $headerLines = '';
65
66		/**
67		* @var string
68		*/
69		private $database = '';
70
71		/**
72		* @var ResponseFactoryInterface
73		*/
74		private $responseFactory;
75
76		/**
77		* @param array\|ClientOptions $options
78		* @param ResponseFactoryInterface $responseFactory
79		*/
80	60	public function __construct(
81		$options,
82		ResponseFactoryInterface $responseFactory
83		) {
84	60	$this->options = $options instanceof ClientOptions ? $options : new ClientOptions($options);
85	60	$this->useKeepAlive = ($this->options[ClientOptions::OPTION_CONNECTION] === 'Keep-Alive');
86	60	$this->responseFactory = $responseFactory;
87	60	$this->updateCommonHttpHeaders();
88	60	}
89
90		/**
91		* Delegate / shorthand method
92		*
93		* @param RequestInterface $request
94		* @return ResponseInterface
95		* @throws \Psr\Http\Client\ClientExceptionInterface
96		*/
97		public function __invoke(RequestInterface $request): ResponseInterface
98		{
99		return $this->sendRequest($request);
100		}
101
102	40	public function sendRequest(RequestInterface $request): ResponseInterface
103		{
104		try {
105	40	$body = $request->getBody()->getContents();
106	40	$method = $request->getMethod();
107
108	40	$customHeaders = $request->getHeaders();
109	40	unset($customHeaders['Connection'], $customHeaders['Content-Length']);
110
111	40	if (! isset($customHeaders['Content-Type'])) {
112	39	$customHeaders['Content-Type'] = ['application/json'];
113		}
114
115	40	$customHeader = '';
116	40	foreach ($customHeaders as $headerKey => $headerValues) {
117	40	foreach ($headerValues as $headerValue) {
118	40	$customHeader .= $headerKey . ': ' . $headerValue . self::EOL;
119		}
120		}
121		} catch (\Throwable $e) {
122		throw RequestFailedException::ofRequest($request, $e);
123		}
124
125	40	$customHeader .= 'Content-Length: ' . strlen($body) . self::EOL;
126
127	40	$url = $this->baseUrl . $request->getUri();
128
129		try {
130	40	$this->open($request);
131
132	40	$result = $this->transmit(
133	40	$method . ' ' . $url . ' HTTP/1.1' .
134	40	$this->headerLines .
135	40	$customHeader . self::EOL .
136	40	$body,
137		$method
138		);
139		// TODO https://docs.arangodb.com/3.4/Manual/Architecture/DeploymentModes/ActiveFailover/Architecture.html
140	40	$status = stream_get_meta_data($this->handle);
141
142	40	if (! empty($status['timed_out'])) {
143		throw TimeoutException::ofRequest($request);
144		}
145	40	if (! $this->useKeepAlive) {
146		$this->close();
147		}
148
149	40	[$httpCode, $headers, $body] = HttpHelper::parseMessage($result);
150		} catch (\Throwable $e) {
151		throw NetworkException::with($request, $e);
152		}
153	40	$response = $this->responseFactory->createResponse($httpCode);
154
155	40	foreach ($headers as $headerName => $header) {
156	40	$response = $response->withAddedHeader($headerName, $header);
157		}
158
159	40	return $response->withBody(new JsonStream($body));
160		}
161
162		/**
163		* Sends request to server and reads response.
164		*
165		* @param string $request
166		* @param string $method
167		* @return string
168		*/
169	40	private function transmit(string $request, string $method): string
170		{
171	40	fwrite($this->handle, $request);
172	40	fflush($this->handle);
173
174	40	$contentLength = 0;
175	40	$bodyLength = 0;
176	40	$readTotal = 0;
177	40	$matches = [];
178	40	$message = '';
179
180		do {
181	40	$read = fread($this->handle, self::CHUNK_SIZE);
182	40	if (false === $read \|\| $read === '') {
183		break;
184		}
185	40	$readLength = strlen($read);
186	40	$readTotal += $readLength;
187	40	$message .= $read;
188
189	40	if ($contentLength === 0
190	40	&& $method !== 'HEAD'
191	40	&& 1 === preg_match('/content-length: (\d+)/i', $message, $matches)
192		) {
193	40	$contentLength = (int)$matches[1];
194		}
195
196	40	if ($bodyLength === 0) {
197	40	$bodyStart = strpos($message, "\r\n\r\n");
198
199	40	if (false !== $bodyStart) {
200	40	$bodyLength = $bodyStart + $contentLength + 4;
201		}
202		}
203	40	} while ($readTotal < $bodyLength && ! feof($this->handle));
204
205	40	return $message;
206		}
207
208		/**
209		* Update common HTTP headers for all HTTP requests
210		*/
211	60	private function updateCommonHttpHeaders(): void
212		{
213	60	$this->headerLines = self::EOL;
214
215	60	$endpoint = $this->options[ClientOptions::OPTION_ENDPOINT];
216	60	if (1 !== preg_match('/^unix:\/\/.+/', $endpoint)) {
217	60	$this->headerLines .= 'Host: '
218	60	. preg_replace('/^(tcp\|ssl):\/\/(.+?):(\d+)\/?$/', '\\2', $endpoint)
219	60	. self::EOL;
220		}
221		// add basic auth header
222		if (isset(
223	60	$this->options[ClientOptions::OPTION_AUTH_TYPE],
224	60	$this->options[ClientOptions::OPTION_AUTH_USER]
225		)) {
226		$this->headerLines .= sprintf(
227		'Authorization: %s %s%s',
228		$this->options[ClientOptions::OPTION_AUTH_TYPE],
229		base64_encode(
230		$this->options[ClientOptions::OPTION_AUTH_USER] . ':' .
231		$this->options[ClientOptions::OPTION_AUTH_PASSWD]
232		),
233		self::EOL
234		);
235		}
236
237	60	if (isset($this->options[ClientOptions::OPTION_CONNECTION])) {
238	60	$this->headerLines .= 'Connection: ' . $this->options[ClientOptions::OPTION_CONNECTION] . self::EOL;
239		}
240
241	60	$this->database = $this->options[ClientOptions::OPTION_DATABASE];
242	60	$this->baseUrl = '/_db/' . urlencode($this->database);
243	60	}
244
245		/**
246		* Opens connection depending on options.
247		*
248		* @param RequestInterface $request
249		*/
250	40	private function open(RequestInterface $request): void
251		{
252	40	if ($this->useKeepAlive && $this->handle !== null && is_resource($this->handle)) {
253	16	if (! feof($this->handle)) {
254	16	return;
255		}
256
257		$this->close();
258
259		if (false === $this->options[ClientOptions::OPTION_RECONNECT]) {
260		throw ConnectionException::forRequest(
261		$request,
262		'Server has closed the connection already.',
263		StatusCodeInterface::STATUS_REQUEST_TIMEOUT
264		);
265		}
266		}
267
268	40	$endpoint = $this->options[ClientOptions::OPTION_ENDPOINT];
269	40	$context = stream_context_create();
270
271	40	if (1 === preg_match('/^ssl:\/\/.+/', $endpoint)) {
272		stream_context_set_option(
273		$context,
274		[
275		'ssl' => [
276		'verify_peer' => $this->options[ClientOptions::OPTION_VERIFY_CERT],
277		'verify_peer_name' => $this->options[ClientOptions::OPTION_VERIFY_CERT_NAME],
278		'allow_self_signed' => $this->options[ClientOptions::OPTION_ALLOW_SELF_SIGNED],
279		'ciphers' => $this->options[ClientOptions::OPTION_CIPHERS],
280		],
281		]
282		);
283		}
284
285	40	$handle = stream_socket_client(
286	40	$endpoint,
287		$errNo,
288		$message,
289	40	$this->options[ClientOptions::OPTION_TIMEOUT],
290	40	STREAM_CLIENT_CONNECT,
291		$context
292		);
293
294	40	if (false === $handle) {
295		throw ConnectionException::forRequest(
296		$request,
297		sprintf('Cannot connect to endpoint "%s". Message: %s', $endpoint, $message),
298		$errNo
299		);
300		}
301	40	$this->handle = $handle;
302	40	stream_set_timeout($this->handle, $this->options[ClientOptions::OPTION_TIMEOUT]);
303	40	}
304
305		/**
306		* Closes connection
307		*/
308		private function close(): void
309		{
310		fclose($this->handle);
311		unset($this->handle);
312		}
313		}
314

sandrokeil / arangodb-php-client

Pull Request — master (#7)

Client::open() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like