FakePaymentGateway - Code Metrics - sandervanhooft/laravel-payable-redirect-mollie - Measure and Improve Code Quality continuously with Scrutinizer

FakePaymentGateway A
last analyzed 2018-02-08 16:31 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	1
dl	0
loc	46
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	chargeAmountForPayable()	18	1
A	getGatewayName()	4	1
A	fetchUpdateFor()	7	1

<?php

namespace SanderVanHooft\PayableRedirect;

use Illuminate\Database\Eloquent\Model;
use SanderVanHooft\PayableRedirect\Payment;

class FakePaymentGateway implements PaymentGateway
{
    /**
     * @param  Int
     * @param  Illuminate\Database\Eloquent\Model
     * @return Payment
     */
    public function chargeAmountForPayable(
        Int $amount,
        Model $payable,
        String $description,
        array $params = []
    ) : Payment {
        $payment = $payable->payments()->create([
            'amount' => $amount,
            'status' => 'open',
            'description' => $description,
            'redirect_url' => 'https://www.fake-payment-gateway-url.com/?ref=123456',
            'return_url' => $params['return_url'],
            'gateway_name' => $this->getGatewayName(),
            'gateway_payment_reference' => 'fake-reference',
        ]);

        return $payment;
    }

    /**
     * @return String
     */
    public function getGatewayName() : String
    {
        return self::class;
    }

    /**
     * @param  Payment
     * @return Payment
     */
    public function fetchUpdateFor(Payment $payment) : Payment
    {
        $payment->status = 'paid';
        $payment->redirect_url = null;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $payment->save();
        return $payment;
    }
}


1			<?php
2
3			namespace SanderVanHooft\PayableRedirect;
4
5			use Illuminate\Database\Eloquent\Model;
6			use SanderVanHooft\PayableRedirect\Payment;
7
8			class FakePaymentGateway implements PaymentGateway
9			{
10			/**
11			* @param Int
12			* @param Illuminate\Database\Eloquent\Model
13			* @return Payment
14			*/
15			public function chargeAmountForPayable(
16			Int $amount,
17			Model $payable,
18			String $description,
19			array $params = []
20			) : Payment {
21			$payment = $payable->payments()->create([
22			'amount' => $amount,
23			'status' => 'open',
24			'description' => $description,
25			'redirect_url' => 'https://www.fake-payment-gateway-url.com/?ref=123456',
26			'return_url' => $params['return_url'],
27			'gateway_name' => $this->getGatewayName(),
28			'gateway_payment_reference' => 'fake-reference',
29			]);
30
31			return $payment;
32			}
33
34			/**
35			* @return String
36			*/
37			public function getGatewayName() : String
38			{
39			return self::class;
40			}
41
42			/**
43			* @param Payment
44			* @return Payment
45			*/
46			public function fetchUpdateFor(Payment $payment) : Payment
47			{
48			$payment->status = 'paid';
49			$payment->redirect_url = null;
			0 ignored issues – show Documentation introduced 2017-06-27 10:38 UTC by Report Bug Copy Issue Report The property `redirect_url` does not exist on `object<SanderVanHooft\PayableRedirect\Payment>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
50			$payment->save();
51			return $payment;
52			}
53			}
54

sandervanhooft / laravel-payable-redirect-mollie

FakePaymentGateway A last analyzed 2018-02-08 16:31 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

FakePaymentGateway A
last analyzed 2018-02-08 16:31 UTC