sander3 / laravel-magic-auth

src/AuthenticatesUsers.php

<?php

namespace Soved\Laravel\Magic\Auth;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Foundation\Auth\RedirectsUsers;
use Soved\Laravel\Magic\Auth\Links\LinkBroker;

trait AuthenticatesUsers
{
    use RedirectsUsers;

    /**
     * Handle a magic authentication request to the application.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\Response
     */
    public function login(Request $request)
    {
        $this->validateLogin($request);

        $response = $this->broker()->login(
            $request, function ($user) {
                $this->authenticateUser($user);
            }
        );

        return $response == LinkBroker::USER_AUTHENTICATED
            ? $this->sendLoginResponse($request)
            : $this->sendFailedLoginResponse($response);
    }

    /**
     * Validate the user login request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return void
     */
    protected function validateLogin(Request $request)
    {
        $this->validate($request, ['email' => 'required|email']);
    }

    /**
     * Authenticate the given user.
     *
     * @param  \Soved\Laravel\Magic\Auth\Traits\CanMagicallyLogin  $user
     * @return void
     */
    protected function authenticateUser($user)
    {
        $this->guard()->login($user, config('magic-auth.remember'));

$user of type Soved\Laravel\Magic\Auth\Traits\CanMagicallyLogin is incompatible with the type Illuminate\Contracts\Auth\Authenticatable expected by parameter $user of Illuminate\Contracts\Auth\StatefulGuard::login().

    }

    /**
     * Send the response after the user was authenticated.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    protected function sendLoginResponse(Request $request)
    {
        $request->session()->regenerate();

        return $this->authenticated($request, $this->guard()->user())

Are you sure the usage of $this->authenticated($request, $this->guard()->user()) targeting Soved\Laravel\Magic\Auth\AuthenticatesUsers::authenticated() seems to always return null.

            ?: redirect()->intended($this->redirectPath());
    }

    /**
     * The user has been authenticated.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  mixed  $user
     * @return mixed
     */
    protected function authenticated(
        Request $request,
        $user
    ) {
        $request->session()->put('viaMagicLink', true);

        // Invalidating all unexpired magic links
        $user->touch();
    }

    /**
     * Get the failed login response instance.
     *
     * @param  string  $response
     * @return \Illuminate\Http\RedirectResponse
     */
    protected function sendFailedLoginResponse(string $response)
    {
        return redirect($this->redirectPath())
            ->withErrors(['email' => __($response)]);
    }

    /**
     * Get the broker to be used during magic authentication.
     *
     * @return \Soved\Laravel\Magic\Auth\Links\LinkBroker
     */
    public function broker()
    {
        $userProvider = Auth::getProvider();

        return new LinkBroker($userProvider);
    }

    /**
     * Get the guard to be used during magic authentication.
     *
     * @return \Illuminate\Contracts\Auth\StatefulGuard
     */
    protected function guard()
    {
        return Auth::guard();
    }
}