sander3 / laravel-gdpr

src/Http/Controllers/GdprController.php

<?php

namespace Soved\Laravel\Gdpr\Http\Controllers;

use App\Http\Controllers\Controller;

The type App\Http\Controllers\Controller was not found. Maybe you did not declare it correctly or list all dependencies?

use Illuminate\Support\Facades\Auth;
use Illuminate\Foundation\Http\FormRequest;
use Soved\Laravel\Gdpr\Events\GdprDownloaded;
use Soved\Laravel\Gdpr\Http\Requests\GdprDownload;

class GdprController extends Controller
{
    /**
     * Download the GDPR compliant data portability JSON file.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function download(GdprDownload $request)
    {
        if (! $this->validateRequest($request)) {
            return $this->sendFailedLoginResponse();

The expression return $this->sendFailedLoginResponse() returns the type void which is incompatible with the documented return type Illuminate\Http\JsonResponse.

Are you sure the usage of $this->sendFailedLoginResponse() targeting Soved\Laravel\Gdpr\Http\Controllers\GdprController::sendFailedLoginResponse() seems to always return null.

        }

        $data = $request->user()->portable();

        event(new GdprDownloaded($request->user()));

        // Backward compatible streamDownload() behavior

        return response()->json(
            $data,
            200,
            [
                'Content-Disposition' => 'attachment; filename="user.json"',
            ]
        );
    }

    /**
     * Validate the request.
     *
     * @return bool
     */
    protected function validateRequest(FormRequest $request)
    {
        if (config('gdpr.re-authenticate', true)) {
            return $this->hasValidCredentials($request);
        }

        return Auth::check();
    }

    /**
     * Validate a user's credentials.
     *
     * @return bool
     */
    protected function hasValidCredentials(FormRequest $request)
    {
        $credentials = [
            $request->user()->getAuthIdentifierName() => $request->user()->getAuthIdentifier(),
            'password'                                => $request->input('password'),
        ];

        return Auth::validate($credentials);
    }

    /**
     * Get the failed login response.
     *
     * @return void
     */
    protected function sendFailedLoginResponse()
    {
        abort(403, 'Unauthorized.');
    }
}