Networks::extractingNetworks() - Code Metrics - Inspection of "Refactoring" - sanchescom/php-wifi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

by Aleksandr

created 2019-06-29 23:14 UTC

Networks::extractingNetworks() A

↳ Parent: Networks

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	9
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

declare(strict_types=1);

namespace Sanchescom\WiFi\System\Linux;

use Sanchescom\WiFi\System\AbstractNetwork;
use Sanchescom\WiFi\System\AbstractNetworks;

/**
 * Class Networks.
 */
class Networks extends AbstractNetworks
{
    /**
     * @var int
     */
    const BSSID_KEY = 0;

    /**
     * @return string
     */
    protected function getCommand(): string
    {
        return 'LANG=C nmcli '
            .' --terse'
            .' --fields '
            .'active,ssid,bssid,'
            .'mode,chan,freq,'
            .'signal,security,wpa-flags,'
            .'rsn-flags'
            .' device'
            .' wifi'
            .' list';
    }

    /**
     * {@inheritdoc}
     */
    protected function getNetwork(): AbstractNetwork
    {
        return new Network($this->command);
    }

    /**
     * @param string $output
     *
     * @return array
     */
    public function extractingNetworks($output): array
    {
        $availableNetworks = $this->explodeAvailableNetworks($output);

        array_walk($availableNetworks, function (&$networkData) {
            $networkData = $this->extractingDataFromString($networkData);
        });

        return $availableNetworks;
    }

    /**
     * @param string $networkData
     *
     * @return array
     */
    protected function extractingDataFromString($networkData): array
    {
        $extractedProperties = [];

        preg_match_all(
            '/(.*):(.*):(\w{2}\:\w{2}\:\w{2}\:\w{2}\:\w{2}:\w{2}):(.*):(.*):(.*):(.*):(.*):(.*):(.*)/',
            str_replace('\\:', ':', $networkData),
            $extractedProperties
        );

        array_shift($extractedProperties);

        return trim_first($extractedProperties);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Sanchescom\WiFi\System\Linux;
6
7			use Sanchescom\WiFi\System\AbstractNetwork;
8			use Sanchescom\WiFi\System\AbstractNetworks;
9
10			/**
11			* Class Networks.
12			*/
13			class Networks extends AbstractNetworks
14			{
15			/**
16			* @var int
17			*/
18			const BSSID_KEY = 0;
19
20			/**
21			* @return string
22			*/
23			protected function getCommand(): string
24			{
25			return 'LANG=C nmcli '
26			.' --terse'
27			.' --fields '
28			.'active,ssid,bssid,'
29			.'mode,chan,freq,'
30			.'signal,security,wpa-flags,'
31			.'rsn-flags'
32			.' device'
33			.' wifi'
34			.' list';
35			}
36
37			/**
38			* {@inheritdoc}
39			*/
40			protected function getNetwork(): AbstractNetwork
41			{
42			return new Network($this->command);
43			}
44
45			/**
46			* @param string $output
47			*
48			* @return array
49			*/
50			public function extractingNetworks($output): array
51			{
52			$availableNetworks = $this->explodeAvailableNetworks($output);
53
54			array_walk($availableNetworks, function (&$networkData) {
55			$networkData = $this->extractingDataFromString($networkData);
56			});
57
58			return $availableNetworks;
59			}
60
61			/**
62			* @param string $networkData
63			*
64			* @return array
65			*/
66			protected function extractingDataFromString($networkData): array
67			{
68			$extractedProperties = [];
69
70			preg_match_all(
71			'/(.):(.):(\w{2}\:\w{2}\:\w{2}\:\w{2}\:\w{2}:\w{2}):(.):(.):(.):(.):(.):(.):(.*)/',
72			str_replace('\\:', ':', $networkData),
73			$extractedProperties
74			);
75
76			array_shift($extractedProperties);
77
78			return trim_first($extractedProperties);
79			}
80			}
81

sanchescom / php-wifi

Pull Request — master (#5)

Networks::extractingNetworks() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like