Search::getItems() - Code Metrics - Inspection of "WiP" - samwilson/simple-wikidata - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 250c4f...aeb35e )

by Sam

created 2018-09-13 07:23 UTC

Search::getItems() A

↳ Parent: Search

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	14
nc	2
nop	1
dl	0
loc	17
ccs	0
cts	17
cp	0
crap	6
rs	9.7998
c	0
b	0
f	0

<?php

namespace Samwilson\SimpleWikidata;

use Mediawiki\Api\FluentRequest;
use Mediawiki\Api\MediawikiApi;
use Psr\Cache\CacheItemPoolInterface;

class Search {

	/** @var string */
	protected $lang;

	/** @var CacheItemPoolInterface */
	protected $cache;

	/**
	 * Search constructor.
	 * @param string $searchTerm What to search for.
	 * @param string $lang Language to use for the search results.
	 * @param CacheItemPoolInterface $cache The cache to use.
	 */
	public function __construct( $searchTerm, $lang, CacheItemPoolInterface $cache ) {
		$this->searchTerm = $searchTerm;

		$this->lang = $lang;
		$this->cache = $cache;
	}

	/**
	 * @param string $limit The number of search results to return.
	 * @return Item[]
	 */
	public function getItems( $limit = 'max' ) {
		$api = MediawikiApi::newFromApiEndpoint( 'https://www.wikidata.org/w/api.php' );
		$req = FluentRequest::factory()
			->setAction( 'wbsearchentities' )
			->addParams( [
				'search' => $this->searchTerm,
				'type' => 'item',
				'limit' => $limit,
				'language' => 'en',
			] );
		$results = [];
		$response = $api->getRequest( $req );
		foreach ( $response['search'] as $info ) {
			$item = Item::factory( $info['id'], $this->lang, $this->cache );
			$results[] = $item;
		}
		return $results;
	}
}


1			<?php
2
3			namespace Samwilson\SimpleWikidata;
4
5			use Mediawiki\Api\FluentRequest;
6			use Mediawiki\Api\MediawikiApi;
7			use Psr\Cache\CacheItemPoolInterface;
8
9			class Search {
10
11			/** @var string */
12			protected $lang;
13
14			/** @var CacheItemPoolInterface */
15			protected $cache;
16
17			/**
18			* Search constructor.
19			* @param string $searchTerm What to search for.
20			* @param string $lang Language to use for the search results.
21			* @param CacheItemPoolInterface $cache The cache to use.
22			*/
23			public function __construct( $searchTerm, $lang, CacheItemPoolInterface $cache ) {
24			$this->searchTerm = $searchTerm;
			0 ignored issues – show Bug Best Practice introduced 2018-09-13 07:27 UTC by Report Bug Copy Issue Report The property `searchTerm` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
25			$this->lang = $lang;
26			$this->cache = $cache;
27			}
28
29			/**
30			* @param string $limit The number of search results to return.
31			* @return Item[]
32			*/
33			public function getItems( $limit = 'max' ) {
34			$api = MediawikiApi::newFromApiEndpoint( 'https://www.wikidata.org/w/api.php' );
35			$req = FluentRequest::factory()
36			->setAction( 'wbsearchentities' )
37			->addParams( [
38			'search' => $this->searchTerm,
39			'type' => 'item',
40			'limit' => $limit,
41			'language' => 'en',
42			] );
43			$results = [];
44			$response = $api->getRequest( $req );
45			foreach ( $response['search'] as $info ) {
46			$item = Item::factory( $info['id'], $this->lang, $this->cache );
47			$results[] = $item;
48			}
49			return $results;
50			}
51			}
52

samwilson / simple-wikidata

Push — master ( 250c4f...aeb35e )

Search::getItems() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like