yswery\DNS\Resolver\JsonResolver

Complexity

Total Complexity

12

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	processZone()	0	20	3
A	processLegacyZone()	0	20	4
A	__construct()	0	10	3
A	isLegacyFormat()	0	9	2

<?php

namespace yswery\DNS\Resolver;

use yswery\DNS\ClassEnum;
use yswery\DNS\RecordTypeEnum;
use yswery\DNS\ResourceRecord;
use yswery\DNS\UnsupportedTypeException;

class JsonResolver extends AbstractResolver
{
    /**
     * @var string
     */
    protected $defaultClass = ClassEnum::INTERNET;

    /**
     * @var int
     */
    protected $defaultTtl;

    /**
     * JsonResolver constructor.
     *
     * @param array $files
     * @param int   $defaultTtl
     *
     * @throws UnsupportedTypeException
     */
    public function __construct(array $files, $defaultTtl = 300)
    {
        $this->isAuthoritative = true;
        $this->allowRecursion = false;
        $this->defaultTtl = $defaultTtl;

        foreach ($files as $file) {
            $zone = json_decode(file_get_contents($file), true);
            $resourceRecords = $this->isLegacyFormat($zone) ? $this->processLegacyZone($zone) : $this->processZone($zone);
            $this->addZone($resourceRecords);
        }
    }

    /**
     * @param array $zone
     *
     * @return ResourceRecord[]
     *
     * @throws UnsupportedTypeException
     */
    protected function processZone(array $zone): array
    {
        $parent = rtrim($zone['domain'], '.').'.';
        $defaultTtl = $zone['default-ttl'];
        $rrs = $zone['resource-records'];
        $resourceRecords = [];

        foreach ($rrs as $rr) {
            $name = $rr['name'] ?? $parent;
            $class = isset($rr['class']) ? ClassEnum::getClassFromName($rr['class']) : $this->defaultClass;

            $resourceRecords[] = (new ResourceRecord())
                ->setName($this->handleName($name, $parent))
                ->setClass($class)

It seems like $class can also be of type string; however, parameter $class of yswery\DNS\ResourceRecord::setClass() does only seem to accept integer, maybe add an additional type check?

                ->setType($type = RecordTypeEnum::getTypeIndex($rr['type']))

It seems like $type = yswery\DNS\RecordTypeEnum::getTypeIndex($rr['type']) can also be of type false; however, parameter $type of yswery\DNS\ResourceRecord::setType() does only seem to accept integer, maybe add an additional type check?

                ->setTtl($rr['ttl'] ?? $defaultTtl)
                ->setRdata($this->extractRdata($rr, $type, $parent));

It seems like $type can also be of type false; however, parameter $type of yswery\DNS\Resolver\AbstractResolver::extractRdata() does only seem to accept integer, maybe add an additional type check?

        }

        return $resourceRecords;
    }

    /**
     * Determine if a $zone is in the legacy format.
     *
     * @param array $zone
     *
     * @return bool
     */
    protected function isLegacyFormat(array $zone): bool
    {
        $keys = array_map(function ($value) {
            return strtolower($value);
        }, array_keys($zone));

        return
            (false === array_search('domain', $keys, true)) ||
            (false === array_search('resource-records', $keys, true));
    }

    /**
     * @param array $zones
     *
     * @return ResourceRecord[]
     */
    protected function processLegacyZone(array $zones): array
    {
        $resourceRecords = [];
        foreach ($zones as $domain => $types) {
            $domain = rtrim($domain, '.').'.';
            foreach ($types as $type => $data) {
                $data = (array) $data;
                $type = RecordTypeEnum::getTypeIndex($type);
                foreach ($data as $rdata) {
                    $resourceRecords[] = (new ResourceRecord())
                        ->setName($domain)
                        ->setType($type)

It seems like $type can also be of type false; however, parameter $type of yswery\DNS\ResourceRecord::setType() does only seem to accept integer, maybe add an additional type check?

                        ->setClass($this->defaultClass)

$this->defaultClass of type string is incompatible with the type integer expected by parameter $class of yswery\DNS\ResourceRecord::setClass().

                        ->setTtl($this->defaultTtl)
                        ->setRdata($rdata);
                }
            }
        }

        return $resourceRecords;
    }
}