yswery\DNS\ClassEnum

Complexity

Total Complexity

4

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getClassFromName()	0	3	1
A	isValid()	0	3	1
A	getName()	0	7	2

<?php
/*
 * This file is part of PHP DNS Server.
 *
 * (c) Yif Swery <yiftachswr@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace yswery\DNS;

class ClassEnum
{
    public const INTERNET = 1;
    public const CSNET = 2;
    public const CHAOS = 3;
    public const HESIOD = 4;

    /**
     * @var array
     */
    public static $classes = [
        self::INTERNET => 'IN',
        self::CSNET => 'CS',
        self::CHAOS => 'CHAOS',
        self::HESIOD => 'HS',
    ];

    /**
     * Determine if a class is valid.
     *
     * @param string $class
     *
     * @return bool
     */
    public static function isValid($class): bool
    {
        return array_key_exists($class, self::$classes);
    }

    /**
     * @param int $class
     *
     * @return mixed
     *
     * @throws \InvalidArgumentException
     */
    public static function getName(int $class): string
    {
        if (!static::isValid($class)) {
            throw new \InvalidArgumentException(sprintf('No class matching integer "%s"', $class));
        }

        return self::$classes[$class];
    }

    /**
     * @param string $name
     *
     * @return int
     */
    public static function getClassFromName(string $name): int
    {
        return array_search($name, self::$classes, true);

The expression return array_search($name, self::classes, true) could return the type false|string which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }
}