1
|
|
|
<?php |
2
|
|
|
|
3
|
|
|
namespace App\Module\Client\Create\Service; |
4
|
|
|
|
5
|
|
|
use App\Application\Data\UserNetworkSessionData; |
6
|
|
|
use App\Module\Authorization\Repository\AuthorizationUserRoleFinderRepository; |
|
|
|
|
7
|
|
|
use App\Module\Client\AssignUser\Service\ClientAssignUserAuthorizationChecker; |
8
|
|
|
use App\Module\Client\Data\ClientData; |
9
|
|
|
use App\Module\User\Enum\UserRole; |
10
|
|
|
use Psr\Log\LoggerInterface; |
11
|
|
|
|
12
|
|
|
/** |
13
|
|
|
* Check if the authenticated user is permitted to do actions. |
14
|
|
|
* Roles: newcomer < advisor < managing_advisor < administrator. |
15
|
|
|
*/ |
16
|
|
|
final class ClientCreateAuthorizationChecker |
17
|
|
|
{ |
18
|
|
|
private ?int $loggedInUserId = null; |
19
|
|
|
|
20
|
12 |
|
public function __construct( |
21
|
|
|
private readonly AuthorizationUserRoleFinderRepository $authorizationUserRoleFinderRepository, |
22
|
|
|
private readonly ClientAssignUserAuthorizationChecker $clientAssignUserAuthorizationChecker, |
23
|
|
|
private readonly UserNetworkSessionData $userNetworkSessionData, |
24
|
|
|
private readonly LoggerInterface $logger, |
25
|
|
|
) { |
26
|
12 |
|
$this->loggedInUserId = $this->userNetworkSessionData->userId; |
27
|
|
|
} |
28
|
|
|
|
29
|
|
|
/** |
30
|
|
|
* Check if the authenticated user is allowed to create client. |
31
|
|
|
* |
32
|
|
|
* @param ClientData|null $client null if check before actual client creation |
33
|
|
|
* request otherwise it has to be provided |
34
|
|
|
* |
35
|
|
|
* @return bool |
36
|
|
|
*/ |
37
|
9 |
|
public function isGrantedToCreate(?ClientData $client = null): bool |
38
|
|
|
{ |
39
|
9 |
|
if ($this->loggedInUserId === null) { |
40
|
|
|
$this->logger->error( |
41
|
|
|
'loggedInUserId not set while isGrantedToCreate authorization check $client: ' |
42
|
|
|
. json_encode($client, JSON_PARTIAL_OUTPUT_ON_ERROR) |
43
|
|
|
); |
44
|
|
|
|
45
|
|
|
return false; |
46
|
|
|
} |
47
|
9 |
|
$authenticatedUserRoleHierarchy = $this->authorizationUserRoleFinderRepository->getRoleHierarchyByUserId( |
48
|
9 |
|
$this->loggedInUserId |
49
|
9 |
|
); |
50
|
|
|
// Returns array with role name as key and hierarchy as value ['role_name' => hierarchy_int] |
51
|
|
|
// * Lower hierarchy number means higher privileged role |
52
|
9 |
|
$userRoleHierarchies = $this->authorizationUserRoleFinderRepository->getUserRolesHierarchies(); |
53
|
|
|
|
54
|
|
|
// Newcomer is not allowed to do anything |
55
|
|
|
// If hierarchy number is greater or equals newcomer it means that user is not allowed |
56
|
9 |
|
if ($authenticatedUserRoleHierarchy <= $userRoleHierarchies[UserRole::ADVISOR->value]) { |
57
|
|
|
// Advisor may create clients but can only assign them to themself or leave it unassigned. |
58
|
|
|
// If $client is null (not provided), advisor is authorized (being used to check if create btn should |
59
|
|
|
// be displayed in template) |
60
|
7 |
|
if ($client === null |
61
|
7 |
|
|| $this->clientAssignUserAuthorizationChecker->isGrantedToAssignUserToClient( |
62
|
7 |
|
$client->userId, |
63
|
7 |
|
$authenticatedUserRoleHierarchy, |
64
|
7 |
|
$userRoleHierarchies |
65
|
7 |
|
)) { |
66
|
|
|
// If authenticated user is at least advisor and client user id is themself, or it's a |
67
|
|
|
// managing_advisor (logic in isGrantedToAssignUserToClient) -> granted to create |
68
|
6 |
|
return true; |
69
|
|
|
} |
70
|
|
|
} |
71
|
|
|
|
72
|
3 |
|
$this->logger->notice('User ' . $this->loggedInUserId . ' tried to create client but isn\'t allowed.'); |
73
|
|
|
|
74
|
3 |
|
return false; |
75
|
|
|
} |
76
|
|
|
} |
77
|
|
|
|
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"]
, you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths