samtny / league-frontend

app/Http/Controllers/RoundsController.php

<?php

namespace App\Http\Controllers;

use App\PLMatch;
use App\Round;
use App\Schedule;
use Illuminate\Http\Request;

class RoundsController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        //
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create(Schedule $schedule)
    {
        return view('round.create', [

The expression return view('round.create', array('schedule' => $schedule)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

            'schedule' => $schedule,
        ]);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request, Schedule $schedule)
    {
        $validatedData = $request->validate([

The assignment to $validatedData is dead and can be removed.

            'name' => 'required|max:255',
            'start_date' => 'required|date',
        ]);

        $round = new Round();

        $round->name = $request->name;
        $round->series_id = $schedule->series->id;
        $round->schedule_id = $schedule->id;
        $round->start_date = $request->start_date;
        $round->end_date = $request->end_date;

        $round->save();

        $association = $schedule->association;
        $venues = $association->venues;

        foreach ($venues as $venue) {
            $match = new PLMatch;

            $match->name = $venue->name . ' – ' . $round->start_date->format('m-d-Y');

The property name does not seem to exist on App\PLMatch. Are you sure there is no database migration missing?

            $match->association_id = $association->id;

The property association_id does not exist on App\PLMatch. Did you mean association?

            if (!empty($schedule->series)) {
                $match->series_id = $schedule->series->id;

The property series_id does not exist on App\PLMatch. Did you mean series?

                if (!empty($schedule->series->division)) {
                    $match->division_id = $schedule->series->division->id;

The property division does not seem to exist on App\Series. Are you sure there is no database migration missing?

The property division_id does not exist on App\PLMatch. Did you mean division?

                }
            }

            // Unique key fields:
            $match->schedule_id = $schedule->id;

The property schedule_id does not exist on App\PLMatch. Did you mean schedule?

            $match->round_id = $round->id;

The property round_id does not exist on App\PLMatch. Did you mean round?

            $match->venue_id = $venue->id;

The property venue_id does not exist on App\PLMatch. Did you mean venue?

            $match->sequence = 1;

The property sequence does not seem to exist on App\PLMatch. Are you sure there is no database migration missing?

            $match->start_date = $round->start_date;

The property start_date does not seem to exist on App\PLMatch. Are you sure there is no database migration missing?

            $match->end_date = $round->end_date;

The property end_date does not seem to exist on App\PLMatch. Are you sure there is no database migration missing?

            $match->save();
        }

        return redirect()->route('schedule.rounds', ['schedule' => $schedule]);

The expression return redirect()->route('schedule.rounds', array('schedule' => $schedule)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        //
    }

    public function edit(Schedule $schedule, Round $round)
    {
        return view('round.edit', [
            'schedule' => $schedule,
            'round' => $round,
        ]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param \App\Schedule $schedule
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $schedule, $id)
    {
        $validatedData = $request->validate([

The assignment to $validatedData is dead and can be removed.

            'name' => 'required|max:255',
            'start_date' => 'required|date',
        ]);

        $round = Round::find($id);

        $round->name = $request->name;
        $round->start_date = $request->start_date;
        $round->end_date = $request->end_date;
        $round->scores_closed = isset($request->scores_closed);

        $round->save();

        foreach ($round->matches as $match) {
            $home_team_id = $request->{'match_' . $match->id . '__home_team_id'};
            $away_team_id = $request->{'match_' . $match->id . '__away_team_id'};

            $match->home_team_id = $home_team_id;
            $match->away_team_id = $away_team_id;

            $match->save();
        }

        $request->session()->flash('message', __('Successfully updated round'));

        return redirect()->route('schedule.rounds', ['schedule' => $schedule]);

The expression return redirect()->route('schedule.rounds', array('schedule' => $schedule)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    public function deleteConfirm(Schedule $schedule, Round $round) {
        return view('round.delete-confirm', [
            'schedule' => $schedule,
            'round' => $round,
        ]);
    }

    public function destroy(Schedule $schedule, Round $round)
    {
        $round = Round::find($round->id);

        if (!empty($round)) {
            $round->delete();
        }

        return redirect()->route('schedule.rounds', ['schedule' => $schedule]);
    }
}