App\Http\Controllers\Api\AssociationsController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	8	1

<?php

namespace App\Http\Controllers\Api;

use App\Http\Controllers\Controller;

use App\Association;
use App\Division;
use App\Match;
use App\ResultSubmission;
use App\Round;
use App\Series;
use App\Schedule;
use App\User;
use App\Venue;

use App\Http\Resources\Association as AssociationResource;
use App\Http\Resources\AssociationCollection as AssociationCollectionResource;

use Bouncer;
use Illuminate\Http\Request;
use Illuminate\Support\Str;

class AssociationsController extends Controller
{

    public function __construct(Request $request) {

The parameter $request is not used and could be removed.

        $subdomain = array_first(explode('.', \Request::getHost()));

The function array_first() has been deprecated: Arr::first() should be used directly instead. Will be removed in Laravel 5.9.

        $this->association = Association::where('subdomain', $subdomain)->first();

The property association does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function index(Request $request) {
        $user = $request->user();

The assignment to $user is dead and can be removed.

        $userAssociations = Association::all()->filter(function ($association) {
            return Bouncer::can('manage', $association);
        });

        return new AssociationCollectionResource($userAssociations);
    }

}