ResultSubmissionsController::update() - Code Metrics - Inspection of "overwrite pre-existing team results" - samtny/league-frontend - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( ce45b0...ce343e )

by Sam

created 2019-06-27 13:46 UTC

ResultSubmissionsController::update() C

↳ Parent: ResultSubmissionsController

Complexity

Conditions	10
Paths	258

Size

Total Lines	71
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	47
c	1
b	0
f	0
nc	258
nop	2
dl	0
loc	71
rs	6.043

How to fix Long Method Complexity

<?php

namespace App\Http\Controllers;

use App\Association;
use App\Result;
use App\TeamResult;
use App\ResultSubmission;
use Illuminate\Http\Request;

class ResultSubmissionsController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Association $association)
    {
        return view('result_submissions.approve', ['association' => $association]);

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    public function store(/** @scrutinizer ignore-unused */ Request $request)
    {
        //
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    public function show(/** @scrutinizer ignore-unused */ $id)
    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    public function edit(/** @scrutinizer ignore-unused */ $id)
    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $submission = ResultSubmission::find($id);

        if ($request->delete == 'delete') {
            $submission->delete();
        }
        else {
            $result = Result::where('match_id', $submission->match_id)->first();

            if (empty($result)) {
                $result = new Result();
                $result->match_id = $submission->match_id;
            }

            $result->home_team_id = $submission->match->home_team_id;
            $result->away_team_id = $submission->match->away_team_id;
            $result->home_team_score = $submission->home_team_score;
            $result->away_team_score = $submission->away_team_score;

            $result->save();

            // home team result:
            $team_result = TeamResult::where('schedule_id', $submission->match->schedule_id)
                ->where('match_id', $submission->match_id)
                ->where('team_id', $result->home_team_id)
                ->first();

            if (empty($team_result)) {
                $team_result = new TeamResult();
                $team_result->schedule_id = $submission->match->schedule_id;
                $team_result->match_id = $submission->match->id;
                $team_result->team_id = $result->home_team_id;
            }

            $team_result->points = $result->home_team_score;
            $team_result->win = $result->home_team_id == $submission->win_team_id ? 1 : 0;
            $team_result->loss = $result->home_team_id != $submission->win_team_id ? 1 : 0;
            $team_result->tie = 0;
            $team_result->save();

            // away team result;
            $team_result = TeamResult::where('schedule_id', $submission->match->schedule_id)
                ->where('match_id', $submission->match_id)
                ->where('team_id', $result->away_team_id)
                ->first();

            if (empty($team_result)) {
                $team_result = new TeamResult();
                $team_result->schedule_id = $submission->match->schedule_id;
                $team_result->match_id = $submission->match->id;
                $team_result->team_id = $result->away_team_id;
            }

            $team_result->points = $result->away_team_score;
            $team_result->win = $result->away_team_id == $submission->win_team_id ? 1 : 0;
            $team_result->loss = $result->away_team_id != $submission->win_team_id ? 1 : 0;
            $team_result->tie = 0;
            $team_result->save();

            $submission->approved = TRUE;
            $submission->save();
        }

        $url = $request->url;

        if (!empty($url)) {
            return redirect($url)->with('success', 'Data saved successfully!');

        }

        return redirect()->route('user', ['id' => \Auth::user()->id]);

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    public function destroy(/** @scrutinizer ignore-unused */ $id)
    {
        //
    }
}


samtny / league-frontend

Push — master ( ce45b0...ce343e )

ResultSubmissionsController::update() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like