samson\core\Module::action()

Complexity

Conditions	23
Paths	3078

Size

Total Lines	108
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	39
CRAP Score	23

Importance

Changes	6
Bugs	2	Features	2

<?php
    public function action($methodName = null)
    {
        //trace( array_keys($this->controllers), true );

        // Get parameters from URL
        $parameters = url()->parameters;

        // NEW ASYNC EVENT CHAIN LOGIC
        // If this is AJAX request - try to call async handlers
        // Added support for SamsonJS special header
        if ((isset($_SERVER['HTTP_ACCEPT']) && $_SERVER['HTTP_ACCEPT'] == '*/*') || isset($_SERVER['HTTP_SJSASYNC']) || isset($_POST['SJSASYNC'])) {
            // Copy parameters
            $arguments = $parameters;
            array_unshift($arguments, url()->method);

            // Response
            $event_result = array();

            // Iterate supported methods
            for ($idx = 0; $idx < sizeof($arguments); $idx++) {

It seems like you are calling the size function sizeof() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $controller_name = self::ASYNC_PREFIX . $arguments[$idx];

                // Build async method handler name and try to find method in arguments list
                $callback = &$this->controllers[$controller_name];

                // If async controller handler exists
                if (isset($callback)) {
                    // Get function arguments without function name
                    $f_args = array_slice($arguments, $idx + 1);

                    // Remove used cells from array
                    $arguments = array_slice($arguments, $idx + 1);

                    // Decrease index as we change arguments size
                    $idx--;

                    // Perform event and collect event result data
                    $_event_result = call_user_func_array($callback, $f_args);

                    // Anyway convert event result to array
                    if (!is_array($_event_result)) $_event_result = array($_event_result);

It is generally a best practice to always use braces with control structures.

                    // If event successfully completed
                    if (!isset($_event_result['status']) || !$_event_result['status']) {
                        // Handle event chain fail
                        $_event_result['message'] = "\n" . 'Event failed: ' . $controller_name;

                        // Add event result array to results collection
                        $event_result = array_merge($event_result, $_event_result);

                        // Stop event-chain execution
                        break;
                    } // Add event result array to results collection
                    else $event_result = array_merge($event_result, $_event_result);

It is generally a best practice to always use braces with control structures.

                }
            }

            // If at least one event has been executed
            if (sizeof($event_result)) {
                // Set async responce
                s()->async(true);

                // Send success status
                header("HTTP/1.0 200 Ok");

                // Encode event result as json object
                echo json_encode($event_result, JSON_HEX_TAG | JSON_HEX_APOS | JSON_HEX_QUOT | JSON_HEX_AMP);

                return A_SUCCESS;

The constant A_SUCCESS has been deprecated with message: Действие контроллера выполнено успешно

            }
        }

        // Get HTTP request type
        $request_type = $_SERVER['REQUEST_METHOD'];

        // Controller by name
        $naming = $methodName;
        // Controller by server request type
        $request = !isset($methodName{0}) ? strtolower($request_type == 'GET' ? self::CTR_BASE : self::OBJ_PREFIX . $request_type) : '';
        // Universal controller
        $universal = self::CTR_UNI;

        // Controller selection logic chain
        $controller = (isset($this->controllers[$naming]) ? $this->controllers[$naming] :
            (isset($this->controllers[$request]) ? $this->controllers[$request] :
                (isset($this->controllers[$universal]) ? $this->controllers[$universal] : null)));

        // If we selected universal controller - change parameters signature
        if (isset($this->controllers[$universal]) && $controller == $this->controllers[$universal]) {
            // If method is specified - add it to universal controller parameters list
            if (isset(url()->method{0})) array_unshift($parameters, url()->method);

It is generally a best practice to always use braces with control structures.

        }

        // Retrieve controller action callback name
        $controllerName = is_array($controller) ? $controller[1] : $controller;
        // If this controller has cached marker
        if (stripos($controllerName, self::CTR_CACHE) !== false) {
            // perform caching
            s()->cached();
        }
        //elapsed('Performing #'.$this->id.' controller action -'.$controller);

        // Perform controller action
        $action_result = isset($controller) ? call_user_func_array($controller, $parameters) : A_FAILED;

The constant A_FAILED has been deprecated with message: Действие контроллера НЕ выполнено

        // Stop candidate search
        return !isset($action_result) ? A_SUCCESS : $action_result;

The constant A_SUCCESS has been deprecated with message: Действие контроллера выполнено успешно

    }