Core::start() - Code Metrics - Inspection of "Added comments" - samsonos/php_core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( b1f1bc )

by Vitaly

created 2016-07-31 14:37 UTC

Core::start() B

↳ Parent: Core

Complexity

Conditions	5
Paths	8

Size

Total Lines	40
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
c	2
b	0
f	2
dl	0
loc	40
rs	8.439
cc	5
eloc	14
nc	8
nop	1

<?php
namespace samsonphp\core;

use samsonframework\core\SystemInterface;
use samsonframework\resource\ResourceMap;
use samsonphp\config\Scheme;
use samsonphp\event\Event;

/**
 * Core
 *
 * @package samsonphp/core
 * @author 	Vitaly Iegorov <[email protected]>
 */
class Core implements SystemInterface
{
    /** @var string Current system environment */
    protected $environment;

    /**
     * Core constructor
     */
    public function __construct()
    {
        // TODO: Remove as hard dependency - create bridge/etc
        $whoops = new \Whoops\Run;
        $whoops->pushHandler(new \Whoops\Handler\PrettyPageHandler);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $whoops->register();

        // Fire core creation event
        Event::fire('core.created', array(&$this));

        // Signal core configure event
        Event::signal('core.configure', array($this->system_path . __SAMSON_CONFIG_PATH));
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Change current system working environment or receive
     * current system enviroment if no arguments are passed.
     *
     * @param string $environment Environment identifier
     *
     * TODO: Function has two different logics - needs to be changed!
     * @return $this|string Chaining or current system environment
     */
    public function environment($environment = Scheme::BASE)
    {
        if (func_num_args() !== 0) {
            $this->environment = $environment;

            // Signal core environment change
            Event::signal('core.environment.change', array($environment, &$this));
            return $this;
        }

        return $this->environment;
    }

    /**
     * Start SamsonPHP framework.
     *
     * @param string $default Default module identifier
     *
     * @throws ViewPathNotFound
     */
    public function start($default)
    {
        // Fire core started event
        Event::fire('core.started');

        // Security layer
        $securityResult = true;
        // Fire core security event
        Event::fire('core.security', array(&$this, &$securityResult));

        /** @var mixed $result External route controller action result */
        $result = false;

        // If we have passed security application layer
        if ($securityResult) {
            // Fire core routing event - go to routing application layer
            Event::signal('core.routing', array(&$this, &$result, $default));
        }

        // If no one has passed back routing callback
        if (!isset($result) || $result === false) {
            // Fire core e404 - routing failed event
            $result = Event::signal('core.e404', array(url()->module, url()->method));
        }

        // Response
        $output = '';

        // If this is not asynchronous response and controller has been executed
        if ($result !== false) {
            // Fire after render event
            Event::fire('core.rendered', array(&$output));
        }

        // Output results to client
        echo $output;

        // Fire ended event
        Event::fire('core.ended', array(&$output));
    }
}


1			<?php
2			namespace samsonphp\core;
3
4			use samsonframework\core\SystemInterface;
5			use samsonframework\resource\ResourceMap;
6			use samsonphp\config\Scheme;
7			use samsonphp\event\Event;
8
9			/**
10			* Core
11			*
12			* @package samsonphp/core
13			* @author Vitaly Iegorov <[email protected]>
14			*/
15			class Core implements SystemInterface
16			{
17			/** @var string Current system environment */
18			protected $environment;
19
20			/**
21			* Core constructor
22			*/
23			public function __construct()
24			{
25			// TODO: Remove as hard dependency - create bridge/etc
26			$whoops = new \Whoops\Run;
27			$whoops->pushHandler(new \Whoops\Handler\PrettyPageHandler);
			0 ignored issues – show Documentation introduced 2016-01-20 15:57 UTC by Report Bug Copy Issue Report `new \Whoops\Handler\PrettyPageHandler()` is of type `object<Whoops\Handler\PrettyPageHandler>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			$whoops->register();
29
30			// Fire core creation event
31			Event::fire('core.created', array(&$this));
32
33			// Signal core configure event
34			Event::signal('core.configure', array($this->system_path . __SAMSON_CONFIG_PATH));
			0 ignored issues – show Bug introduced 2016-07-31 14:45 UTC by Report Bug Copy Issue Report The property `system_path` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35			}
36
37			/**
38			* Change current system working environment or receive
39			* current system enviroment if no arguments are passed.
40			*
41			* @param string $environment Environment identifier
42			*
43			* TODO: Function has two different logics - needs to be changed!
44			* @return $this\|string Chaining or current system environment
45			*/
46			public function environment($environment = Scheme::BASE)
47			{
48			if (func_num_args() !== 0) {
49			$this->environment = $environment;
50
51			// Signal core environment change
52			Event::signal('core.environment.change', array($environment, &$this));
53			return $this;
54			}
55
56			return $this->environment;
57			}
58
59			/**
60			* Start SamsonPHP framework.
61			*
62			* @param string $default Default module identifier
63			*
64			* @throws ViewPathNotFound
65			*/
66			public function start($default)
67			{
68			// Fire core started event
69			Event::fire('core.started');
70
71			// Security layer
72			$securityResult = true;
73			// Fire core security event
74			Event::fire('core.security', array(&$this, &$securityResult));
75
76			/** @var mixed $result External route controller action result */
77			$result = false;
78
79			// If we have passed security application layer
80			if ($securityResult) {
81			// Fire core routing event - go to routing application layer
82			Event::signal('core.routing', array(&$this, &$result, $default));
83			}
84
85			// If no one has passed back routing callback
86			if (!isset($result) \|\| $result === false) {
87			// Fire core e404 - routing failed event
88			$result = Event::signal('core.e404', array(url()->module, url()->method));
89			}
90
91			// Response
92			$output = '';
93
94			// If this is not asynchronous response and controller has been executed
95			if ($result !== false) {
96			// Fire after render event
97			Event::fire('core.rendered', array(&$output));
98			}
99
100			// Output results to client
101			echo $output;
102
103			// Fire ended event
104			Event::fire('core.ended', array(&$output));
105			}
106			}
107

samsonos / php_core

Push — 2.0 ( b1f1bc )

Core::start() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like