samson\activerecord\dbMySQLConnector::relations()

Complexity

Conditions	18
Paths	3

Size

Total Lines	134
Code Lines	55

Duplication

Lines	13
Ratio	9.7 %

Importance

Changes	9
Bugs	1	Features	3

<?php 
    public function relations($cachePath = '')
    {
        // Generate unique file name
        $relations_file = $cachePath . '/relations/' . md5(serialize(TableRelation::$instances)) . '.php';

        // Relations file does not exists - create it
        if (!file_exists($relations_file)) {
            // Get directory path
            $dir = pathname($relations_file);

            // Create folder
            if (!file_exists($dir)) mkdir($dir, 0777, TRUE);

It is generally a best practice to always use braces with control structures.

TRUE, FALSE and NULL must be lowercase; expected true, but found TRUE.

            //  Clear folder
            else File::clear($dir);

It is generally a best practice to always use braces with control structures.

            // Processed permanent table relations
            $db_relations = array();

            // Iterate permanent relations
            foreach (TableRelation::$instances as $row) {
                // Create relations data for specific table
                if (!isset($db_relations[$row->parent])) $db_relations[$row->parent] = array();

It is generally a best practice to always use braces with control structures.

                // Define child relation table name
                $child_relation = !isset($row->alias{0}) ? $row->child : $row->alias;

                $row->parent = self::$prefix . $row->parent;
                $row->child = self::$prefix . $row->child;

                // Save relation data
                $db_relations[$row->parent][$child_relation] = $row;
            }

            // TODO: Pass generator and others via constructor DI

            // Create code generator instance
            $g = new Generator('samson\activerecord');
            $g->multicomment(array('Static ActiveRecord generated table relations'));

            // Array of "FROM" sql statements for related tables
            $sql_from = array();

            // Array of "SELECT" sql statements for related tables
            $sql_select = array();

            // Array related tables columns names and aliases
            $relations = array();

            // Array of table aliases
            $aliases = array();

            // Array of table relation type
            $types = array();

            // Array of columns map
            $map = array();

            // Iterate grouped relations
            foreach ($db_relations as $parent => $relation) {
                // Check if parent class in relation exists
                if (class_exists(__NAMESPACE__ . '\\' . $parent, false)) {
                    // Iterate table permanent relations
                    foreach ($relation as $r_table => $i) {
                        // Array of "SELECT" sql statements for this related tables
                        $_sql_select = array();

                        // Array related tables columns names and aliases for this related tables
                        $_relations = array();

                        // Parent table name
                        $r_table_name = isset($i->alias{0}) ? $i->alias : $i->child;

                        // Define start of join sql statement
                        $_sql_from = 'LEFT JOIN `' . $i->child . '`';
                        // If relation alias is defined
                        if (isset($i->alias{0})) $_sql_from = 'LEFT JOIN `' . $i->child . '` AS ' . $i->alias;

It is generally a best practice to always use braces with control structures.

                        // Parent table name
                        $ptable = $i->parent;

                        // If parent field not specified - use parent table primary field
                        if (!isset($i->parent_field)) $pfield = $primary_field;

The variable $primary_field does not exist. Did you forget to declare it?

This code seems to be duplicated across your project.

It is generally a best practice to always use braces with control structures.

                        // Correctly determine parent field name
                        else {
                            // Define if parent field name has table name in it
                            $tableinpf = strpos($i->parent_field, '.');

                            // Get parent table field name
                            $pfield = $tableinpf !== false ? substr($i->parent_field, $tableinpf + 1) : $i->parent_field;

                            // Parent table field
                            $ptable = $tableinpf !== false ? dbMySQLConnector::$prefix . substr($i->parent_field, 0, $tableinpf) : $i->parent;
                        }

                        // If no "." symbol in parent field name append parent table name
                        $pf = '`' . $ptable . '`.`' . $pfield . '`';

                        // If child field not specified
                        if (!isset($i->child_field{0})) $cf = '`' . (isset($i->alias{0}) ? $i->alias : $i->child) . '`.`' . $pfield . '`';
                        // If no "." symbol in child field name append child table name
                        else $cf = strpos($i->child_field, '.') === false ? '`' . (isset($i->alias{0}) ? $i->alias : $i->child) . '`.' . $i->child_field : $i->child_field;

This code seems to be duplicated across your project.

                        // Build columns metadata
                        $this->__build_columns_map($i->child, $_sql_select, $map, $_relations, $i->alias);

                        // Array of "SELECT" sql statements to all related tables
                        $sql_select[$r_table_name] = implode(',', $_sql_select);
                        $relations[$r_table_name] = $_relations;
                        $sql_from[$r_table_name] = $_sql_from . ' ON ' . $pf . ' = ' . $cf;
                        $aliases[$r_table_name] = $i->child;
                        $types[$r_table_name] = $i->type;
                    }

                    // Remove prefix
                    $class_name = str_replace(self::$prefix, '', $parent);

                    // Generate code for this table
                    $g->newline()
                        ->comment('Relation data for table "' . $parent . '"')
                        ->defarraymerge($class_name . '::$_sql_from', $sql_from)
                        ->defarraymerge($class_name . '::$_sql_select', $sql_select)
                        ->defarraymerge($class_name . '::$_map', $map)
                        ->defvar($class_name . '::$_relation_alias', $aliases)
                        ->defvar($class_name . '::$_relation_type', $types)
                        ->defvar($class_name . '::$_relations', $relations);
                }
            }

            // Save file to wwwrot
            $g->write($relations_file);
        } // Or just include file

        include($relations_file);
    }