samsonframework\stringconditiontree\string\VariableFixedCG

Complexity

Total Complexity

3

Size/Duplication

Total Lines	57
Duplicated Lines	17.54 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	10	10	1
A	isFixed()	0	4	1
A	compareLength()	0	17	1

<?php declare(strict_types=1);
/**
 * Created by Vitaly Iegorov <egorov@samsonos.com>.
 * on 06.04.17 at 07:34
 */
namespace samsonframework\stringconditiontree\string;

/**
 * This class describes character group with next structure:
 * - variable length character group
 * - fixed length character group
 *
 * @author Vitaly Egorov <egorov@samsonos.com>
 */
class VariableFixedCG extends AbstractCharacterGroup
{
    /** string Character group matching regexp pattern matching group name */
    const PATTERN_GROUP = 'variableFixed';

    /** string Character group matching regexp pattern */
    const PATTERN = '(?<'.self::PATTERN_GROUP.'>'.VariableCG::PATTERN_REGEXP.FixedCG::PATTERN_REGEXP.')';

    /** @var VariableCG */
    protected $variableCG;

    /** @var FixedCG */
    protected $fixedCG;

    /**
     * @inheritdoc
     */
    public function __construct(string $string, int $length = 0)

This method seems to be duplicated in your project.

    {
        $this->size = 2;

        parent::__construct($string, $length);

        // Parse internal character groups
        $this->variableCG = VariableCG::fromString($string);
        $this->fixedCG = FixedCG::fromString($string);
    }

    /**
     * @return bool True if character group is fixed length otherwise false
     */
    public function isFixed(): bool
    {
        return $this instanceof self;
    }

    /**
     * @inheritdoc
     */
    protected function compareLength(AbstractCharacterGroup $group): int
    {
        /** @var VariableFixedCG $group */

        // Shorter FCG has higher priority
        $return = $this->fixedCG->length <=> $group->fixedCG->length;

The property fixedCG does not seem to exist in samsonframework\stringconditiontree\string\AbstractCharacterGroup.

        // Fixed CG are equal
//        if ($return === 0) {
//            // Longer first VCG has higher priority
//            $return = $this->variableCG->length <=> $group->variableCG->length;
//        }
        // TODO: Check for filtering pattern and VCG with filter has priority
        // TODO: But how to compare filters if present?

        return $return;
    }
}