samsonframework\stringconditiontree\string\FixedVariableFixedCG

Complexity

Total Complexity

4

Size/Duplication

Total Lines	55
Duplicated Lines	16.36 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	9	9	1
A	compareLength()	0	21	3

<?php declare(strict_types=1);
/**
 * Created by Vitaly Iegorov <egorov@samsonos.com>.
 * on 06.04.17 at 07:34
 */
namespace samsonframework\stringconditiontree\string;

/**
 * This class describes character group with next structure:
 * - fixed length character group
 * - variable length character group
 * - fixed length character group
 *
 * @author Vitaly Egorov <egorov@samsonos.com>
 */
class FixedVariableFixedCG extends AbstractCharacterGroup
{
    /** string Character group matching regexp pattern matching group name */
    const PATTERN_GROUP = 'fixedVariableFixed';

    /** string Character group matching regexp pattern */
    const PATTERN = '(?<'.self::PATTERN_GROUP.'>'.FixedCG::PATTERN_REGEXP.VariableCG::PATTERN_REGEXP.FixedCG::PATTERN_REGEXP.')';

    /** @var FixedCG */
    protected $firstFixedCG;

    /** @var VariableCG */
    protected $variableCG;

    /** @var FixedCG */
    protected $lastFixedCG;

    /**
     * @inheritdoc
     */
    public function __construct(string $string, int $length = 0)

This method seems to be duplicated in your project.

    {
        parent::__construct($string, $length);

        // Parse internal character groups
        $this->firstFixedCG = FixedCG::fromString($string);
        $this->variableCG = VariableCG::fromString($string);
        $this->lastFixedCG = FixedCG::fromString($string);
    }

    /**
     * @inheritdoc
     */
    protected function compareLength(AbstractCharacterGroup $group): int
    {
        /** @var FixedVariableFixedCG $group */

        // Shorter first FCG has higher priority
        $return = $group->firstFixedCG->length <=> $this->firstFixedCG->length;

The property firstFixedCG does not seem to exist in samsonframework\stringconditiontree\string\AbstractCharacterGroup.

        // First FCG are equal
        if ($return === 0) {
            // Longer last FCG has higher priority
            $return = $this->lastFixedCG->length <=> $group->lastFixedCG->length;

The property lastFixedCG does not seem to exist in samsonframework\stringconditiontree\string\AbstractCharacterGroup.

            // Last FCG are equal
            if ($return === 0) {
                // Longer VCG has higher priority
                $return = $this->variableCG->length <=> $group->variableCG->length;

The property variableCG does not seem to exist in samsonframework\stringconditiontree\string\AbstractCharacterGroup.

            }
        }

        return $return;
    }
}