Manager::save() - Code Metrics - Inspection of "Added deps" - samsonframework/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( be1dc2...d56e9e )

by Vitaly

created 2016-09-02 11:43 UTC

Manager::save() A

↳ Parent: Manager

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	2
c	1
b	0
f	1
nc	1
nop	1
dl	0
loc	21
rs	9.3142

<?php declare(strict_types = 1);
/**
 * Created by PhpStorm.
 * User: VITALYIEGOROV
 * Date: 30.11.15
 * Time: 16:38
 */
namespace samsonframework\orm;

/**
 * Database entity manager.
 *
 * @author Vitaly Egorov <[email protected]>
 */
class Manager
{
    /** @var string Entity identifier */
    protected $entityName;

    /** @var string Entity primary field name */
    protected $primaryFieldName;

    /** @var array Collection of entity fields that could be used in queries */
    protected $queryFields = array();

    /** @var array Collection of entity field names and their types */
    protected $fieldsAndTypes = array();

    /** @var DatabaseInterface Database manager */
    protected $database;

    /**
     * Manager constructor.
     *
     * @param DatabaseInterface $database   database low-level driver
     * @param string            $entityName Entity name
     * @param array             $attributes Key-value collection with field name => type
     */
    public function __construct(DatabaseInterface $database, string $entityName, $attributes)
    {
        $this->database = $database;
        $this->entityName = $entityName;
        $this->fieldsAndTypes = $attributes;
    }

    /**
     * Store entity into database.
     *
     * @param mixed $entity Database entity
     */
    public function save($entity)
    {
        $fields = $this->getFields($entity);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
//
//        $this->execute('INSERT INTO `' . $this->entityName . '` (`'
//            . implode('`,`', array_keys($fields)) . '`) VALUES (' . implode(',', $fields) . ')'
//        );

// Generate entity fields update command
//        $fields = array();
//        foreach ($this->getFields($entity) as $fieldName => $fieldValue) {
//            $fields[] = '`'.$this->entityName.'`.`'.$fieldName.'` = "'.$fieldValue.'"';
//        }
//
//        $this->execute('UPDATE `' . $this->entityName . '` SET '
//            . implode(',', $fields)
//            . ' WHERE `' . $this->entityName . '`.`' . $this->primaryFieldName . '`="'
//            . $this->quote($entity->id) . '"');

        //$this->database->
    }

    /**
     * Get new entity instance.
     *
     * @return mixed Entity instance
     */
    public function create()
    {
        return new $this->entityName($this);
    }

    /**
     * Convert RecordInterface instance to collection of its field name => value,
     * returning only fields that needs to participate in SQL statements.
     * TODO: We need to generate this collection in entity class generation.
     *
     * @param RecordInterface $object Database record instance to convert
     * @return array Collection of key => value with SQL fields statements
     */
    protected function &getQueryFields(RecordInterface &$object = null)
    {
        $collection = array();
        foreach ($this->fieldsAndTypes as $attribute => $type) {
            if ($type == 'timestamp') {
                continue;
            } elseif ($this->primaryFieldName == $attribute) {
                continue;
            }

            $collection[$attribute] = $object->$attribute;
        }

        return $collection;
    }

//    /**
//     * Create new database entity record.
//     * @param RecordInterface $entity Entity record for creation
//     * @return RecordInterface Created database entity record with new primary identifier
//     */
//    public function create(RecordInterface $entity)
//    {
//        $fields = $this->getFields($entity);
//
//        $this->execute('INSERT INTO `' . $this->entityName . '` (`'
//            . implode('`,`', array_keys($fields)) . '`) VALUES (' . implode(',', $fields) . ')'
//        );
//    }
//
//    /**
//     * Read database entity records from QueryInterface.
//     *
//     * @param QueryInterface $query For retrieving records
//     * @return RecordInterface[] Collection of read database entity records
//     */
//    public function read(QueryInterface $query)
//    {
//        // TODO: Implement read() method.
//    }
//
//    /**
//     * Update database entity record.
//     *
//     * @param RecordInterface $entity Entity record for updating
//     */
//    public function update(RecordInterface $entity)
//    {
//        // Generate entity fields update command
//        $fields = array();
//        foreach ($this->getFields($entity) as $fieldName => $fieldValue) {
//            $fields[] = '`'.$this->entityName.'`.`'.$fieldName.'` = "'.$fieldValue.'"';
//        }
//
//        $this->execute('UPDATE `' . $this->entityName . '` SET '
//            . implode(',', $fields)
//            . ' WHERE `' . $this->entityName . '`.`' . $this->primaryFieldName . '`="'
//            . $this->quote($entity->id) . '"');
//    }
//
//    /**
//     * Delete database record from database.
//     *
//     * @param RecordInterface $entity Entity record for removing
//     */
//    public function delete(RecordInterface $entity)
//    {
//        $this->execute('DELETE FROM `' . $this->entityName . '` WHERE '
//            . $this->primaryFieldName . ' = "' . $this->quote($entity->id) . '"'
//        );
//    }
}


1			<?php declare(strict_types = 1);
2			/**
3			* Created by PhpStorm.
4			* User: VITALYIEGOROV
5			* Date: 30.11.15
6			* Time: 16:38
7			*/
8			namespace samsonframework\orm;
9
10			/**
11			* Database entity manager.
12			*
13			* @author Vitaly Egorov <[email protected]>
14			*/
15			class Manager
16			{
17			/** @var string Entity identifier */
18			protected $entityName;
19
20			/** @var string Entity primary field name */
21			protected $primaryFieldName;
22
23			/** @var array Collection of entity fields that could be used in queries */
24			protected $queryFields = array();
25
26			/** @var array Collection of entity field names and their types */
27			protected $fieldsAndTypes = array();
28
29			/** @var DatabaseInterface Database manager */
30			protected $database;
31
32			/**
33			* Manager constructor.
34			*
35			* @param DatabaseInterface $database database low-level driver
36			* @param string $entityName Entity name
37			* @param array $attributes Key-value collection with field name => type
38			*/
39			public function __construct(DatabaseInterface $database, string $entityName, $attributes)
40			{
41			$this->database = $database;
42			$this->entityName = $entityName;
43			$this->fieldsAndTypes = $attributes;
44			}
45
46			/**
47			* Store entity into database.
48			*
49			* @param mixed $entity Database entity
50			*/
51			public function save($entity)
52			{
53			$fields = $this->getFields($entity);
			0 ignored issues – show Bug introduced 2016-09-02 11:49 UTC by Report Bug Copy Issue Report The method `getFields()` does not seem to exist on `object<samsonframework\orm\Manager>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Unused Code introduced 2016-09-02 11:49 UTC by Report Bug Copy Issue Report `$fields` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
54			//
55			// $this->execute('INSERT INTO `' . $this->entityName . '` (`'
56			// . implode('`,`', array_keys($fields)) . '`) VALUES (' . implode(',', $fields) . ')'
57			// );
58
59			// Generate entity fields update command
60			// $fields = array();
61			// foreach ($this->getFields($entity) as $fieldName => $fieldValue) {
62			// $fields[] = '`'.$this->entityName.'`.`'.$fieldName.'` = "'.$fieldValue.'"';
63			// }
64			//
65			// $this->execute('UPDATE `' . $this->entityName . '` SET '
66			// . implode(',', $fields)
67			// . ' WHERE `' . $this->entityName . '`.`' . $this->primaryFieldName . '`="'
68			// . $this->quote($entity->id) . '"');
69
70			//$this->database->
71			}
72
73			/**
74			* Get new entity instance.
75			*
76			* @return mixed Entity instance
77			*/
78			public function create()
79			{
80			return new $this->entityName($this);
81			}
82
83			/**
84			* Convert RecordInterface instance to collection of its field name => value,
85			* returning only fields that needs to participate in SQL statements.
86			* TODO: We need to generate this collection in entity class generation.
87			*
88			* @param RecordInterface $object Database record instance to convert
89			* @return array Collection of key => value with SQL fields statements
90			*/
91			protected function &getQueryFields(RecordInterface &$object = null)
92			{
93			$collection = array();
94			foreach ($this->fieldsAndTypes as $attribute => $type) {
95			if ($type == 'timestamp') {
96			continue;
97			} elseif ($this->primaryFieldName == $attribute) {
98			continue;
99			}
100
101			$collection[$attribute] = $object->$attribute;
102			}
103
104			return $collection;
105			}
106
107			// /**
108			// * Create new database entity record.
109			// * @param RecordInterface $entity Entity record for creation
110			// * @return RecordInterface Created database entity record with new primary identifier
111			// */
112			// public function create(RecordInterface $entity)
113			// {
114			// $fields = $this->getFields($entity);
115			//
116			// $this->execute('INSERT INTO `' . $this->entityName . '` (`'
117			// . implode('`,`', array_keys($fields)) . '`) VALUES (' . implode(',', $fields) . ')'
118			// );
119			// }
120			//
121			// /**
122			// * Read database entity records from QueryInterface.
123			// *
124			// * @param QueryInterface $query For retrieving records
125			// * @return RecordInterface[] Collection of read database entity records
126			// */
127			// public function read(QueryInterface $query)
128			// {
129			// // TODO: Implement read() method.
130			// }
131			//
132			// /**
133			// * Update database entity record.
134			// *
135			// * @param RecordInterface $entity Entity record for updating
136			// */
137			// public function update(RecordInterface $entity)
138			// {
139			// // Generate entity fields update command
140			// $fields = array();
141			// foreach ($this->getFields($entity) as $fieldName => $fieldValue) {
142			// $fields[] = '`'.$this->entityName.'`.`'.$fieldName.'` = "'.$fieldValue.'"';
143			// }
144			//
145			// $this->execute('UPDATE `' . $this->entityName . '` SET '
146			// . implode(',', $fields)
147			// . ' WHERE `' . $this->entityName . '`.`' . $this->primaryFieldName . '`="'
148			// . $this->quote($entity->id) . '"');
149			// }
150			//
151			// /**
152			// * Delete database record from database.
153			// *
154			// * @param RecordInterface $entity Entity record for removing
155			// */
156			// public function delete(RecordInterface $entity)
157			// {
158			// $this->execute('DELETE FROM `' . $this->entityName . '` WHERE '
159			// . $this->primaryFieldName . ' = "' . $this->quote($entity->id) . '"'
160			// );
161			// }
162			}
163

samsonframework / orm

Push — master ( be1dc2...d56e9e )

Manager::save() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like