samsonframework\orm\Condition

Complexity

Total Complexity

9

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	3
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	addArgument()	0	5	1
A	addCondition()	0	5	1
B	add()	0	13	5
A	__construct()	0	4	2

<?php
namespace samsonframework\orm;

/**
 * Query condition arguments group
 * @author Vitaly Iegorov <egorov@samsonos.com>
 * @version 2.0
 */
class Condition
{
    /** AND(conjunction) - Condition relation type */
    const REL_AND = 'AND';

    /** OR(disjunction) - Condition relation type */
    const REL_OR = 'OR';

    /** @var Argument[] Collection of condition arguments */
    public $arguments = array();

    /** @var string Relation logic between arguments */
    public $relation = self::REL_AND;

    /**
     * Add condition argument to this condition group
     * @param Argument $argument Condition argument to be added
     */
    public function addArgument(Argument $argument)
    {
        // Add condition as current condition argument
        $this->arguments[] = $argument;
    }

    /**
     * Add condition group to this condition group
     * @param Condition $condition Condition group to be added
     */
    public function addCondition(self $condition)
    {
        // Add condition as current condition argument
        $this->arguments[] = $condition;
    }

    /**
     * Generic condition addiction function
     * @param self|Argument|string $argument Entity for adding to arguments collection
     * @param string $value Argument value
     * @param string $relation Relation between argument and value
     * @return self Chaining
     */
    public function add($argument, $value = '', $relation = Relation::EQUAL)
    {
        if (is_string($argument) || is_scalar($argument)) {
            // Add new argument to arguments collection
            $this->arguments[] = new Argument($argument, $value, $relation);
        } elseif (is_a($argument, get_class($this))) {
            $this->addCondition($argument);

$argument is of type object<samsonframework\orm\Condition>|object<samsonframework\orm\Argument>, but the function expects a object<self>.

        } elseif (is_a($argument, __NAMESPACE__.'Argument')) {
            $this->addArgument($argument);

It seems like $argument defined by parameter $argument on line 50 can also be of type object<samsonframework\orm\Condition>; however, samsonframework\orm\Condition::addArgument() does only seem to accept object<samsonframework\orm\Argument>, maybe add an additional type check?

        }

        return $this;
    }

    /**
     * Constructor
     * @param string $relation Relation type between arguments
     */
    public function __construct($relation = null)
    {
        $this->relation = isset($relation) ? $relation : self::REL_AND;
    }
}