CodeTrait::buildArguments() - Code Metrics - Inspection of "Added IfGenerator and its ConditionGenerator" - samsonframework/generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6daa93...1805b3 )

by Vitaly

created 2017-04-03 07:53 UTC

CodeTrait::buildArguments() A

↳ Parent: CodeTrait

Complexity

Conditions	4
Paths	5

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	8
cts	8
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	5
nop	2
crap	4

<?php declare(strict_types=1);
/**
 * Created by Vitaly Iegorov <[email protected]>.
 * on 04.09.16 at 10:13
 */
namespace samsonframework\generator;

/**
 * Trait for generators that can generate internal code.
 *
 * @author Vitaly Egorov <[email protected]>
 */
trait CodeTrait
{
    /** @var array Collection of code lines */
    protected $code = [];

    /**
     * Define code condition block.
     *
     * @return ConditionGenerator Condition generator instance
     */
    public function defIf(): IfGenerator
    {
        return (new IfGenerator($this))->setIndentation($this->indentation)->increaseIndentation();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Add function code line.
     *
     * @param string $code Code line
     *
     * @return $this
     */
    public function defLine(string $code)
    {
        $this->code[] = $code;

        return $this;
    }

    /**
     * Build arguments list with types.
     *
     * @param array $arguments Arguments collection
     * @param array $defaults Arguments default values collection
     *
     * @return string Arguments list
     */
    protected function buildArguments(array $arguments, array $defaults = []) : string
    {
        $argumentsString = [];
        $defaults = array_filter($defaults);
        foreach ($arguments as $argumentName => $argumentType) {
            // Group name with type
            $argumentsString[] = ($argumentType !== null ? $argumentType . ' ' : '') .
                '$' . $argumentName .
                (array_key_exists($argumentName, $defaults) ? ' = ' . $defaults[$argumentName] : '');
        }

        return implode(', ', $argumentsString);
    }
}


1		<?php declare(strict_types=1);
2		/**
3		* Created by Vitaly Iegorov <[email protected]>.
4		* on 04.09.16 at 10:13
5		*/
6		namespace samsonframework\generator;
7
8		/**
9		* Trait for generators that can generate internal code.
10		*
11		* @author Vitaly Egorov <[email protected]>
12		*/
13		trait CodeTrait
14		{
15		/** @var array Collection of code lines */
16		protected $code = [];
17
18		/**
19		* Define code condition block.
20		*
21		* @return ConditionGenerator Condition generator instance
22		*/
23		public function defIf(): IfGenerator
24		{
25		return (new IfGenerator($this))->setIndentation($this->indentation)->increaseIndentation();
		0 ignored issues – show Bug introduced 2017-04-03 07:57 UTC by Report Bug Copy Issue Report The property `indentation` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26		}
27
28		/**
29		* Add function code line.
30		*
31		* @param string $code Code line
32		*
33		* @return $this
34		*/
35	39	public function defLine(string $code)
36		{
37	39	$this->code[] = $code;
38
39	39	return $this;
40		}
41
42		/**
43		* Build arguments list with types.
44		*
45		* @param array $arguments Arguments collection
46		* @param array $defaults Arguments default values collection
47		*
48		* @return string Arguments list
49		*/
50	22	protected function buildArguments(array $arguments, array $defaults = []) : string
51		{
52	22	$argumentsString = [];
53	22	$defaults = array_filter($defaults);
54	22	foreach ($arguments as $argumentName => $argumentType) {
55		// Group name with type
56	11	$argumentsString[] = ($argumentType !== null ? $argumentType . ' ' : '') .
57	11	'$' . $argumentName .
58	11	(array_key_exists($argumentName, $defaults) ? ' = ' . $defaults[$argumentName] : '');
59		}
60
61	22	return implode(', ', $argumentsString);
62		}
63		}
64

samsonframework / generator

Push — master ( 6daa93...1805b3 )

CodeTrait::buildArguments() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like