samsonframework\container\resolver\AnnotationMethodResolver

Complexity

Total Complexity

5

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	resolve()	0	9	2
A	resolveMethodAnnotations()	0	17	3

<?php
/**
 * Created by Vitaly Iegorov <egorov@samsonos.com>.
 * on 07.08.16 at 13:04
 */
namespace samsonframework\container\resolver;

use samsonframework\container\annotation\MethodInterface;
use samsonframework\container\metadata\ClassMetadata;
use samsonframework\container\metadata\MethodMetadata;

/**
 * Class method annotation resolver.
 */
class AnnotationMethodResolver extends AbstractAnnotationResolver implements AnnotationResolverInterface
{
    /**
     * {@inheritDoc}
     */
    public function resolve(\ReflectionClass $classData, ClassMetadata $classMetadata)
    {
        /** @var \ReflectionMethod $method */
        foreach ($classData->getMethods() as $method) {
            $this->resolveMethodAnnotations($method, $classMetadata);
        }

        return $this->classMetadata;
    }

    /**
     * Resolve class method annotations.
     *
     * @param \ReflectionMethod $method
     * @param ClassMetadata     $classMetadata
     */
    protected function resolveMethodAnnotations(\ReflectionMethod $method, ClassMetadata $classMetadata)
    {
        // Create method metadata instance
        $methodMetadata = new MethodMetadata();
        $methodMetadata->name = $method->getName();

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

        $methodMetadata->modifiers = $method->getModifiers();
        $methodMetadata->parameters = $method->getParameters();

        /** @var MethodInterface $annotation */
        foreach ($this->reader->getMethodAnnotations($method) as $annotation) {
            if ($annotation instanceof MethodInterface) {
                $methodMetadata->options[] = $annotation->toMethodMetadata($methodMetadata);
            }
        }

        $classMetadata->methodsMetadata[$method->getName()] = $methodMetadata;

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

    }
}