XmlMetadataCollector::xml2array() - Code Metrics - Inspection of "Added splitted annotation collectors classes and t..." - samsonframework/container - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 01582c...42d944 )

by Vitaly

created 2016-08-20 10:27 UTC

XmlMetadataCollector::xml2array() A

↳ Parent: XmlMetadataCollector

Complexity

Conditions	4
Paths	5

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	4
nc	5
nop	2
crap	4

<?php declare(strict_types = 1);
/**
 * Created by Vitaly Iegorov <[email protected]>.
 * on 20.08.16 at 12:39
 */
namespace samsonframework\container;

use samsonframework\container\collection\CollectionClassResolver;

/**
 * XML class metadata collector.
 * Class resolves and collects class metadata from XML string.
 *
 * @author Vitaly Egorov <[email protected]>
 */
class XmlMetadataCollector extends AbstractMetadataCollector
{
    /**
     * {@inheritdoc}
     */
    public function collect($xmlConfig) : array
    {
        $classesMetadata = [];

        // Iterate config and resolve single instance
        foreach ($this->xml2array(new \SimpleXMLElement($xmlConfig)) as $key => $classesArrayData) {
            if ($key === CollectionClassResolver::KEY) {
                /** @var array $classesArrayData */
                foreach ($classesArrayData as $classArrayData) {
                    $classesMetadata[] = $this->resolver->resolve($classArrayData);
class MyClass { }

$x = new MyClass();
$x->foo = true;
                }
            }
        }

        return $classesMetadata;
    }

    /**
     * function xml2array
     *
     * This function is part of the PHP manual.
     *
     * The PHP manual text and comments are covered by the Creative Commons
     * Attribution 3.0 License, copyright (c) the PHP Documentation Group
     *
     * @param \SimpleXMLElement|array $xmlObject
     * @param array                   $out
     *
     * @return array XML converted array
     *
     * @author  k dot antczak at livedata dot pl
     * @date    2011-04-22 06:08 UTC
     * @link    http://www.php.net/manual/en/ref.simplexml.php#103617
     * @license http://www.php.net/license/index.php#doc-lic
     * @license http://creativecommons.org/licenses/by/3.0/
     * @license CC-BY-3.0 <http://spdx.org/licenses/CC-BY-3.0>
     */
    protected function xml2array($xmlObject, array $out = []) : array
    {
        foreach ((array)$xmlObject as $index => $node) {
            $out[$index] = (is_object($node) || is_array($node)) ? $this->xml2array($node) : $node;
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }

        return $out;
    }
}


1		<?php declare(strict_types = 1);
2		/**
3		* Created by Vitaly Iegorov <[email protected]>.
4		* on 20.08.16 at 12:39
5		*/
6		namespace samsonframework\container;
7
8		use samsonframework\container\collection\CollectionClassResolver;
9
10		/**
11		* XML class metadata collector.
12		* Class resolves and collects class metadata from XML string.
13		*
14		* @author Vitaly Egorov <[email protected]>
15		*/
16		class XmlMetadataCollector extends AbstractMetadataCollector
17		{
18		/**
19		* {@inheritdoc}
20		*/
21	2	public function collect($xmlConfig) : array
22		{
23	2	$classesMetadata = [];
24
25		// Iterate config and resolve single instance
26	2	foreach ($this->xml2array(new \SimpleXMLElement($xmlConfig)) as $key => $classesArrayData) {
27	2	if ($key === CollectionClassResolver::KEY) {
28		/** @var array $classesArrayData */
29	2	foreach ($classesArrayData as $classArrayData) {
30	2	$classesMetadata[] = $this->resolver->resolve($classArrayData);
		0 ignored issues – show Bug introduced 2016-08-20 10:29 UTC by Report Bug Copy Issue Report The property `resolver` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31		}
32		}
33		}
34
35	2	return $classesMetadata;
36		}
37
38		/**
39		* function xml2array
40		*
41		* This function is part of the PHP manual.
42		*
43		* The PHP manual text and comments are covered by the Creative Commons
44		* Attribution 3.0 License, copyright (c) the PHP Documentation Group
45		*
46		* @param \SimpleXMLElement\|array $xmlObject
47		* @param array $out
48		*
49		* @return array XML converted array
50		*
51		* @author k dot antczak at livedata dot pl
52		* @date 2011-04-22 06:08 UTC
53		* @link http://www.php.net/manual/en/ref.simplexml.php#103617
54		* @license http://www.php.net/license/index.php#doc-lic
55		* @license http://creativecommons.org/licenses/by/3.0/
56		* @license CC-BY-3.0 <http://spdx.org/licenses/CC-BY-3.0>
57		*/
58	2	protected function xml2array($xmlObject, array $out = []) : array
59		{
60	2	foreach ((array)$xmlObject as $index => $node) {
61	2	$out[$index] = (is_object($node) \|\| is_array($node)) ? $this->xml2array($node) : $node;
		0 ignored issues – show Bug introduced 2016-08-20 10:29 UTC by Report Bug Copy Issue Report It seems like `$node` can also be of type `object`; however, `samsonframework\containe...aCollector::xml2array()` does only seem to accept `object<SimpleXMLElement>\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
62		}
63
64	2	return $out;
65		}
66		}
67

samsonframework / container

Push — master ( 01582c...42d944 )

XmlMetadataCollector::xml2array() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like