samsonframework /
container
| Conditions | 12 |
| Paths | 41 |
| Total Lines | 50 |
| Code Lines | 29 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 21 |
| CRAP Score | 12.0948 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php declare(strict_types = 1); |
||
| 33 | 6 | public function analyze( |
|
| 34 | DefinitionAnalyzer $analyzer, |
||
| 35 | \ReflectionParameter $reflectionParameter, |
||
| 36 | ClassDefinition $classDefinition, |
||
| 37 | MethodDefinition $methodDefinition = null, |
||
| 38 | ParameterDefinition $parameterDefinition = null |
||
| 39 | ) { |
||
| 40 | // Define parameter only if method definition is available |
||
| 41 | 6 | if ($methodDefinition) { |
|
| 42 | // Define parameter definition if not exists |
||
| 43 | 6 | if (!$parameterDefinition) { |
|
| 44 | 2 | $parameterDefinition = $methodDefinition->defineParameter($reflectionParameter->getName()); |
|
|
Bug
introduced
by
|
|||
| 45 | } |
||
| 46 | // Set parameter metadata |
||
| 47 | 6 | if ($reflectionParameter->isDefaultValueAvailable()) { |
|
| 48 | 3 | $parameterDefinition->setValue($reflectionParameter->getDefaultValue()); |
|
| 49 | } |
||
| 50 | 6 | if ($reflectionParameter->getType()) { |
|
| 51 | 6 | $parameterDefinition->setTypeHint($reflectionParameter->getType()); |
|
| 52 | } |
||
| 53 | 6 | $parameterDefinition->setIsOptional($reflectionParameter->isOptional()); |
|
| 54 | |||
| 55 | 6 | $dependency = $parameterDefinition->getDependency(); |
|
| 56 | // If dependency was not set |
||
| 57 | 6 | if (!$dependency || ($dependency instanceof UndefinedReference)) { |
|
| 58 | // If default value available |
||
| 59 | 3 | if ($reflectionParameter->isDefaultValueAvailable()) { |
|
| 60 | // There is a constant |
||
| 61 | 3 | if ($reflectionParameter->isDefaultValueConstant()) { |
|
| 62 | $parameterDefinition->setDependency( |
||
| 63 | new ConstantReference($reflectionParameter->getDefaultValueConstantName()) |
||
| 64 | ); |
||
| 65 | } else { // There is some php types |
||
| 66 | 3 | $parameterDefinition->setDependency( |
|
| 67 | 3 | CollectionReference::convertValueToReference($reflectionParameter->getDefaultValue()) |
|
| 68 | ); |
||
| 69 | } |
||
| 70 | // There is class dependency |
||
| 71 | } elseif ( |
||
| 72 | 2 | is_object($parameterDefinition->getTypeHint()) && |
|
| 73 | 2 | (string)$parameterDefinition->getTypeHint() !== '' && |
|
| 74 | 2 | !$parameterDefinition->getTypeHint()->isBuiltin() |
|
| 75 | ) { |
||
| 76 | 2 | $parameterDefinition->setDependency( |
|
| 77 | 2 | new ClassReference((string)$parameterDefinition->getTypeHint()) |
|
| 78 | ); |
||
| 79 | } |
||
| 80 | } |
||
| 81 | } |
||
| 82 | 6 | } |
|
| 83 | } |
||
| 84 |
Loading history...