ParameterBuilder - Code Metrics - Inspection of "Fixed bugs" - samsonframework/container - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d10f54...00ced4 )

unknown

created 2016-09-14 08:10 UTC

ParameterBuilder A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	114
Duplicated Lines	28.07 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	12
lcom	1
cbo	3
dl	32
loc	114
rs	10
c	0
b	0
f	0
ccs	28
cts	28
cp	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	defineParameter()	0	4	1
A	changeParameter()	9	9	2
A	add()	9	9	2
A	has()	0	4	1
A	remove()	7	7	2
A	get()	7	7	2
A	getParameterCollection()	0	4	1
A	setParentDefinition()	0	4	1

How to fix Duplicated Code

<?php

/**
 * Created by Ruslan Molodyko.
 * Date: 11.09.2016
 * Time: 14:47
 */
namespace samsonframework\container\definition\parameter;

use samsonframework\container\definition\AbstractDefinition;
use samsonframework\container\definition\parameter\exception\ParameterAlreadyExistsException;
use samsonframework\container\definition\parameter\exception\ParameterNotFoundException;
use samsonframework\container\definition\reference\ReferenceInterface;

/**
 * Class ParameterBuilder
 *
 * @author Ruslan Molodyko <[email protected]>
 */
class ParameterBuilder extends AbstractDefinition implements ParameterBuilderInterface
{
    /** @var array */
    protected $parameterCollection = [];

    /**
     * Define parameter
     *
     * @param string $name
     * @param ReferenceInterface $reference
     * @return ParameterBuilderInterface
     * @throws ParameterAlreadyExistsException
     */
    public function defineParameter(string $name, ReferenceInterface $reference): ParameterBuilderInterface
    {
        return $this->add($name, $reference);
    }

    /**
     * Change parameter
     *
     * @param string $name
     * @param ReferenceInterface $reference
     * @return ParameterBuilder
     * @throws ParameterNotFoundException
     */
    public function changeParameter(string $name, ReferenceInterface $reference): ParameterBuilder

    {
        if (!$this->has($name)) {
            throw new ParameterNotFoundException(sprintf('Parameter with name "%s" not found', $name));
        }
        $this->parameterCollection[$name] = $reference;

        return $this;
    }

    /**
     * Add parameter to collection
     *
     * @param string $name
     * @param ReferenceInterface $reference
     * @return ParameterBuilder
     * @throws ParameterAlreadyExistsException
     */
    public function add(string $name, ReferenceInterface $reference): ParameterBuilder

    {
        if ($this->has($name)) {
            throw new ParameterAlreadyExistsException(sprintf('Parameter with name "%s" already defined', $name));
        }
        $this->parameterCollection[$name] = $reference;

        return $this;
    }

    /**
     * Has parameter in collection
     *
     * @param string $name
     * @return bool
     */
    public function has(string $name): bool
    {
        return array_key_exists($name, $this->parameterCollection);
    }

    /**
     * Remove parameter
     *
     * @param string $name
     * @throws ParameterNotFoundException
     */
    public function remove(string $name)

    {
        if (!$this->has($name)) {
            throw new ParameterNotFoundException(sprintf('Parameter with name "%s" not found', $name));
        }
        unset($this->parameterCollection[$name]);
    }

    /**
     * Get parameter
     *
     * @param string $name
     * @return ReferenceInterface
     * @throws ParameterNotFoundException
     */
    public function get(string $name): ReferenceInterface

    {
        if (!$this->has($name)) {
            throw new ParameterNotFoundException(sprintf('Parameter with name "%s" not found', $name));
        }
        return $this->parameterCollection[$name];
    }

    /**
     * Get parameter collection
     *
     * @return ReferenceInterface[]
     */
    public function getParameterCollection(): array
    {
        return $this->parameterCollection;
    }

    /**
     * Set parent definition
     *
     * @param AbstractDefinition $definition
     */
    public function setParentDefinition(AbstractDefinition $definition)
    {
        $this->parentDefinition = $definition;
    }
}


1			<?php
			0 ignored issues – show Coding Style introduced 2016-09-14 08:15 UTC by Report Bug Copy Issue Report End of line character is invalid; expected "\n" but found "\r\n" Loading history...
2			/**
3			* Created by Ruslan Molodyko.
4			* Date: 11.09.2016
5			* Time: 14:47
6			*/
7			namespace samsonframework\container\definition\parameter;
8
9			use samsonframework\container\definition\AbstractDefinition;
10			use samsonframework\container\definition\parameter\exception\ParameterAlreadyExistsException;
11			use samsonframework\container\definition\parameter\exception\ParameterNotFoundException;
12			use samsonframework\container\definition\reference\ReferenceInterface;
13
14			/**
15			* Class ParameterBuilder
16			*
17			* @author Ruslan Molodyko <[email protected]>
18			*/
19			class ParameterBuilder extends AbstractDefinition implements ParameterBuilderInterface
20			{
21			/** @var array */
22			protected $parameterCollection = [];
23
24			/**
25			* Define parameter
26			*
27			* @param string $name
28			* @param ReferenceInterface $reference
29			* @return ParameterBuilderInterface
30			* @throws ParameterAlreadyExistsException
31			*/
32	13		public function defineParameter(string $name, ReferenceInterface $reference): ParameterBuilderInterface
33			{
34	13		return $this->add($name, $reference);
35			}
36
37			/**
38			* Change parameter
39			*
40			* @param string $name
41			* @param ReferenceInterface $reference
42			* @return ParameterBuilder
43			* @throws ParameterNotFoundException
44			*/
45	2	View Code Duplication	public function changeParameter(string $name, ReferenceInterface $reference): ParameterBuilder
			0 ignored issues – show Duplication introduced 2016-09-14 08:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46			{
47	2		if (!$this->has($name)) {
48	1		throw new ParameterNotFoundException(sprintf('Parameter with name "%s" not found', $name));
49			}
50	1		$this->parameterCollection[$name] = $reference;
51
52	1		return $this;
53			}
54
55			/**
56			* Add parameter to collection
57			*
58			* @param string $name
59			* @param ReferenceInterface $reference
60			* @return ParameterBuilder
61			* @throws ParameterAlreadyExistsException
62			*/
63	15	View Code Duplication	public function add(string $name, ReferenceInterface $reference): ParameterBuilder
			0 ignored issues – show Duplication introduced 2016-09-14 08:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64			{
65	15		if ($this->has($name)) {
66	2		throw new ParameterAlreadyExistsException(sprintf('Parameter with name "%s" already defined', $name));
67			}
68	15		$this->parameterCollection[$name] = $reference;
69
70	15		return $this;
71			}
72
73			/**
74			* Has parameter in collection
75			*
76			* @param string $name
77			* @return bool
78			*/
79	15		public function has(string $name): bool
80			{
81	15		return array_key_exists($name, $this->parameterCollection);
82			}
83
84			/**
85			* Remove parameter
86			*
87			* @param string $name
88			* @throws ParameterNotFoundException
89			*/
90	2	View Code Duplication	public function remove(string $name)
			0 ignored issues – show Duplication introduced 2016-09-14 08:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91			{
92	2		if (!$this->has($name)) {
93	1		throw new ParameterNotFoundException(sprintf('Parameter with name "%s" not found', $name));
94			}
95	2		unset($this->parameterCollection[$name]);
96	2		}
97
98			/**
99			* Get parameter
100			*
101			* @param string $name
102			* @return ReferenceInterface
103			* @throws ParameterNotFoundException
104			*/
105	5	View Code Duplication	public function get(string $name): ReferenceInterface
			0 ignored issues – show Duplication introduced 2016-09-14 08:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106			{
107	5		if (!$this->has($name)) {
108	1		throw new ParameterNotFoundException(sprintf('Parameter with name "%s" not found', $name));
109			}
110	4		return $this->parameterCollection[$name];
111			}
112
113			/**
114			* Get parameter collection
115			*
116			* @return ReferenceInterface[]
117			*/
118	9		public function getParameterCollection(): array
119			{
120	9		return $this->parameterCollection;
121			}
122
123			/**
124			* Set parent definition
125			*
126			* @param AbstractDefinition $definition
127			*/
128	18		public function setParentDefinition(AbstractDefinition $definition)
129			{
130	18		$this->parentDefinition = $definition;
131	18		}
132			}
133

samsonframework / container

Push — master ( d10f54...00ced4 )

ParameterBuilder A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like