AnnotationResolver::resolve() - Code Metrics - Inspection of "Refactored Scope and Alias annotation as they foll..." - samsonframework/container - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6bfcaa...57efb7 )

by Vitaly

created 2016-08-06 10:48 UTC

AnnotationResolver::resolve() C

↳ Parent: AnnotationResolver

Complexity

Conditions	11
Paths	15

Size

Total Lines	52
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	23.111

Importance

Changes	5
Bugs	0	Features	5

Metric	Value
c	5
b	0
f	5
dl	0
loc	52
ccs	15
cts	28
cp	0.5356
rs	5.9999
cc	11
eloc	29
nc	15
nop	2
crap	23.111

How to fix Long Method Complexity

<?php
/**
 * Created by PhpStorm.
 * User: root
 * Date: 29.07.2016
 * Time: 21:38.
 */
namespace samsonframework\container\resolver;

use Doctrine\Common\Annotations\Annotation;
use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\Common\Annotations\CachedReader;
use Doctrine\Common\Cache\FilesystemCache;
use samsonframework\container\annotation\Alias;
use samsonframework\container\annotation\AutoWire;
use samsonframework\container\annotation\Controller;
use samsonframework\container\annotation\Inject;
use samsonframework\container\annotation\MetadataInterface;
use samsonframework\container\annotation\MethodAnnotation;
use samsonframework\container\annotation\Scope;
use samsonframework\container\annotation\Service;
use samsonframework\container\metadata\ClassMetadata;
use samsonframework\container\metadata\MethodMetadata;
use samsonframework\container\scope\ControllerScope;

class AnnotationResolver extends Resolver
{
    /**
     * @var CachedReader
     */
    protected $reader;

    /**
     * AnnotationResolver constructor.
     *
     * @param string $cachePath Path for storing annotation cache
     *
     * @throws \InvalidArgumentException
     */
    public function __construct($cachePath)
    {
        $this->reader = new CachedReader(new AnnotationReader(), new FilesystemCache($cachePath));
    }

    /**
     * {@inheritDoc}
     */
    public function resolve($classData, $identifier = null)
    {
        /** @var \ReflectionClass $classData */

        /** @var MetadataInterface[] $classAnnotations Read class annotations */
        $classAnnotations = $this->reader->getClassAnnotations($classData);

        if ($classAnnotations) {

            $metadata = new ClassMetadata();
            $metadata->className = $classData->getName();
            $metadata->internalId = $identifier ?: uniqid('container', true);

            foreach ($classAnnotations as $annotation) {
                if (class_implements($annotation, MetadataInterface::class)) {
                    $annotation->toMetadata($metadata, $classData->getName());

                }

                if ($annotation instanceof Inject) {
                    $argumentList = $annotation->list['value'];
                    foreach ($argumentList as $name => $serviceName) {
                        $arg = ['service' => $serviceName];
                        if (is_string($name)) {
                            $metadata->args[$name] = $arg;
                        } else {
                            $metadata->args[] = $arg;
                        }
                    }
                }
            }

            if (!$metadata->name) {
                $metadata->name = $metadata->internalId;
            }
        }

        /** @var \ReflectionMethod $method */
        foreach ($classData->getMethods() as $method) {
            $methodAnnotations = $this->reader->getMethodAnnotations($method);
            $methodMetadata = new MethodMetadata();
            $methodMetadata->name = $method->getName();
            $methodMetadata->modifiers = $method->getModifiers();
            $methodMetadata->parameters = $method->getParameters();

            /** @var MethodAnnotation $methodAnnotation */
            foreach ($methodAnnotations as $methodAnnotation) {
                $methodMetadata->options[$methodAnnotation->getMethodAlias()] = $methodAnnotation->convertToMetadata();
            }
            $metadata->methodsMetadata[$method->getName()] = $methodMetadata;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        return $metadata;
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: root
5		* Date: 29.07.2016
6		* Time: 21:38.
7		*/
8		namespace samsonframework\container\resolver;
9
10		use Doctrine\Common\Annotations\Annotation;
11		use Doctrine\Common\Annotations\AnnotationReader;
12		use Doctrine\Common\Annotations\CachedReader;
13		use Doctrine\Common\Cache\FilesystemCache;
14		use samsonframework\container\annotation\Alias;
15		use samsonframework\container\annotation\AutoWire;
16		use samsonframework\container\annotation\Controller;
17		use samsonframework\container\annotation\Inject;
18		use samsonframework\container\annotation\MetadataInterface;
19		use samsonframework\container\annotation\MethodAnnotation;
20		use samsonframework\container\annotation\Scope;
21		use samsonframework\container\annotation\Service;
22		use samsonframework\container\metadata\ClassMetadata;
23		use samsonframework\container\metadata\MethodMetadata;
24		use samsonframework\container\scope\ControllerScope;
25
26		class AnnotationResolver extends Resolver
27		{
28		/**
29		* @var CachedReader
30		*/
31		protected $reader;
32
33		/**
34		* AnnotationResolver constructor.
35		*
36		* @param string $cachePath Path for storing annotation cache
37		*
38		* @throws \InvalidArgumentException
39		*/
40	1	public function __construct($cachePath)
41		{
42	1	$this->reader = new CachedReader(new AnnotationReader(), new FilesystemCache($cachePath));
43	1	}
44
45		/**
46		* {@inheritDoc}
47		*/
48	1	public function resolve($classData, $identifier = null)
49		{
50		/** @var \ReflectionClass $classData */
51
52		/** @var MetadataInterface[] $classAnnotations Read class annotations */
53	1	$classAnnotations = $this->reader->getClassAnnotations($classData);
54
55	1	if ($classAnnotations) {
		0 ignored issues – show Bug Best Practice introduced 2016-08-06 10:25 UTC by Report Bug Copy Issue Report The expression `$classAnnotations` of type `samsonframework\containe...ion\MetadataInterface[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
56	1	$metadata = new ClassMetadata();
57	1	$metadata->className = $classData->getName();
58	1	$metadata->internalId = $identifier ?: uniqid('container', true);
59
60	1	foreach ($classAnnotations as $annotation) {
61	1	if (class_implements($annotation, MetadataInterface::class)) {
62	1	$annotation->toMetadata($metadata, $classData->getName());
		0 ignored issues – show Unused Code introduced 2016-08-06 10:51 UTC by Report Bug Copy Issue Report The call to `MetadataInterface::toMetadata()` has too many arguments starting with `$classData->getName()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
63		}
64
65	1	if ($annotation instanceof Inject) {
66		$argumentList = $annotation->list['value'];
67		foreach ($argumentList as $name => $serviceName) {
68		$arg = ['service' => $serviceName];
69		if (is_string($name)) {
70		$metadata->args[$name] = $arg;
71		} else {
72	1	$metadata->args[] = $arg;
73		}
74		}
75		}
76		}
77
78	1	if (!$metadata->name) {
79	1	$metadata->name = $metadata->internalId;
80		}
81		}
82
83		/** @var \ReflectionMethod $method */
84	1	foreach ($classData->getMethods() as $method) {
85		$methodAnnotations = $this->reader->getMethodAnnotations($method);
86		$methodMetadata = new MethodMetadata();
87		$methodMetadata->name = $method->getName();
88		$methodMetadata->modifiers = $method->getModifiers();
89		$methodMetadata->parameters = $method->getParameters();
90
91		/** @var MethodAnnotation $methodAnnotation */
92		foreach ($methodAnnotations as $methodAnnotation) {
93		$methodMetadata->options[$methodAnnotation->getMethodAlias()] = $methodAnnotation->convertToMetadata();
94		}
95		$metadata->methodsMetadata[$method->getName()] = $methodMetadata;
		0 ignored issues – show Bug introduced 2016-08-06 10:25 UTC by Report Bug Copy Issue Report The variable `$metadata` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
96		}
97
98	1	return $metadata;
99		}
100		}
101

samsonframework / container

Push — master ( 6bfcaa...57efb7 )

AnnotationResolver::resolve() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like