samsonframework\container\annotation\CollectionValue

Complexity

Total Complexity

6

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	13	6

<?php
/**
 * Created by Vitaly Iegorov <egorov@samsonos.com>.
 * on 06.08.16 at 13:44
 */
namespace samsonframework\container\annotation;

/**
 * Generic collection value annotation.
 *
 * @package samsonframework\container\annotation
 */
class CollectionValue
{
    /** @var array Collection of class collection */
    public $collection = [];

    /**
     * Scope constructor.
     *
     * @param array $scopeOrScopes Class collection
     *
     * @throws \Exception Thrown when neither string nor string[] is passed
     */
    public function __construct($scopeOrScopes)
    {
        if (is_array($scopeOrScopes) && array_key_exists('value', $scopeOrScopes)) {
            $value = $scopeOrScopes['value'];

            if (!is_array($value) && !is_string($value)) {
                throw new \InvalidArgumentException('Only string or array is allowed');
            }

            // Always store array
            $this->collection = is_array($value) ?: [$value];

It seems like is_array($value) ?: array($value) can also be of type boolean. However, the property $collection is declared as type array. Maybe add an additional type check?

        }
    }
}