AnnotationMethodResolver::resolveMethodAnnotations() - Code Metrics - Inspection of "Finished AnnotationMethodResolver logic and test" - samsonframework/container - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6f1a19...e34473 )

by Vitaly

created 2016-08-07 13:16 UTC

resolveMethodAnnotations() B

↳ Parent: AnnotationMethodResolver

Complexity

Conditions	5
Paths	10

Size

Total Lines	28
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	0
loc	28
ccs	0
cts	9
cp	0
rs	8.439
cc	5
eloc	16
nc	10
nop	2
crap	30

<?php
/**
 * Created by Vitaly Iegorov <[email protected]>.
 * on 07.08.16 at 13:04
 */
namespace samsonframework\container\resolver;

use samsonframework\container\annotation\MethodInterface;
use samsonframework\container\annotation\ParameterInterface;
use samsonframework\container\metadata\ClassMetadata;
use samsonframework\container\metadata\MethodMetadata;
use samsonframework\container\metadata\ParameterMetadata;

/**
 * Class method annotation resolver.
 */
class AnnotationMethodResolver extends AbstractAnnotationResolver implements AnnotationResolverInterface
{
    /**
     * {@inheritDoc}
     */
    public function resolve(\ReflectionClass $classData, ClassMetadata $classMetadata)
    {
        /** @var \ReflectionMethod $method */
        foreach ($classData->getMethods() as $method) {
            $this->resolveMethodAnnotations($method, $classMetadata);
        }

        return $this->classMetadata;
    }

    /**
     * Resolve class method annotations.
     *
     * @param \ReflectionMethod $method
     * @param ClassMetadata     $classMetadata
     */
    protected function resolveMethodAnnotations(\ReflectionMethod $method, ClassMetadata $classMetadata)
    {
        // Create method metadata instance
        $methodMetadata = new MethodMetadata($classMetadata);
        $methodMetadata->name = $method->getName();

        $methodMetadata->modifiers = $method->getModifiers();

        /** @var \ReflectionParameter $parameter */
        $parameterMetadata = new ParameterMetadata($classMetadata, $methodMetadata);
        foreach ($method->getParameters() as $parameter) {
            $parameterMetadata = clone $parameterMetadata;
            $parameterMetadata->name = $parameter->getName();

            $parameterMetadata->typeHint = $parameter->getType()->__toString();
            $methodMetadata->parametersMetadata[$parameterMetadata->name] = $parameterMetadata;
        }

        /** @var MethodInterface|ParameterInterface $annotation */
        foreach ($this->reader->getMethodAnnotations($method) as $annotation) {
            if ($annotation instanceof MethodInterface) {
                $annotation->toMethodMetadata($methodMetadata);
            }
            if ($annotation instanceof ParameterInterface) {
                $annotation->toParameterMetadata(new ParameterMetadata($methodMetadata));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        }

        $classMetadata->methodsMetadata[$method->getName()] = $methodMetadata;

    }
}


1			<?php
2			/**
3			* Created by Vitaly Iegorov <[email protected]>.
4			* on 07.08.16 at 13:04
5			*/
6			namespace samsonframework\container\resolver;
7
8			use samsonframework\container\annotation\MethodInterface;
9			use samsonframework\container\annotation\ParameterInterface;
10			use samsonframework\container\metadata\ClassMetadata;
11			use samsonframework\container\metadata\MethodMetadata;
12			use samsonframework\container\metadata\ParameterMetadata;
13
14			/**
15			* Class method annotation resolver.
16			*/
17			class AnnotationMethodResolver extends AbstractAnnotationResolver implements AnnotationResolverInterface
18			{
19			/**
20			* {@inheritDoc}
21			*/
22			public function resolve(\ReflectionClass $classData, ClassMetadata $classMetadata)
23			{
24			/** @var \ReflectionMethod $method */
25			foreach ($classData->getMethods() as $method) {
26			$this->resolveMethodAnnotations($method, $classMetadata);
27			}
28
29			return $this->classMetadata;
30			}
31
32			/**
33			* Resolve class method annotations.
34			*
35			* @param \ReflectionMethod $method
36			* @param ClassMetadata $classMetadata
37			*/
38			protected function resolveMethodAnnotations(\ReflectionMethod $method, ClassMetadata $classMetadata)
39			{
40			// Create method metadata instance
41			$methodMetadata = new MethodMetadata($classMetadata);
42			$methodMetadata->name = $method->getName();
			0 ignored issues – show Bug introduced 2016-08-07 10:50 UTC by Report Bug Copy Issue Report Consider using `$method->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
43			$methodMetadata->modifiers = $method->getModifiers();
44
45			/** @var \ReflectionParameter $parameter */
46			$parameterMetadata = new ParameterMetadata($classMetadata, $methodMetadata);
47			foreach ($method->getParameters() as $parameter) {
48			$parameterMetadata = clone $parameterMetadata;
49			$parameterMetadata->name = $parameter->getName();
			0 ignored issues – show Bug introduced 2016-08-07 13:18 UTC by Report Bug Copy Issue Report Consider using `$parameter->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
50			$parameterMetadata->typeHint = $parameter->getType()->__toString();
51			$methodMetadata->parametersMetadata[$parameterMetadata->name] = $parameterMetadata;
52			}
53
54			/** @var MethodInterface\|ParameterInterface $annotation */
55			foreach ($this->reader->getMethodAnnotations($method) as $annotation) {
56			if ($annotation instanceof MethodInterface) {
57			$annotation->toMethodMetadata($methodMetadata);
58			}
59			if ($annotation instanceof ParameterInterface) {
60			$annotation->toParameterMetadata(new ParameterMetadata($methodMetadata));
			0 ignored issues – show Bug introduced 2016-08-07 13:18 UTC by Report Bug Copy Issue Report The call to `ParameterMetadata::__construct()` misses a required argument `$methodMetadata`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2016-08-07 13:18 UTC by Report Bug Copy Issue Report `$methodMetadata` is of type `object<samsonframework\c...etadata\MethodMetadata>`, but the function expects a `object<samsonframework\c...metadata\ClassMetadata>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			}
62			}
63
64			$classMetadata->methodsMetadata[$method->getName()] = $methodMetadata;
			0 ignored issues – show Bug introduced 2016-08-07 10:50 UTC by Report Bug Copy Issue Report Consider using `$method->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
65			}
66			}
67

samsonframework / container

Push — master ( 6f1a19...e34473 )

resolveMethodAnnotations() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like