FormGroup::render() - Code Metrics - Inspection of "Merge pull request #25 from anazarenko/master" - samsoncms/user - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a27e56...4f6d20 )

by Vitaly

created 2016-02-18 12:16 UTC

FormGroup::render() A

↳ Parent: FormGroup

Complexity

Conditions	2
Paths	2

Size

Total Lines	22
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	22
rs	9.2
cc	2
eloc	16
nc	2
nop	3

<?php
namespace samsoncms\app\user\field;

use samsonframework\core\RenderInterface;
use samsonframework\orm\QueryInterface;
use samsoncms\form\field\Generic;

/**
 * Overridden group field
 * @package samsoncms\app\user
 */
class FormGroup extends Generic
{
    /** @inheritdoc */
    public function render(RenderInterface $renderer, QueryInterface $query, $object)
    {
        // Get all available groups from db
        $groupSelect = array();
        foreach ($query->className('group')->cond('Active', 1)->exec() as $group) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $groupSelect[] = $group->GroupID.':'.$group->Name;
        }

        // Set view
        return $renderer->view($this->innerView)
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->set($this->css, 'class')
            ->set($object, 'item')
            ->set(
                m('samsoncms_input_application')->createFieldByType(

                    $query,
                    4,
                    $object,
                    $this->name
                )->build(implode(',', $groupSelect)),
                'field'
            )->output();
    }
}

Push — master ( a27e56...4f6d20 )

FormGroup::render() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			namespace samsoncms\app\user\field;
3
4			use samsonframework\core\RenderInterface;
5			use samsonframework\orm\QueryInterface;
6			use samsoncms\form\field\Generic;
7
8			/**
9			* Overridden group field
10			* @package samsoncms\app\user
11			*/
12			class FormGroup extends Generic
13			{
14			/** @inheritdoc */
15			public function render(RenderInterface $renderer, QueryInterface $query, $object)
16			{
17			// Get all available groups from db
18			$groupSelect = array();
19			foreach ($query->className('group')->cond('Active', 1)->exec() as $group) {
			0 ignored issues – show Bug introduced 2016-01-27 14:38 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `samsonframework\orm\QueryInterface` as the method `className()` does only exist in the following implementations of said interface: `samson\activerecord\dbQuery`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
20			$groupSelect[] = $group->GroupID.':'.$group->Name;
21			}
22
23			// Set view
24			return $renderer->view($this->innerView)
			0 ignored issues – show Bug introduced 2016-01-27 14:38 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `samsonframework\core\RenderInterface` as the method `view()` does only exist in the following implementations of said interface: `samson\activerecord\Module`, `samson\core\CompressableExternalModule`, `samson\core\CompressableLocalModule`, `samson\core\CompressableService`, `samson\core\ExternalModule`, `samson\core\LocalModule`, `samson\core\Module`, `samson\core\Service`, `samson\core\System`, `samson\core\VirtualModule`, `samson\js\core\SamsonJSConnector`, `samson\js\lightbox\LightBox`, `samson\js\md5\SJSMD5Connector`, `samson\js\select\Select`, `samson\js\tinybox\TinyBox`, `samson\less\SamsonLessConnector`, `samson\parse\Parse`, `samson\resourcer\ResourceRouter`, `samson\scale\ScaleController`, `samson\social\Core`, `samson\social\email\Email`, `samsoncms\Application`, `samsoncms\api\CMS`, `samsoncms\app\user\Application`, `samsoncms\input\Application`, `samsoncms\template\Template`, `samsonphp\compressor\Controller`, `samsonphp\deploy\Deploy`, `samsonphp\fs\FileService`, `samsonphp\i18n\i18n`, `samsonphp\tests\TestingModule`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
25			->set($this->css, 'class')
26			->set($object, 'item')
27			->set(
28			m('samsoncms_input_application')->createFieldByType(
			0 ignored issues – show Deprecated Code introduced 2016-01-27 14:38 UTC by Report Bug Copy Issue Report The function `m()` has been deprecated with message: Use $this->system->module() in module context This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
29			$query,
30			4,
31			$object,
32			$this->name
33			)->build(implode(',', $groupSelect)),
34			'field'
35			)->output();
36			}
37			}

samsoncms / user

Push — master ( a27e56...4f6d20 )

FormGroup::render() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like