Issues (13)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Application.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * Created by PhpStorm.
4
 * User: nazarenko
5
 * Date: 20.10.2014
6
 * Time: 11:43
7
 */
8
namespace samsoncms\app\signin;
9
10
use samson\activerecord\dbQuery;
11
use samson\cms\CMS;
12
use samson\social\email\EmailStatus;
13
use samson\url\URL;
14
use samsoncms\api\generated\UserQuery;
15
use samsonframework\container\definition\analyzer\annotation\annotation\InjectService;
16
use samsonframework\containerannotation\InjectArgument;
17
use samsonframework\core\RequestInterface;
18
use samsonframework\core\ResourcesInterface;
19
use samsonframework\core\SystemInterface;
20
use samsonphp\event\Event;
21
use samsonframework\orm\QueryInterface;
22
use samson\social\email\Email;
23
use samson\core\Core;
24
use samsonphp\compressor\Compressor;
25
26
/**
27
 * Generic class for user sign in
28
 * @author Olexandr Nazarenko <[email protected]>
29
 * @copyright 2014 SamsonOS
30
 */
31
class Application extends \samson\core\CompressableExternalModule
32
{
33
    /** @var string Identifier */
34
    public $id = 'signin';
35
36
    /** @var Email Pointer to social email module */
37
    protected $social;
38
39
    /** @var QueryInterface Database query instance */
40
    protected $query;
41
42
    /** @var RequestInterface Request instance */
43
    protected $request;
44
45
    public function authorize($cms)
46
    {
47
        if ($cms->isCMS()) {
48
            if (!$this->social->authorized()) {
49
                if (!$this->social->cookieVerification()) {
50
                    if (!$this->request->is('signin')) {
51
                        $this->request->redirect('/' . $cms->baseUrl . '/signin');
52
                    }
53
                } else {
54
                    $this->request->redirect('/' . $cms->baseUrl . '/signin');
55
                }
56
            } else {
57
                if ($this->request->is('signin')) {
58
                    $this->request->redirect('/' . $cms->baseUrl);
59
                }
60
            }
61
        }
62
    }
63
64
    /**
65
     * @InjectService(core="core")
66
     */
67
    public function test($core)
68
    {
69
70
    }
71
72
    public function init(array $params = array())
73
    {
74
        $this->request = url();
75
        // Old applications main page rendering
76
        Event::subscribe(\samsoncms\cms\Application::EVENT_IS_CMS, array($this, 'authorize'));
77
        
78
        Event::subscribe(Compressor::E_CREATE_MODULE_LIST, array($this, 'getModuleList'));
79
80
        // Call parent initialization
81
        return parent::init($params);
82
    }
83
    
84
    public function getModuleList(& $moduleListArray)
85
    {
86
        $moduleList = array();
87
        foreach ($this->system->module_stack as $id => $module) {
0 ignored issues
show
Accessing module_stack on the interface samsonframework\core\SystemInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
88
            if (isset($module->composerParameters['composerName'])) {
89
                if (in_array($module->composerParameters['composerName'], $this->composerParameters['required'])) {
90
                    $moduleList[$id] = $module;
91
                }
92
            }
93
        }
94
        $moduleList[$this->id] = $this;
95
        $moduleListArray[$this->path().'www/signin/signin_template.vphp'] = $moduleList;
96
    }
97
98
    /**
99
     * Application constructor.
100
     *
101
     * @param string $path
102
     * @param ResourcesInterface $resources
103
     * @param SystemInterface $system
104
     *
105
     * @ InjectArgument(socialEmail="samson\social\email\Email")
106
     * @ InjectArgument(request="samson\url\URL")
107
     * @ InjectArgument(queryInterface="samsonframework\orm\QueryInterface")
108
     *
109
     * @ InjectArgument(resources="samsonframework\core\ResourcesInterface")
110
     * @ InjectArgument(system="samsonframework\core\SystemInterface")
111
     */
112
    public function __construct($path, Email $socialEmail, URL $request, QueryInterface $queryInterface, ResourcesInterface $resources, SystemInterface $system)
113
    {
114
        parent::__construct(realpath(__DIR__ . '/../'), $resources, $system);
115
116
        // Inject dependencies
117
//        $this->social = $this->system->module('socialemail');
118
//        $this->request = $this->system->module('samsonos_php_url');
119
//        $this->query = new dbQuery();
120
        $this->social = $socialEmail;
121
        $this->request = $request;
122
        $this->query = $queryInterface;
123
    }
124
125
    //[PHPCOMPRESSOR(remove,start)]
126
    /** Module preparation */
127
    public function prepare()
128
    {
129
        // Create default user for first logins
130
        $adminUser = '[email protected]';
131
        $hashedEmailValue = $this->social->hash($adminUser);
132
133
        /** @var \samsoncms\api\generated\User $admin Try to find generic user */
134
        $admin = $this->query
135
            ->entity($this->social->dbTable)
136
            ->where($this->social->dbEmailField, $adminUser)
137
            ->first();
138
139
        // Create user record if missing
140
        if (!isset($admin)) {
141
            $admin = new $this->social->dbTable($this->system->getContainer()->get('database'));
142
        }
143
144
        // Fill in user credentials according to config
145
        $admin[$this->social->dbEmailField] = $adminUser;
146
        $admin[$this->social->dbHashEmailField] = $hashedEmailValue;
147
        $admin[$this->social->dbHashPasswordField] = $hashedEmailValue;
148
        $admin->fName = 'admin';
149
        $admin->sName = '';
150
        $admin->tName = '';
151
        $admin->groupId = 1;
152
        $admin->system = 1;
153
        $admin->created = date('Y-m-d H:i:s');
154
        $admin->active = 1;
155
        $admin->save();
156
    }
157
    //[PHPCOMPRESSOR(remove,end)]
158
159
    /** Check the user's authorization */
160
    public function __HANDLER()
161
    {
162
        $this->authorize($this->social);
163
    }
164
165
    /** Main sign in template */
166
    public function __base()
167
    {
168
        // Change template
169
        $this->system->template('www/signin/signin_template.vphp');
170
171
        // Render template with sign in form
172
        $this->html($this->view('www/signin/signin_form')->output())
173
            ->title(t('Авторизация', true));
174
    }
175
176
    /** User asynchronous sign in */
177
    public function __async_login()
178
    {
179
        $user = null;
180
        $error = '';
181
182
        if (isset($_POST['email']) && isset($_POST['password'])) {
183
            $email = $this->social->hash($_POST['email']);
184
            $password = $this->social->hash($_POST['password']);
185
            $remember = isset($_POST['remember']) ? true : false;
186
187
            /** @var EmailStatus Perform email authorization */
188
            $auth = $this->social->authorizeWithEmail($email, $password, $remember, $user);
189
190
            if ($auth->code === EmailStatus::SUCCESS_EMAIL_AUTHORIZE) {
191
                // Fire login success event
192
                Event::fire('samson.cms.signin.login', array(&$user));
193
194
                return array('status' => '1');
195
            } else {
196
                $error .= $this->view('www/signin/signin_form.vphp')
197
                    ->errorClass('errorAuth')
198
                    ->userEmail("{$_POST['email']}")
199
                    ->focus('autofocus')
200
                    ->output();
201
202
                return array('status' => '0', 'html' => $error);
203
            }
204
        } else {
205
            $error .= $this->view('www/signin/signin_form')->errorClass('errorAuth')->output();
206
207
            return array('status' => '0', 'html' => $error);
208
        }
209
    }
210
211
    /** User logout */
212
    public function __logout()
213
    {
214
        $this->social->deauthorize();
215
216
        // Fire logout event
217
        Event::fire('samson.cms.signin.logout');
218
219
        $this->request->redirect('cms/signin');
220
    }
221
222
    /** Sending email with the correct address */
223
    public function __mail()
224
    {
225
        if (isset($_POST['email'])) {
226
            /** @var \samson\activerecord\user $user */
227
            $user = null;
0 ignored issues
show
$user is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
228
            $result = '';
229
230
            if (!empty($user = (new UserQuery())->email($_POST['email'])->first())) {
231
                $user->confirmed = $this->social->hash(generate_password(20) . time());
232
                $user->save();
233
234
                $message = $this->view('www/signin/email/pass_recovery')->code($user->confirmed)->output();
235
                mail_send($user->email, '[email protected]', $message, t('Восстановление пароля!', true), 'SamsonCMS');
236
237
                $result .= $this->view('www/signin/pass_recovery_mailsend')->output();
238
                $this->system->template('www/signin/signin_template.vphp');
239
                $this->html($result)->title(t('Восстановление пароля', true));
240
            } else {
241
                $this->request->redirect();
242
            }
243
        } else {
244
            $this->request->redirect();
245
        }
246
    }
247
248
    /**
249
     * New password form.
250
     *
251
     * @param string $code Code password recovery
252
     *
253
     * @return bool
254
     */
255
    public function __confirm($code)
256
    {
257
        $code = substr($code, 0, 32);
258
        $rights = (new UserQuery())->confirmed($code)->first();
259
260
        if (!empty($rights)) {
261
            $this->system->template('www/signin/signin_template.vphp');
262
            $this->html($this->view('www/signin/new_pass_form')->code($code)->output())
263
                ->title(t('Восстановление пароля', true));
264
        } else {
265
            return A_FAILED;
266
        }
267
    }
268
269
    /**
270
     * Setting new password and sign in
271
     *
272
     * @param string $code Code password recovery
273
     */
274
    public function __recovery($code)
275
    {
276
        if (isset($_POST['password']) && isset($_POST['confirm_password'])
277
            && $_POST['password'] == $_POST['confirm_password']
278
        ) {
279
            /** @var \samson\activerecord\user $user */
280
            $user = null;
281
            if (!empty($user = (new UserQuery())->confirmed($code)->first())) {
282
                $user->confirmed = 1;
283
                $user->md5_password = md5($_POST['password']);
284
                $user->hash_password = md5($_POST['password']);
285
                $user->save();
286
287
                $auth = $this->social->authorizeWithEmail($user->md5_email, $user->md5_password, $user);
288
                if ($auth->code === EmailStatus::SUCCESS_EMAIL_AUTHORIZE) {
289
                    $this->request->redirect();
290
                }
291
            }
292
        } else {
293
            $result = '';
294
            $result .= m()->view('www/signin/pass_error')
295
                ->message(t('Вы ввели некорректный пароль либо пароли не совпадают', true))
296
                ->output();
297
            $this->system->template('www/signin/signin_template.vphp');
298
            $this->html($result)->title(t('Ошибка восстановление пароля', true));
299
        }
300
    }
301
}
302